10062 2016-08-02 10:56:20 +0000 useradd dollar sign requires three prepending backslash characters to avoid unintended expansion 2016-08-26 08:09:47 +0000 1 1 7 Build System, Metadata & Runtime OE-Core core 2.1 All Multiple RESOLVED FIXED Medium normal 2.2 1 niko.mauno maxin.john meta.mr.watcher meta.watcher sgw --- Regression (Used to work) Don't know oldest_to_newest 64779 0 niko.mauno 2016-08-02 10:56:20 +0000 In Krogoth when calling "useradd -p '<encrypted_password>' ..." in EXTRA_USERS_PARAMS, it is now necessary to escape dollar signs in <encrypted password> with three prepending backslashes, whereas before Krogoth just one prepending backslash was sufficient to avoid unintended expansion. I would suspect this change in behaviour was introduced in commit 57a525ca7271a8fe3913c61aa87cb0ba1674b4b2 - later commit 9fe3d01f27445652c3020413d66a5cdeb3c3259c apparently addresses the problem wrt. usermod call, but not useradd. As a possible fix, I removed (locally) the "apostrophe-to-double-quote-conversion" operation from useradd (and groupadd also, for good measure) - which seemed like a safe thing to do after the change introduced in commit 9fe3d01f27445652c3020413d66a5cdeb3c3259c. The change is below: --- a/meta/classes/useradd_base.bbclass +++ b/meta/classes/useradd_base.bbclass @@ -17,7 +17,6 @@ perform_groupadd () { local groupname=`echo "$opts" | awk '{ print $NF }'` local group_exists="`grep "^$groupname:" $rootdir/etc/group || true`" if test "x$group_exists" = "x"; then - opts=`echo $opts | sed s/\'/\"/g` eval flock -x $rootdir${sysconfdir} -c \"$PSEUDO groupadd \$opts\" || true group_exists="`grep "^$groupname:" $rootdir/etc/group || true`" if test "x$group_exists" = "x"; then @@ -35,7 +34,6 @@ perform_useradd () { local username=`echo "$opts" | awk '{ print $NF }'` local user_exists="`grep "^$username:" $rootdir/etc/passwd || true`" if test "x$user_exists" = "x"; then - opts=`echo $opts | sed s/\'/\"/g` eval flock -x $rootdir${sysconfdir} -c \"$PSEUDO useradd \$opts\" || true user_exists="`grep "^$username:" $rootdir/etc/passwd || true`" if test "x$user_exists" = "x"; then As an example of this issue, the following entry in EXTRA_USERS_PARAMS: "groupadd voter; useradd -p '\$6\$ASFORME\$IDONTTHINKTHAT.VOTING/IS/STUPID/' -g voter -G users voter;" without the above change translates to following line in /etc/shadow: "voter:.VOTING/IS/STUPID/:17015:0:99999:7:::" Thus logging in as user 'voter' will not work against the provided (encrypted) password on the target system. With the above "possible fix" change included, the associated resulting line in /etc/shadow is now: "voter:$6$ASFORME$IDONTTHINKTHAT.VOTING/IS/STUPID/:17015:0:99999:7:::" which would seem to revert the adduser dollar sign escaping behaviour to pre-Krogoth -style. 65218 1 3359 maxin.john 2016-08-16 08:56:35 +0000 Created attachment 3359 useradd recipe for verification 65381 2 maxin.john 2016-08-22 05:37:26 +0000 patch sent to oe-core: http://lists.openembedded.org/pipermail/openembedded-core/2016-August/125171.html 65453 3 niko.mauno 2016-08-23 15:26:06 +0000 I noticed the change in poky's master-next - will this fix also be backported to Krogoth? 65457 4 maxin.john 2016-08-23 16:00:13 +0000 (In reply to comment #3) > I noticed the change in poky's master-next - will this fix also be > backported to Krogoth? Yes, this fix looks like a good candidate for backporting to Krogoth as well. 65476 5 maxin.john 2016-08-24 08:46:19 +0000 Fix in master branch: http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=e8168a55e7a1e1bd2081c4bbe25c1c852937b695 65553 6 maxin.john 2016-08-26 08:09:47 +0000 Fix available in master branch. Requested for cherry-pick to krogoth. 3359 2016-08-16 08:56:35 +0000 2016-08-16 08:56:35 +0000 useradd recipe for verification useraddtest-a.bb application/octet-stream 434 maxin.john U1VNTUFSWSA9ICJ1c2VyYWRkIHRlc3QgQSIKTElDRU5TRSA9ICJNSVQiCkxJQ19GSUxFU19DSEtT VU0gPSAiZmlsZTovLyR7Q09SRUJBU0V9L0xJQ0VOU0U7bWQ1PTRkOTJjZDM3M2FiZGEzOTM3YzJi YzQ3ZmJjNDlkNjkwIFwKICAgICAgICAgICAgICAgICAgICBmaWxlOi8vJHtDT1JFQkFTRX0vbWV0 YS9DT1BZSU5HLk1JVDttZDU9M2RhOWNmYmNiNzg4YzgwYTAzODQzNjFiNGRlMjA0MjAiCgpBTExP V19FTVBUWV8ke1BOfSA9ICIxIgppbmhlcml0IHVzZXJhZGQKVVNFUkFERF9QQUNLQUdFUyA9ICIk e1BOfSIKCkdST1VQQUREX1BBUkFNXyR7UE59ID0gIiAtLXN5c3RlbSB2b3RlciIKVVNFUkFERF9Q QVJBTV8ke1BOfSA9ICIgLXAgJ1wkNlwkQVNGT1JNRVwkSURPTlRUSElOS1RIQVQuVk9USU5HL0lT L1NUVVBJRC8nIC1nIHZvdGVyIC1HIHVzZXJzIHZvdGVyIgo=