<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>10251</bug_id>
          
          <creation_ts>2016-09-09 06:46:30 +0000</creation_ts>
          <short_desc>linux-firmware packages include licenses from all firmware packages</short_desc>
          <delta_ts>2016-09-23 03:37:32 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>deployment</component>
          <version>2.2</version>
          <rep_platform>All</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.2 M4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jonathan Liu">net147</reporter>
          <assigned_to name="Saul Wold">sgw</assigned_to>
          <cc>anibal.limon</cc>
    
    <cc>bluelightning</cc>
    
    <cc>ross.burton</cc>
    
    <cc>sgw</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>65971</commentid>
    <comment_count>0</comment_count>
    <who name="Jonathan Liu">net147</who>
    <bug_when>2016-09-09 06:46:30 +0000</bug_when>
    <thetext>1. local.conf contains:
COPY_LIC_MANIFEST = &quot;1&quot;
COPY_LIC_DIRS = &quot;1&quot;
2. linux-firmware-ralink is added to image
3. If you check /usr/share/common-licenses/linux-firmware-ralink, it has licenses for all the firmware packages. license.manifest shows &quot;LICENSE: Firmware-ralink-firmware&quot; for the linux-firmware-ralink package
4. If you check /usr/share/common-licenses/linux-firmware-ralink-license, it has licenses for all the firmware packages. license.manifest shows &quot;LICENSE: Firmware-Abilis &amp; [...] &amp; Firmware-xc5000c     &amp; WHENCE&quot;.

So we need to do the following:
 * License for each linux-firmware-*-license package should be set correctly
 * Copy only the licenses for a package to the package&apos;s licenses directory and not the licenses for the recipe (which will have the licenses of all the packages)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>66235</commentid>
    <comment_count>1</comment_count>
    <who name="Saul Wold">sgw</who>
    <bug_when>2016-09-16 02:45:24 +0000</bug_when>
    <thetext>Seems that the linux-firmware base package has an RDEPENDS on the generic linux-firmware-license package which includes all the licenses.

Still digging</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>66453</commentid>
    <comment_count>2</comment_count>
    <who name="Saul Wold">sgw</who>
    <bug_when>2016-09-22 02:54:43 +0000</bug_when>
    <thetext>http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=77a9472a4b4ff2daa9171eaae9ee10f1f8527a0d</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>66468</commentid>
    <comment_count>3</comment_count>
    <who name="Jonathan Liu">net147</who>
    <bug_when>2016-09-22 08:20:28 +0000</bug_when>
    <thetext>Not completely fixed.

The licenses directory still has licenses for all the firmware packages in:
 * /usr/share/common-licenses
 * /usr/share/common-licenses/linux-firmware-ralink
 * /usr/share/common-licenses/linux-firmware-ralink-license</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>66535</commentid>
    <comment_count>4</comment_count>
    <who name="Saul Wold">sgw</who>
    <bug_when>2016-09-23 00:02:32 +0000</bug_when>
    <thetext>Ok, so a little more research, the Manifest is generated on way based on the actual packages installed on the target rootfs. The License Directory is copied from the licenses provided by the recipe (so not on a package basis), to change this would require a pretty good re-write in the license.bbclass. THis actually affects all packages that might have multiple licenses, but only ship limited licneses in each package.

Unless this is really urgent, I am going to close this one and will re-open a more general bug against license.bbclass</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>66537</commentid>
    <comment_count>5</comment_count>
    <who name="Saul Wold">sgw</who>
    <bug_when>2016-09-23 03:37:32 +0000</bug_when>
    <thetext>So we have fixed part of the problem that pertains to linux-firwmare license packages having the incorrect licenses.

There is an problem that is generic to all packages that copies the working set of licenses to the target image based on the recipe&apos;s licenses vs the actual installed packages.

A new bug#10325 has been created to address this in 2.3</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>