10349 2016-09-29 17:16:46 +0000 renameat() loses extended attributes 2016-10-06 15:46:31 +0000 1 1 6 Yocto Project Subprojects Pseudo pseudo master x86 x86_64 RESOLVED FIXED Medium+ normal 2.2 M4 1 anton joshuagloe anton joshuagloe seebs yp.pseudo.watcher yp.watcher --- --- No (bug/feature does not impact docs) oldest_to_newest 66729 0 3445 anton 2016-09-29 17:16:46 +0000 Created attachment 3445 Utility to reproduce the bug For some reason after renameat() extended attributes are no more there. Strangely enough it is not the case with plain rename(). The attached program gives no error in normal environment and outputs "fgetattr: no data available" in pseudo. try as root: make; make test 66751 1 seebs 2016-09-30 13:53:55 +0000 Huh. That's mildly surprising, renameat() shouldn't need to do anything about extended attributes unless it's moving across filesystems, since xattrs are stored by dev/inode. I'll try to get a look. 66755 2 anton 2016-09-30 15:01:45 +0000 Thank you! I was debugging communication from the client side (calls to pseudo_client_request) and the only difference between rename and renameat that I've noticed is that rename (healthy one) OP_STATs the old file and doesn't OP_LINK it, while renameat (th buggy one) goes directly to OP_LINK without OP_STAT. One can actually see the difference in ports/unix/guts/rename(at).c - lines 37-39 in rename.c that are missing in renameat.c. Could you please tell me, what is the reason for this difference? I couldn't figure it out yet. 66763 3 anton 2016-09-30 15:50:10 +0000 I've sent a patch with possible solution. I've tested it shortly on my utility, but I don't know pseudo good enough to be sure that it doesn't break anything. Please take a look. https://lists.yoctoproject.org/pipermail/poky/2016-September/010725.html 67002 4 seebs 2016-10-06 15:41:48 +0000 The patch is correct and is now merged in upstream. 67006 5 joshuagloe 2016-10-06 15:46:31 +0000 Submitted for inclusion in the upcoming release: http://lists.openembedded.org/pipermail/openembedded-core/2016-October/127359.html 3445 2016-09-29 17:16:46 +0000 2016-09-29 17:16:46 +0000 Utility to reproduce the bug test-fsetxattr.tar.gz application/gzip 852 anton H4sIAFJL7VcAA+1WbW/aMBDmK/kVNzZpoQJKAhSpL5O2lA/TGJEoWlt1FUoTB6KGBNlOVdr1v+/s hJaEvq1SO1Xy8wXf+bm7x/bZZOYEUcMtvSqaiK12W/wa3U5z9Veg1TKNkmF2uy2z3e62O6WmYZhb 7RI0X1dWioRxhwKU4gUP2CO8p+bfKT4GkRsmHoFdtmCblw7ntDH9ouXdfDEnbN2NO8fzXt+NeFgg ci8MztZ8QZx3EUrjYmVOg2iS9yVRgMHCpwURhxl2L+hi5NCJWwN36tCNDWFcVLVrrRz4oIsZ+LAH nSqgp0wuA67XjeqOVr7RBEOfnXsBFbSLE+O0Bs1up1NNuXOpSq9IRkWErIVjac/3YA/iOYnuktjj 4b496B/DH8DxwB5869vWD7Ts8f73Yc8a2cNjaVl9u3fUs+R4YFuj0bFILXTLtHuAtXJabKwDKIe4 PKaLe0RJTbeSHC4S1eSWnJhS2eEwU4bVh72vIznqHVn9VUG4D3hll1oekeIHIbl3a+RZQOTMCEqp MOImNOCLBrnkJPKIV9lJKXDhhAk5ORWkgxjJ0q4sCzPCZVPqYhEiWS0l1IAFVyT2dWlVUW7hzESk CLxfWxgzginRLrZA64UtMKa5Jmi9YROAH1OgROyO9/B5pIS1fpDSM7t9Kjek0Dwr07n2uRP+jDZ5 Ul7aLpQ43lgeKUpo4hQTxzzmwK7Q4U/Wu+EuQvRAep6gI30XzXxHTB7piFzhmROGsYtJZL6lBErY MzRkQUKECPgHFUBCRmAZiC8WppKh/hwfQu7r+PJhkhpUhlhP9j94MWHRZ/EQcncKfEpgTkld6IE4 Ir+jQpVyutgsX+UgcV3CmJ+E4UIuQmYQ6oKzhGfh6QUhM3c217M1FtZbFcvLUh7iJccLDk7kpRkl jaHQW5mZKrHalcBfKW+Fkbum2dgrGGMqTEp4QiPRLzfa//5DfWf46ZwTcSdfs8YT339N0+wuv/86 piG//7bQpb7/3gAaPnXbWvnTtWXdyM+phgv1GDhhvH7756tpbkicCHl1OivOSV+d+uAZK2NT0wRv +8HpcmMznwgJ4Bs4Bb6pbrGCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCwkvwFypFvsUAKAAA