10360 2016-10-01 14:12:19 +0000 Add link to the OpenEmbedded style guide 2016-10-03 19:30:24 +0000 1 1 9 Documentation Development Manual development 2.2 x86 Multiple RESOLVED FIXED 03 Oct 2016: RESOLVED Undecided normal 2.2 M4 1 ulfalizer srifenbark bluelightning srifenbark --- --- Done (doc changes complete) oldest_to_newest 66784 0 ulfalizer 2016-10-01 14:12:19 +0000 Hello, I think it would be helpful if the development manual linked to the OpenEmbedded Styleguide wiki page. Here's a proposed new section: 5.3.21. Recipe style The [OpenEmbedded Styleguide](http://www.openembedded.org/wiki/Styleguide) wiki page provides rough guidelines for preferred recipe style. It is common for existing recipes to deviate a bit from this style, but aiming for at least a consistent style is a good idea. Some practices, like omitting spaces around '=' in assignments or ordering recipe components in an erratic way, are widely seen as poor style. As an unrelated nit, there's a missing " here: SRC_URI = "${DEBIAN_MIRROR}/main/a/apmd/apmd_3.2.2.orig.tar.gz;name=tarball \ ${DEBIAN_MIRROR}/main/a/apmd/apmd_${PV}.diff.gz;name=patch Cheers, Ulf 66820 1 srifenbark 2016-10-03 17:24:09 +0000 Ulf, Here is the new section - http://www.yoctoproject.org/docs/2.2/dev-manual/dev-manual.html#following-recipe-style-guidelines. Here is the link to see the fix for the missing quote - http://www.yoctoproject.org/docs/2.2/dev-manual/dev-manual.html#new-recipe-fetching-code Thanks, Scott 66827 2 ulfalizer 2016-10-03 18:11:45 +0000 Looks good to me! Thanks, Ulf 66834 3 srifenbark 2016-10-03 19:30:24 +0000 Thanks, Setting to RESOLOVED and putting the doc flag to "done." Scott