10403 2016-10-09 22:06:00 +0000 [PATCH] configure --cflags breaks when CFLAGS contain commas 2016-10-13 16:14:12 +0000 1 1 6 Yocto Project Subprojects Pseudo pseudo unspecified x86 Multiple RESOLVED FIXED Medium normal 2.3 1 dominik mark.hatle joshuagloe seebs yp.pseudo.watcher yp.watcher --- --- Don't know oldest_to_newest 67081 0 3464 dominik 2016-10-09 22:06:00 +0000 Created attachment 3464 configure: support using comma (,) in flags passed to --cflags Preconditions/Environment ------------------------- pseudo-1.8.1 on Fedora rawhide Triggering Action/Cause ----------------------- ./configure --bits=64 --cflags='-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic' --enable-memory-db --enable-xattr --enable-xattrdb --libdir=/usr/lib64/pseudo --prefix=/usr --without-rpath Expectation ----------- No errors. Actual Result ------------- SQLite header for version 3014002 found in /usr. sed: -e expression #1, char 239: unknown option to `s' Reproducibility --------------- 100% That's because the sed expression at configure:321 uses commas as sed expression separator. The solution is to use another separator that doesn't occur in CFLAGS, like !, which is what is done for RPATH already. Proposed patch attached. 67214 1 joshuagloe 2016-10-13 14:48:57 +0000 Adding Seebs to CC. Peter, Mark — do we prefer pseudo patches to the mailing list? 67215 2 seebs 2016-10-13 14:50:35 +0000 In general, yeah, but this one's probably fine. Of course the real problem is that ! can also occur in cflags. LOTS of things can occur in cflags. I think the workaround I usually use is to first run cflags through s/,/\\,/ or something. I'll poke it a bit. 67226 3 seebs 2016-10-13 16:06:48 +0000 Added fix in upstream. One-line configure change: +arch_flags=$(echo "$arch_flags" | sed -e 's/,/\\,/g') 67227 4 seebs 2016-10-13 16:14:12 +0000 Fixed in upstream. Doesn't seem to affect yocto. (Fix is only in master, but it'll be included in next bugfix/point release.) 3464 2016-10-09 22:06:00 +0000 2016-10-09 22:06:00 +0000 configure: support using comma (,) in flags passed to --cflags pseudo-comma-in-cflags.patch text/plain 506 dominik ZGlmZiAtdXAgcHNldWRvLTEuOC4xL2NvbmZpZ3VyZS5vcmlnIHBzZXVkby0xLjguMS9jb25maWd1 cmUKLS0tIHBzZXVkby0xLjguMS9jb25maWd1cmUub3JpZwkyMDE2LTA3LTA4IDExOjM3OjA1LjAw MDAwMDAwMCArMDIwMAorKysgcHNldWRvLTEuOC4xL2NvbmZpZ3VyZQkyMDE2LTEwLTA5IDIzOjQ1 OjE5LjMxODQyMzA3NCArMDIwMApAQCAtMzI3LDcgKzMyNyw3IEBAIHNlZCAtZSAnCiAgIHMsQExJ QkAsJyIkb3B0X2xpYiInLGcKICAgcyxAU1VGRklYQCwnIiRvcHRfc3VmZml4IicsZwogICBzLEBT UUxJVEVALCciJG9wdF9zcWxpdGUiJyxnCi0gIHMsQEFSQ0hfRkxBR1NALCciJGFyY2hfZmxhZ3Mi JyxnCisgIHMhQEFSQ0hfRkxBR1NAISciJGFyY2hfZmxhZ3MiJyFnCiAgIHMsQERFRkFVTFRfU1FM SVRFQCwnIiRkZWZhdWx0X3NxbGl0ZSInLGcKICAgcyxAU1FMSVRFX0xEQVJHQCwnIiRzcWxpdGVf bGRhcmciJyxnCiAgIHMsQFNRTElURV9MSUJALCciJG9wdF9zcWxpdGVfbGliIicsZwo=