10412 2016-10-11 21:25:49 +0000 Specifying milestone with a DISTRO_VERSION in format of MM.mm.pp will cause build to fail on GetDistroVersion 2017-03-27 17:29:50 +0000 1 1 5 Infrastructure AutoBuilder autobuilder unspecified All Multiple VERIFIED FIXED Medium+ normal 2.3 M2 1 tracy.graydon joshuagloe infras.ab.watcher Infras.watcher jose.perez.carranza mhalstead pidge richard.purdie ross.burton oscarx.lopez.arandas --- --- Don't know oldest_to_newest 67154 0 3468 tracy.graydon 2016-10-11 21:25:49 +0000 Created attachment 3468 error log for example of build failure When generating a release candidate on the autobuilder, selecting "Milestone" with a DISTRO_VERSION in poky.conf in format of "MM.mm.pp" will cause GetDistroVersion to barf and build will fail. It will throw "exceptions.ValueError: invalid literal for float(): 2.2.0", as an example. i.e. https://autobuilder.yoctoproject.org/main/builders/nightly/builds/1046/steps/GetDistroVersion/logs/err.html (text and a screenshot attached) Autobuilder should probably check for a mismatch between release type and distroversion and warn or otherwise act accordingly. i.e. In this specific case, catch milestone combined with point release distro version and do something smarter. 67155 1 tracy.graydon 2016-10-11 21:29:17 +0000 Snippet from poky.conf as an example of what GetDistroVersion.py does not like: DISTRO = "poky" DISTRO_NAME = "Poky (Yocto Project Reference Distro)" DISTRO_VERSION = "2.2.0" <------ Makes GetDistroVersion barf. 67156 2 ross.burton 2016-10-11 21:55:42 +0000 FWIW the standard library has a "version" objection in distutils (IIRC) which can represent versions like 1.2.3-rc2~beta and do comparisons etc, instead of abusing a float. 69723 3 joshuagloe 2017-01-11 16:43:07 +0000 (In reply to comment #0) > Autobuilder should probably check for a mismatch between release type and > distroversion and warn or otherwise act accordingly. i.e. In this specific > case, catch milestone combined with point release distro version and do > something smarter. Any suggestion on how best to act accordingly? We can fail early here and cause the build to fail, that would certainly be smarter than throwing an exception. 69724 4 joshuagloe 2017-01-11 16:50:26 +0000 (In reply to comment #2) > FWIW the standard library has a "version" objection in distutils (IIRC) > which can represent versions like 1.2.3-rc2~beta and do comparisons etc, > instead of abusing a float. I don't know if that helps us here. The autobuilder is trying to be smart and automatically increase the version number for a milestone build and then check it matches the yocto number input into the build trigger form. I think this mostly works because we: a) we don't do milestone builds for point releases (is this true?) b) we only bump version number in poky.conf when we're ready to release so, for example, during milestone releases for pyro (2.3) the poky.conf DISTRO_VERSION is still 2.2 (morty's version number) and we add 0.1 to that and stringify it to get "2.3" for pyro milestone builds. If we use, i.e. distutils.version.LooseVersion, there's no easy way to bump the version number for milestone releases. I think what we should probably do is split the value of DISTRO_VERSION on .'s and fail early if there are more than 2 items in the list returned from the split call. 69725 5 joshuagloe 2017-01-11 16:53:36 +0000 (In reply to comment #4) > (In reply to comment #2) > > FWIW the standard library has a "version" objection in distutils (IIRC) > > which can represent versions like 1.2.3-rc2~beta and do comparisons etc, > > instead of abusing a float. > > I don't know if that helps us here. The autobuilder is trying to be smart > and automatically increase the version number for a milestone build and then > check it matches the yocto number input into the build trigger form. > > I think this mostly works because we: > a) we don't do milestone builds for point releases (is this true?) > b) we only bump version number in poky.conf when we're ready to release > > so, for example, during milestone releases for pyro (2.3) the poky.conf > DISTRO_VERSION is still 2.2 (morty's version number) and we add 0.1 to that > and stringify it to get "2.3" for pyro milestone builds. > > If we use, i.e. distutils.version.LooseVersion, there's no easy way to bump > the version number for milestone releases. > > I think what we should probably do is split the value of DISTRO_VERSION on > .'s and fail early if there are more than 2 items in the list returned from > the split call. And/or we could just catch the ValueError Exception and fail appropriately then. 69854 6 joshuagloe 2017-01-17 12:32:11 +0000 I've updated GetDistroVersion to fail as explained in previous comments and also write a log with the reason for failing. 69959 7 joshuagloe 2017-01-20 13:21:54 +0000 http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder/commit/?id=dbe0d927bb16500e1cadf632221fb9d32a22e31e 71756 8 oscarx.lopez.arandas 2017-03-27 17:29:50 +0000 ENVIRONMENT: genericx86-64 on NUC STEPS TO REPRODUCE: 1. Download the core-image-sato-sdk image from autobuilder. 2. Make checkout on the poky commit from the mail: "9fe7a69535f9443175da8289633a761f58c372ff" 3. Source the environment, from poky directory 4. Edit local.conf. PATH: ~/poky/build/conf, at the en of the file adding: DISTRO = "poky" DISTRO_NAME = "Poky (Yocto Project Reference Distro)" DISTRO_VERSION = "2.2.0" 5. In ~poky/build directory, in command line, type the following commands: $ bitbake rpm psplash run-postinsts $ bitbake package-index 6. $ bitbake core-image-sato-sdk -c testimage 3468 2016-10-11 21:25:49 +0000 2016-10-11 21:25:49 +0000 error log for example of build failure error_log.txt text/plain 1565 tracy.graydon VHJhY2ViYWNrIChtb3N0IHJlY2VudCBjYWxsIGxhc3QpOgogIEZpbGUgIi9ob21lL3Bva3lidWls ZC95b2N0by1hdXRvYnVpbGRlci9saWIvcHl0aG9uMi43L3NpdGUtcGFja2FnZXMvVHdpc3RlZC0x Mi4yLjAtcHkyLjctbGludXgteDg2XzY0LmVnZy90d2lzdGVkL2ludGVybmV0L2RlZmVyLnB5Iiwg bGluZSAyOTAsIGluIGFkZENhbGxiYWNrcwogICAgc2VsZi5fcnVuQ2FsbGJhY2tzKCkKICBGaWxl ICIvaG9tZS9wb2t5YnVpbGQveW9jdG8tYXV0b2J1aWxkZXIvbGliL3B5dGhvbjIuNy9zaXRlLXBh Y2thZ2VzL1R3aXN0ZWQtMTIuMi4wLXB5Mi43LWxpbnV4LXg4Nl82NC5lZ2cvdHdpc3RlZC9pbnRl cm5ldC9kZWZlci5weSIsIGxpbmUgNTUxLCBpbiBfcnVuQ2FsbGJhY2tzCiAgICBjdXJyZW50LnJl c3VsdCA9IGNhbGxiYWNrKGN1cnJlbnQucmVzdWx0LCAqYXJncywgKiprdykKICBGaWxlICIvaG9t ZS9wb2t5YnVpbGQveW9jdG8tYXV0b2J1aWxkZXIvbGliL3B5dGhvbjIuNy9zaXRlLXBhY2thZ2Vz L1R3aXN0ZWQtMTIuMi4wLXB5Mi43LWxpbnV4LXg4Nl82NC5lZ2cvdHdpc3RlZC9pbnRlcm5ldC9k ZWZlci5weSIsIGxpbmUgMzY4LCBpbiBjYWxsYmFjawogICAgc2VsZi5fc3RhcnRSdW5DYWxsYmFj a3MocmVzdWx0KQogIEZpbGUgIi9ob21lL3Bva3lidWlsZC95b2N0by1hdXRvYnVpbGRlci9saWIv cHl0aG9uMi43L3NpdGUtcGFja2FnZXMvVHdpc3RlZC0xMi4yLjAtcHkyLjctbGludXgteDg2XzY0 LmVnZy90d2lzdGVkL2ludGVybmV0L2RlZmVyLnB5IiwgbGluZSA0NjQsIGluIF9zdGFydFJ1bkNh bGxiYWNrcwogICAgc2VsZi5fcnVuQ2FsbGJhY2tzKCkKLS0tIDxleGNlcHRpb24gY2F1Z2h0IGhl cmU+IC0tLQogIEZpbGUgIi9ob21lL3Bva3lidWlsZC95b2N0by1hdXRvYnVpbGRlci9saWIvcHl0 aG9uMi43L3NpdGUtcGFja2FnZXMvVHdpc3RlZC0xMi4yLjAtcHkyLjctbGludXgteDg2XzY0LmVn Zy90d2lzdGVkL2ludGVybmV0L2RlZmVyLnB5IiwgbGluZSA1NTEsIGluIF9ydW5DYWxsYmFja3MK ICAgIGN1cnJlbnQucmVzdWx0ID0gY2FsbGJhY2soY3VycmVudC5yZXN1bHQsICphcmdzLCAqKmt3 KQogIEZpbGUgIi9ob21lL3Bva3lidWlsZC95b2N0by1hdXRvYnVpbGRlci9saWIvcHl0aG9uMi43 L3NpdGUtcGFja2FnZXMvYnVpbGRib3QtMC44LjgtcHkyLjcuZWdnL2J1aWxkYm90L3Byb2Nlc3Mv YnVpbGRzdGVwLnB5IiwgbGluZSA4NjYsIGluIDxsYW1iZGE+CiAgICBkLmFkZENhbGxiYWNrKGxh bWJkYSByZXM6IHNlbGYuY29tbWFuZENvbXBsZXRlKGNtZCkpCiAgRmlsZSAiL2hvbWUvcG9reWJ1 aWxkL3lvY3RvLWF1dG9idWlsZGVyL2xpYi9weXRob24yLjcvc2l0ZS1wYWNrYWdlcy9hdXRvYnVp bGRlci9idWlsZHN0ZXBzL0dldERpc3Ryb1ZlcnNpb24ucHkiLCBsaW5lIDY1LCBpbiBjb21tYW5k Q29tcGxldGUKICAgIGRpc3Ryb3ZlcnNpb24gPSBzdHIoZmxvYXQoZGlzdHJvdmVyc2lvbi5yZXBs YWNlKCcrc25hcHNob3QnLCcnKSkrMC4xKQpleGNlcHRpb25zLlZhbHVlRXJyb3I6IGludmFsaWQg bGl0ZXJhbCBmb3IgZmxvYXQoKTogMi4yLjA=