10433 2016-10-13 23:06:48 +0000 syslog-ng rc5.d symlinks missing after install, broken postinst 2017-02-13 13:46:01 +0000 1 1 7 Build System, Metadata & Runtime Other YP Layers layers unspecified x86 Multiple RESOLVED FIXED Need backport to 2.2.1 Medium+ normal 2.3 M2 1 haris.okanovic markus.lehtonen adrian.ratiu freesilicon markus.lehtonen poky.bs.watcher poky.watcher ross.burton --- --- No (bug/feature does not impact docs) oldest_to_newest 67248 0 3476 haris.okanovic 2016-10-13 23:06:48 +0000 Created attachment 3476 A workaround for update-alternatives and update-rc.d ordering issue in syslog-ng syslog-ng's postinst script appears to be broken. It calls `update-alternatives` to alias it's init.d script (synlink syslog --> syslog.syslog-ng) and `update-rc.d` to install start-up symlinks (in rc[2-5].d); but they happen in the wrong order. It first attempts update-rc.d on the aliased init.d filename (syslog) which doesn't exist yet, then it calls update-alternatives to create it. Postinst returns 0, so opkg thinks syslog-ng was successfully installed and configured, but it won't start on boot-up. The bug appears to have been introduced by commit 03071511, which reversed the order of update-alternatives and update-rc.d (bbclass) inherits, to ironically fix a similar reordering issue in prerm! I've attached one possible (somewhat hacky) solution to both issues -- workaround.patch. See commit message for details. The correct fix will likely require some changes to update-alternatives and update-rc.d bbclasses in how they generate maintainer scripts. It seems like there should be some ordering guarantees between those two pieces of generated sh code. 68251 1 markus.lehtonen 2016-11-11 14:11:33 +0000 Seeing these bugs, I think using update-alternatives to manage init scripts is a bad idea altogether. Whatever ordering we have with the classes we always have some kind of a problem because of missing symlink at some point. I try to fix it by making the syslog packages work like any other daemon package in that regard: don't use update alternatives. 68482 2 markus.lehtonen 2016-11-22 12:30:07 +0000 Patches sent for oe-core and meta-oe: https://patchwork.openembedded.org/series/4013/ https://patchwork.openembedded.org/series/4014/ 68568 3 freesilicon 2016-11-24 08:13:13 +0000 I submitted the following series that rather modify the task ordering between update-alternatives and update-rc.d instead of simply removing it and creating RCONFLICTS: https://patchwork.openembedded.org/series/4061/ It has been successfully tested with syslog-ng on morty. It does not yet cleanly apply, but I will resubmit a v2 ASAP. 68569 4 markus.lehtonen 2016-11-24 10:21:05 +0000 (In reply to comment #3) > I submitted the following series that rather modify the task ordering > between update-alternatives and update-rc.d instead of simply removing it > and creating RCONFLICTS: I'm still not convinced that init scripts should be managed by update-alternatives. First, I don't see much reasoning why two syslog services should be installed in parallel. Also, no other package or distro use this kind of construction, AFAIK. If we really want to make these install in parallel I think we should just name the files differently, e.g. /etc/init.d/busybox-syslog /etc/init.d/sysklogd /etc/init.d/rsyslog ... 68571 5 freesilicon 2016-11-24 11:10:45 +0000 (In reply to comment #4) > (In reply to comment #3) > > I submitted the following series that rather modify the task ordering > > between update-alternatives and update-rc.d instead of simply removing it > > and creating RCONFLICTS: > > I'm still not convinced that init scripts should be managed by > update-alternatives. First, I don't see much reasoning why two syslog > services should be installed in parallel. Also, no other package or distro > use this kind of construction, AFAIK. Maybe there should be a virtual/logger, then ? But the problem could also be raised by cron daemons for example. In fact, I think the main problem lies with busybox which offers alternatives for such packages and these alternatives must be overridden when a new one is selected. > > If we really want to make these install in parallel I think we should just > name the files differently, e.g. > /etc/init.d/busybox-syslog > /etc/init.d/sysklogd > /etc/init.d/rsyslog > ... The problem is when using different names is that update-rc.d will install all links in rc*.d thus creating logger conflicts (I don't know if that's even possible but it's the general idea). 68572 6 markus.lehtonen 2016-11-24 11:23:22 +0000 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > I submitted the following series that rather modify the task ordering > > > between update-alternatives and update-rc.d instead of simply removing it > > > and creating RCONFLICTS: > > > > I'm still not convinced that init scripts should be managed by > > update-alternatives. First, I don't see much reasoning why two syslog > > services should be installed in parallel. Also, no other package or distro > > use this kind of construction, AFAIK. > > Maybe there should be a virtual/logger, then ? This doesn't work nicely because the virtual/* packages are on source package level. This syslog overlap is on binary (runtime) package level. My patch introduces VIRTUAL-RUNTIME_syslog just for this purpose. > But the problem could also be raised by cron daemons for example. In fact, I > think the main problem lies with busybox which offers alternatives for such > packages and these alternatives must be overridden when a new one is > selected. I think these should and are handled by VIRTUAL-RUNTIME_* definitions 68951 7 markus.lehtonen 2016-12-08 16:33:00 +0000 My latest patchset is here: http://git.openembedded.org/openembedded-core-contrib/log/?h=marquiz/fixes-10433 However, it isn't a possible solution because of bugs in opkg and smartpm (for deb backend it works as expected). A solution would be to merge David's patch, but as a temporary workaround. I'd suggest the following: 1. Merge David's patch 2. Close this bug 3. Create a new bug that would - be about reverting David's patch and merging my patches - block on bug 9675 - block on bug 10777 68973 8 freesilicon 2016-12-09 09:08:12 +0000 Before closing this bug, I just want to add that my patch is harmless in the long run. Even if a solution is found for this initscript/alternatives issue (for syslogd and any other daemons conflicting with busybox...), all it does is create comments inside prerm/postinst sections of package scripts and organize the two sections accordingly if update-rc.d and update-alternatives are both inherited in a recipe. I completely agree that initscripts should not be managed via alternatives but it is also not forbidden to do so. No distribution does this, because I think busybox is not used in them outside initramfs and conflicting packages like you did is perfect at handling this case. But the situation is different in the embedded world where busybox is always running somewhere... So before reverting it, I think it must be noted that this could be the kind of bug which reappears just because another layer is not so thoughtful about this. 68974 9 markus.lehtonen 2016-12-09 09:44:16 +0000 Busybox shouldn't be a problem, even in the present situation, because it is divided into multiple (runtime) sub-packages. Busybox-syslog can be replaced with something else even if the rest of busybox is installed in the system. The reason I'd like to get your patch reverted in the future, assuming we can achieve a "packaging-level solution", is that I'd like keep the code as simple as possible. Thus, even if it is harmless, I kind see it as a kludge to work around an issue in just one package. 69075 10 freesilicon 2016-12-13 08:39:06 +0000 OK, I now see your point. BTW, I resubmitted my patch since it did not apply on latest 'master', so there should be no problem merging it now. 69929 11 ross.burton 2017-01-19 11:49:49 +0000 Merged in oe-core aa87b1a4dcc14e4dfe719b6c55045c5662bc59c2. 70659 12 markus.lehtonen 2017-02-13 13:46:01 +0000 Fix backported and merged into morty: http://git.openembedded.org/openembedded-core/commit/?h=morty&id=b0c70bef015f1b2a30556a5db5e255592d5bf316 3476 2016-10-13 23:06:48 +0000 2016-10-13 23:06:48 +0000 A workaround for update-alternatives and update-rc.d ordering issue in syslog-ng workaround.patch text/plain 3768 haris.okanovic RnJvbSA1MDIwZjBhYjhhNDE5MjdmOGE3NTBhM2MyMTRmOTAzMzMzZmY4MmIwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIYXJpcyBPa2Fub3ZpYyA8aGFyaXMub2thbm92aWNAbmkuY29t PgpEYXRlOiBXZWQsIDEyIE9jdCAyMDE2IDE0OjMzOjM3IC0wNTAwClN1YmplY3Q6IFtQQVRDSF0g c3lzbG9nLW5nLmluYzogRml4IHBvc3RpbnN0IHNjcmlwdCBwcmV2ZW50aW5nIHN5c2xvZy1uZwog c3RhcnR1cCBvbiBib290CgpDaGFuZ2UgMDMwNzE1MTEgZml4ZXMgYW4gdXBkYXRlLWFsdGVybmF0 aXZlcyByZW9yZGVyaW5nIGlzc3VlIGluCnN5c2xvZy1uZydzIHByZXJtIHNjcmlwdCwgYnV0IGFs c28gY2F1c2VzIGFuIGluY29ycmVjdCByZW9yZGVyaW5nIG9mCnVwZGF0ZS1hbHRlcm5hdGl2ZXMg aW4gcG9zdGluc3QsIHdoaWNoIHNpbGVudGx5IGJyZWFrcyBpbnN0YWxsYXRpb24uCnN5c2xvZy1u ZyBkb2Vzbid0IHN0YXJ0IGFmdGVyIHBhY2thZ2UgaW5zdGFsbCBub3IgYXJlIHJjKi5kIHN5bWxp bmtzCmdlbmVyYXRlZCB0byBsYXVuY2ggc3lzbG9nLW5nIG9uIGJvb3QuIFRoZSBsYXR0ZXIgaXMg cGFydGljdWxhcmx5IGJhZAppbiBpbWFnZXMsIHNpbmNlIHN5c2xvZy1uZyB3aWxsIG5ldmVyIGJv b3QuCgpUaGUgZm9sbG93aW5nIGNoYW5nZXMgZml4IHRoaXMgaXNzdWU6CgogMS4gUmV2ZXJ0IGNv bW1pdCAwMzA3MTUxMTogInN5c2xvZy1uZy5pbmM6IGZpeCBwcmVybSBzY3JpcHQgJiBjbGFzcyBp bmNsdWRlcyIKIDIuIFdvcmsgYXJvdW5kIHVwZGF0ZS1hbHRlcm5hdGl2ZXMgcmVvcmRlcmluZyBp biBwcmVybSwgYnkgc3RvcHBpbmcKICAgIHN5c2xvZy1uZyB1c2luZyBpdCdzIHJlYWwgaW5pdC5k IHNjcmlwdCBpbiBhZGRpdGlvbiB0byB0aGUgYWxpYXMuCiAgICBTZWUgaW4tY29kZSBjb21tZW50 cyBmb3IgZGV0YWlscy4KCkRpZmZzIG9mIHN5c2xvZy1uZydzIHBvc3RpbnN0IGFuZCBwcmVybSBi ZWZvcmUgYW5kIGFmdGVyIHRoaXMgY2hhbmdlOgoKLS0tIGEvYmVmb3JlL3Bvc3RpbnN0CisrKyBi L2FmdGVyL3Bvc3RpbnN0CkBAIC0xLDQgKzEsNSBAQAogIyEvYmluL3NoCisgICAgICAgdXBkYXRl LWFsdGVybmF0aXZlcyAtLWluc3RhbGwgL2V0Yy9pbml0LmQvc3lzbG9nIHN5c2xvZy1pbml0IC9l dGMvaW5pdC5kL3N5c2xvZy5zeXNsb2ctbmcgMjAwCiBpZiB0eXBlIHVwZGF0ZS1yYy5kID4vZGV2 L251bGwgMj4vZGV2L251bGw7IHRoZW4KICAgICAgICBpZiBbIC1uICIkRCIgXTsgdGhlbgogICAg ICAgICAgICAgICAgT1BUPSItciAkRCIKQEAgLTcsNCArOCwzIEBAIGlmIHR5cGUgdXBkYXRlLXJj LmQgPi9kZXYvbnVsbCAyPi9kZXYvbnVsbDsgdGhlbgogICAgICAgIGZpCiAgICAgICAgdXBkYXRl LXJjLmQgJE9QVCBzeXNsb2cgc3RhcnQgMTkgMiAzIDQgNSAuIHN0b3AgOTAgMCAxIDYgLgogZmkK LSAgICAgICB1cGRhdGUtYWx0ZXJuYXRpdmVzIC0taW5zdGFsbCAvZXRjL2luaXQuZC9zeXNsb2cg c3lzbG9nLWluaXQgL2V0Yy9pbml0LmQvc3lzbG9nLnN5c2xvZy1uZyAyMDAKCi0tLSBhL2JlZm9y ZS9wcmVybQorKysgYi9hZnRlci9wcmVybQpAQCAtMSw1ICsxLDggQEAKICMhL2Jpbi9zaAorICAg ICAgIHVwZGF0ZS1hbHRlcm5hdGl2ZXMgLS1yZW1vdmUgIHN5c2xvZy1pbml0IC9ldGMvaW5pdC5k L3N5c2xvZy5zeXNsb2ctbmcgICAgIDwtLS0tIEEgc2lkZS1lZmZlY3Qgb2YgcmV2ZXJ0aW5nIGNv bW1pdCAwMzA3MTUxMS4uCiBpZiBbIC16ICIkRCIgXTsgdGhlbgogICAgICAgIC9ldGMvaW5pdC5k L3N5c2xvZyBzdG9wCiBmaQotICAgICAgIHVwZGF0ZS1hbHRlcm5hdGl2ZXMgLS1yZW1vdmUgIHN5 c2xvZy1pbml0IC9ldGMvaW5pdC5kL3N5c2xvZy5zeXNsb2ctbmcKK2lmIFsgLXogIiREIiBdOyB0 aGVuICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICA8LS0tLSAuLndvcmtlZCBhcm91bmQgaGVyZS4KKyAgICAgICAvZXRjL2luaXQuZC9z eXNsb2cuc3lzbG9nLW5nIHN0b3AKK2ZpCgpTaWduZWQtb2ZmLWJ5OiBIYXJpcyBPa2Fub3ZpYyA8 aGFyaXMub2thbm92aWNAbmkuY29tPgotLS0KIG1ldGEtb2UvcmVjaXBlcy1zdXBwb3J0L3N5c2xv Zy1uZy9zeXNsb2ctbmcuaW5jIHwgMTggKysrKysrKysrKysrKysrKystCiAxIGZpbGUgY2hhbmdl ZCwgMTcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL21ldGEtb2Uv cmVjaXBlcy1zdXBwb3J0L3N5c2xvZy1uZy9zeXNsb2ctbmcuaW5jIGIvbWV0YS1vZS9yZWNpcGVz LXN1cHBvcnQvc3lzbG9nLW5nL3N5c2xvZy1uZy5pbmMKaW5kZXggNGUwZjY5N2JjZTMyNDY0NWQ1 MmZjNmIyZWQ0ZjBhZTllN2Q3N2NlMy4uODZjNDhiMjI0MTg0ZDI1Zjc2NWQyNjM2NThkOTEwZWVl OGU5NTg3ZiAxMDA2NDQKLS0tIGEvbWV0YS1vZS9yZWNpcGVzLXN1cHBvcnQvc3lzbG9nLW5nL3N5 c2xvZy1uZy5pbmMKKysrIGIvbWV0YS1vZS9yZWNpcGVzLXN1cHBvcnQvc3lzbG9nLW5nL3N5c2xv Zy1uZy5pbmMKQEAgLTIyLDcgKzIyLDcgQEAgU1JDX1VSSSA9ICJodHRwOi8vd3d3LmJhbGFiaXQu Y29tL2Rvd25sb2Fkcy9maWxlcy9zeXNsb2ctbmcvc291cmNlcy8ke1BWfS9zb3VyY2UKICAgICAg ICAgICAgZmlsZTovL2NvbmZpZ3VyZS5hYy1hZGQtb3B0aW9uLWVuYWJsZS10aHJlYWQtdGxzLXRv LW1hbmFnZS0ucGF0Y2ggXAogIgogCi1pbmhlcml0IGF1dG90b29scyBzeXN0ZW1kIHBrZ2NvbmZp ZyB1cGRhdGUtYWx0ZXJuYXRpdmVzIHVwZGF0ZS1yYy5kCitpbmhlcml0IGF1dG90b29scyBzeXN0 ZW1kIHBrZ2NvbmZpZyB1cGRhdGUtcmMuZCB1cGRhdGUtYWx0ZXJuYXRpdmVzCiAKIEVYVFJBX09F Q09ORiA9ICIgXAogICAgIC0tZW5hYmxlLWR5bmFtaWMtbGlua2luZyBcCkBAIC0xMTYsMyArMTE2 LDE5IEBAIHB5dGhvbiAoKSB7CiAKIElOSVRTQ1JJUFRfTkFNRSA9ICJzeXNsb2ciCiBJTklUU0NS SVBUX1BBUkFNUyA9ICJzdGFydCAyMCAyIDMgNCA1IC4gc3RvcCA5MCAwIDEgNiAuIgorCisjIFhY WCB1cGRhdGUtcmMuZCBhbmQgdXBkYXRlLWFsdGVybmF0aXZlcyBkb24ndCB3b3JrIHdlbGwgdG9n ZXRoZXIuCisjICBCb3RoIGdlbmVyYXRlIGludGVyZGVwZW5kYW50IHBvc3RpbnN0IGFuZCBwcmVy bSBjb2RlOyBJLmUuIHdoZXJlCisjICBvcmRlciBvZiB0aGUgZ2VuZXJhdGVkIGNvZGUgbWF0dGVy cy4gcHJlcm0gYnJlYWtzIHdoZW4KKyMgIHVwZGF0ZS1yYy5kLmJiY2xhc3MgaXMgaW5oZXJpdGVk IGZpcnN0IGJ5IHRoaXMgcmVjaXBpZSwgYW5kIHBvc3RpbnN0CisjICBicmVha3Mgd2hlbiB1cGRh dGUtYWx0ZXJuYXRpdmVzLmJiY2xhc3MgaXMgaW5oZXJpdGVkIGZpcnN0LiBUaGUKKyMgIGZvcm1l ciBjYW4gYmUgd29ya2VkIGFyb3VuZCBieSBzdG9wcGluZyBzeXNsb2ctbmcgaW4gcHJlcm0gYnkg dGhlCisjICByZWFsIGluaXQuZCBmaWxlbmFtZSBpbiBhZGRpdGlvbiB0byBpdCdzIHVwZGF0ZS1h bHRlcm5hdGl2ZXMgYWxpYXMuCisjICBUaGlzIGlzIGFuIHVnbHkgaGFjaywgYnV0IGl0J3MgZW5v dWdoIHRvIGZpeCBib3RoIGluc3RhbGwgYW5kCisjICB1bmluc3RhbGwgY2FzZXMgZm9yIHN5c2xv Zy1uZyBwYWNrYWdlcyB1bnRpbCB1cGRhdGUtcmMuZCBhbmQKKyMgIHVwZGF0ZS1hbHRlcm5hdGl2 ZXMgY2FuIGJlIGZpeGVkLgordXBkYXRlcmNkX3ByZXJtX2FwcGVuZCgpIHsKK2lmIFsgLXogIiRE IiBdOyB0aGVuCisJJHtJTklUX0RfRElSfS9zeXNsb2cuJHtCUE59IHN0b3AKK2ZpCit9Ci0tIAoy LjguMgoK