<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>10457</bug_id>
          
          <creation_ts>2016-10-19 15:54:56 +0000</creation_ts>
          <short_desc>ppp: 4.8 kernel fix breaks builds with older external toolchains</short_desc>
          <delta_ts>2017-12-04 02:01:27 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>connectivity</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>Future</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Christopher Larson">kergoth</reporter>
          <assigned_to name="Yi Zhao">yi.zhao</assigned_to>
          <cc>jackie.huang</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
    
    <cc>pokylinux</cc>
    
    <cc>randy.macleod</cc>
    
    <cc>yi.zhao</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>67369</commentid>
    <comment_count>0</comment_count>
    <who name="Christopher Larson">kergoth</who>
    <bug_when>2016-10-19 15:54:56 +0000</bug_when>
    <thetext>A patch is applied to fix builds with 4.8 kernels (specifically, 4.8 linux-libc-headers, as it doesn&apos;t use actual kernel headers), but doing so breaks builds with older linux-libc-headers.

This isn&apos;t an issue for internal toolchain builds, as we only keep around a single linux-libc-headers version, but the external toolchain has its own, and I haven&apos;t seen any updated to 4.8 yet, so this effectively breaks ppp builds for all current external toolchains.

It&apos;d be nice if we could find a fix that worked for kernels earlier and later than 4.8 both, so we don&apos;t have to decide whether to revert the patch in meta-sourcery based on the particulars of the external toolchain in use.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>67380</commentid>
    <comment_count>1</comment_count>
    <who name="Christopher Larson">kergoth</who>
    <bug_when>2016-10-19 18:24:33 +0000</bug_when>
    <thetext>Updated the meta-sourcery workaround to grab the kernel version from the external toolchain sysroot and remove the patch based on that, so this is low priority.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68325</commentid>
    <comment_count>2</comment_count>
    <who name="Robert Berger">pokylinux</who>
    <bug_when>2016-11-15 16:28:02 +0000</bug_when>
    <thetext>It does not only break it for external toolchains, but also if you set LINUXLIBCVERSION to something &lt; 4.8 for internal toolchains with morty.

I took your ppp_2.4.7.bbappend, hacked it a bit and added it to my meta layer so it works now with an internal toolchain, but a LINUXLIBCVERSION before 4.4 as well:

KERNEL_48_PATCH = &quot;file://ppp-fix-building-with-linux-4.8.patch&quot;
SRC_URI_remove := &quot;${@&apos;${KERNEL_48_PATCH}&apos; if [int(i) for i in (&apos;${LINUXLIBCVERSION}&apos;.replace(&apos;%&apos;, &apos;&apos;) or &apos;0.0&apos;).split(&apos;.&apos;)] &lt; [4, 8] else &apos;&apos;}&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68326</commentid>
    <comment_count>3</comment_count>
    <who name="Robert Berger">pokylinux</who>
    <bug_when>2016-11-15 16:29:19 +0000</bug_when>
    <thetext>should be but a LINUXLIBCVERSION before 4.8 as well:</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>71157</commentid>
    <comment_count>4</comment_count>
    <who name="dengke">dengke.du</who>
    <bug_when>2017-03-09 02:57:21 +0000</bug_when>
    <thetext>(In reply to comment #2)
&gt; It does not only break it for external toolchains, but also if you set
&gt; LINUXLIBCVERSION to something &lt; 4.8 for internal toolchains with morty.
&gt; 
&gt; I took your ppp_2.4.7.bbappend, hacked it a bit and added it to my meta
&gt; layer so it works now with an internal toolchain, but a LINUXLIBCVERSION
&gt; before 4.4 as well:
&gt; 
&gt; KERNEL_48_PATCH = &quot;file://ppp-fix-building-with-linux-4.8.patch&quot;
&gt; SRC_URI_remove := &quot;${@&apos;${KERNEL_48_PATCH}&apos; if [int(i) for i in
&gt; (&apos;${LINUXLIBCVERSION}&apos;.replace(&apos;%&apos;, &apos;&apos;) or &apos;0.0&apos;).split(&apos;.&apos;)] &lt; [4, 8] else
&gt; &apos;&apos;}&quot;

So we specify the patch to the kernel 4.8 can solve the problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>73213</commentid>
    <comment_count>5</comment_count>
    <who name="Robert Berger">pokylinux</who>
    <bug_when>2017-05-11 18:16:02 +0000</bug_when>
    <thetext>This patch should only be applied when a 4.8 (or maybe newer) kernel is used and certainly makes a problem for 4.4 kernels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>78483</commentid>
    <comment_count>6</comment_count>
    <who name="Yi Zhao">yi.zhao</who>
    <bug_when>2017-12-04 02:01:27 +0000</bug_when>
    <thetext>Fixed in:
morty: http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=morty&amp;id=97d7e4ca751e6010da97e7f082dd13230fe3ef10

master: http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=6ee124905f5241ea2b96822111a08e1463d319d2</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>