<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>10563</bug_id>
          
          <creation_ts>2016-11-01 09:29:51 +0000</creation_ts>
          <short_desc>devtool: traceback when trying to generate a patch</short_desc>
          <delta_ts>2016-12-06 17:28:16 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>devtools / tool chain</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.3 M1</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Igor Stoppa">igor.stoppa</reporter>
          <assigned_to name="Paul Eggleton">bluelightning</assigned_to>
          <cc>jose.perez.carranza</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
          
          <qa_contact name="Francisco Pedraza">francisco.j.pedraza.gonzalez</qa_contact>
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Don&apos;t know</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>67813</commentid>
    <comment_count>0</comment_count>
    <who name="Igor Stoppa">igor.stoppa</who>
    <bug_when>2016-11-01 09:29:51 +0000</bug_when>
    <thetext>Pre-conditions:

I&apos;m working on the recipe initramfs-framework, I want to modify 2 of the files shipped, so that I can produce a patch, to use in a separate layer, through a bbappend.

I&apos;m using the mater from poky.


Steps to trigger the problem:


0) prepare the build directory

1) from the build directory execute:
   devtool modify initramfs-framework

2) modify the files in the copy of the recipe, which is replicated by devtool in:
   /home/igor/dev/poky/build/workspace/sources/initramfs-framework
   vim /home/igor/dev/poky/build/workspace/sources/initramfs-framework/oe-local-files/rootfs
   vim /home/igor/dev/poky/build/workspace/sources/initramfs-framework/oe-local-files/init

3) test the changes

4) try to generate the patch:
   devtool finish initramfs-framework meta 
     or
   devtool finish initramfs-framework meta-ostree


outcome:
  File &quot;/home/igor/dev/poky/scripts/devtool&quot;, line 344, in &lt;module&gt;
    ret = main()
  File &quot;/home/igor/dev/poky/scripts/devtool&quot;, line 331, in main
    ret = args.func(args, config, basepath, workspace)
  File &quot;/home/igor/dev/poky/scripts/lib/devtool/standard.py&quot;, line 1537, in finish
    _update_recipe(args.recipename, workspace, rd, args.mode, appendlayerdir, wildcard_version=True, no_remove=False, initial_rev=args.initial_rev)
  File &quot;/home/igor/dev/poky/scripts/lib/devtool/standard.py&quot;, line 1332, in _update_recipe
    updated = _update_recipe_patch(recipename, workspace, srctree, rd, appendlayerdir, wildcard_version, no_remove, initial_rev)
  File &quot;/home/igor/dev/poky/scripts/lib/devtool/standard.py&quot;, line 1209, in _update_recipe_patch
    upd_f, new_f, del_f = _export_local_files(srctree, rd, local_files_dir)
  File &quot;/home/igor/dev/poky/scripts/lib/devtool/standard.py&quot;, line 1029, in _export_local_files
    git_files = _git_ls_tree(srctree)
  File &quot;/home/igor/dev/poky/scripts/lib/devtool/standard.py&quot;, line 334, in _git_ls_tree
    for line in out.split(&apos;\0&apos;):
TypeError: &apos;str&apos; does not support the buffer interface</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68549</commentid>
    <comment_count>1</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2016-11-23 19:55:11 +0000</bug_when>
    <thetext>Fix merged to master, along with a new oe-selftest test:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=0ffd92707b089ecdd8ec81430cebae85aca4be00
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=e5a391795aa49645d1a6033becb6a6c1f96e6fb9</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>