10619 2016-11-08 09:55:49 +0000 Refactor wic codebase 2017-03-06 11:38:14 +0000 1 1 7 Build System, Metadata & Runtime OE-Core Scripts and Tools unspecified x86 Multiple RESOLVED FIXED LET Medium enhancement 2.3 M3 1 eduard.bartosh eduard.bartosh bluelightning ross.burton --- --- No (bug/feature does not impact docs) oldest_to_newest 68068 0 eduard.bartosh 2016-11-08 09:55:49 +0000 Currently wic code is quite hard to follow due to its complicated class inheritance and data models. It makes sense to refactor it to make it more maintainable and easier to change. Possible areas of refactoring: - get rid of msger logging in favor of logging Python module - flatten directory structure. Directory paths similar to ./scripts/lib/wic/utils/oe/ with only one file misc.py inside it should be simplified. - get rid of two different partition structures in direct and partitionedfs modules - flatten class hierarchy. Currently it has a lot more levels of abstractions than needed for this simple tool - get rid of two underscore-prefixed attributes and methods - clean up the codebase. Currently pylint shows hundreds of warnings for it ... 69193 1 eduard.bartosh 2016-12-16 21:18:03 +0000 one more point from bug 10816: runner/exec code duplicates the other wrapping of subprocess done elsewhere in bitbake and oe-core 69194 2 kergoth 2016-12-16 21:19:09 +0000 This would be nice, trying to trace the flow for that other recent issue took longer than it might have :) It felt a bit more like a c++ or java codebase -- more OOP than is usually seen in pythonic code, which tends to be more pragmatic and multi-paradigm. 70062 3 eduard.bartosh 2017-01-23 22:57:12 +0000 one more area to lock at is configuration management. Code in conf.py and empty configuration file in config/wic.conf are very confusing. I think they should be removed. If we need this functionality we can implement it in much cleaner way. 70330 4 eduard.bartosh 2017-02-01 14:38:55 +0000 First set of changes has been sent for review: http://lists.openembedded.org/pipermail/openembedded-core/2017-February/132117.html 70427 5 eduard.bartosh 2017-02-03 21:27:43 +0000 flatten image class hierarchy: http://lists.openembedded.org/pipermail/openembedded-core/2017-February/132246.html 70620 6 eduard.bartosh 2017-02-10 15:12:07 +0000 Simplified interfaces of DirectPlugin and underlying set of APIs located in partitionedfs module. Removed one of two different structures for partitioning info: http://lists.openembedded.org/pipermail/openembedded-core/2017-February/132430.html 70621 7 eduard.bartosh 2017-02-10 15:30:42 +0000 Moved partition operations to PartitionedImage: http://lists.openembedded.org/pipermail/openembedded-core/2017-February/132558.html 70709 8 eduard.bartosh 2017-02-15 09:04:33 +0000 Removed msger in favor of logging. Improved error handling: http://lists.openembedded.org/pipermail/openembedded-core/2017-February/132782.html 70745 9 eduard.bartosh 2017-02-16 15:58:55 +0000 Refactored plugin system: http://lists.openembedded.org/pipermail/openembedded-core/2017-February/132854.html 70746 10 eduard.bartosh 2017-02-16 16:02:23 +0000 I'm going to resolve this bug when all above mentioned patchset are merged. However, there is still some work left on this area - make use of ArgumentParser: bug #9636 - refactor engine.py and help.py - replace plugin code that configures bootloaders with using configuration files (--configfile .wks option) - refactor source plugins - get rid of custom runner module in favor of using subprocess - move the rest of the code from utils/ subdirectory to lib/wic/utils.py I'm going to address this when I have time and put it here as a reminder and in a hope that other people want to join me with this. 71078 11 eduard.bartosh 2017-03-06 11:38:14 +0000 all patches have been merged to poky master