<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>10650</bug_id>
          
          <creation_ts>2016-11-11 18:08:27 +0000</creation_ts>
          <short_desc>Import non-git layer directory path input validation is incorrect</short_desc>
          <delta_ts>2017-12-06 17:16:21 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>Toaster</product>
          <component>toaster</component>
          <version>2.3</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.4 M4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Wood">michael.g.wood</reporter>
          <assigned_to name="David Reyna">david.reyna</assigned_to>
          <cc>jessica.zhang</cc>
    
    <cc>stanciux.mihail</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>68261</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Wood">michael.g.wood</who>
    <bug_when>2016-11-11 18:08:27 +0000</bug_when>
    <thetext>Steps to reproduce:
 - Try to import a non-git layer by entering a path that contains &quot;.&quot;

Outcome
 - Error message &quot;The directory path cannot include spaces or any of these characters: . \ ? % * : | &quot; &quot; &lt; &gt;&quot;

This is not correct. At the very least you definitely can have a &quot;.&quot; character if not others. You can also use the layer details page to fix this as the validation doesn&apos;t happen there which is inconsistent.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68343</commentid>
    <comment_count>1</comment_count>
    <who name="David Reyna">david.reyna</who>
    <bug_when>2016-11-16 06:13:46 +0000</bug_when>
    <thetext>I a wondering if we need the quote characters in case someone has a space in the path name (which we all dislike but it happens, sometimes from above). In this case we either need the quotes or the backhash as the escape. 

The others I am happy to restrict.

Also, the download path code also has the same restriction around dots in the path. I think that this should be changed for that as well as layer paths.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68345</commentid>
    <comment_count>2</comment_count>
    <who name="David Reyna">david.reyna</who>
    <bug_when>2016-11-16 06:18:42 +0000</bug_when>
    <thetext>Well ok, the Toaster code and documentation says no spaces, so I will stay with that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>76930</commentid>
    <comment_count>3</comment_count>
    <who name="David Reyna">david.reyna</who>
    <bug_when>2017-09-18 17:34:27 +0000</bug_when>
    <thetext>commit ce57a391af3c4b7c9c91a65a82eb604a2665e910
(Bitbake rev: 9c0f6e81dae0b91b425e6c0cdf64caa5c15d92b5)</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>