10669 2016-11-15 22:14:38 +0000 apt package missing systemd files 2017-12-06 17:16:31 +0000 1 1 7 Build System, Metadata & Runtime OE-Core devtools / tool chain unspecified All Multiple RESOLVED FIXED Medium normal 2.3 M2 1 linus.wallgren linus.wallgren anibal.limon meta.mr.watcher meta.watcher ross.burton --- --- No (bug/feature does not impact docs) oldest_to_newest 68336 0 linus.wallgren 2016-11-15 22:14:38 +0000 Upstream apt installs the following files: - /lib/systemd/system/apt-daily.service - /lib/systemd/system/apt-daily.service - /usr/lib/apt/apt.systemd.daily These are used for running daily tasks such as automatically running `apt-get update`, running `unattended-upgrades`, `apt-get clean` and such. These files are not included in the packages built from the yocto apt recipe. Discussing this on IRC Ross Burton raised the question of why the current apt recipe is doing do_install manually and not using the upstream rules. Sadly I don't know enough about the yocto build-system to answer that, however the majority of the do_install is from commit abfc1dbd, which was done 10 years ago. 68398 1 anibal.limon 2016-11-17 14:58:02 +0000 (In reply to comment #0) > Upstream apt installs the following files: > > - /lib/systemd/system/apt-daily.service > - /lib/systemd/system/apt-daily.service > - /usr/lib/apt/apt.systemd.daily > > These are used for running daily tasks such as automatically running > `apt-get update`, running `unattended-upgrades`, `apt-get clean` and such. > > These files are not included in the packages built from the yocto apt recipe. > > Discussing this on IRC Ross Burton raised the question of why the current > apt recipe is doing do_install manually and not using the upstream rules. > Sadly I don't know enough about the yocto build-system to answer that, > however the majority of the do_install is from commit abfc1dbd, which was > done 10 years ago. This case wasn't covered before so i'll review the install step for package those systemd files. 68399 2 linus.wallgren 2016-11-17 15:06:56 +0000 I submitted this patch: http://lists.openembedded.org/pipermail/openembedded-core/2016-November/128870.html What do you think about that? Also, was this the correct way for me to submit the issue and patch? 68402 3 anibal.limon 2016-11-17 15:39:54 +0000 (In reply to comment #2) > I submitted this patch: > > http://lists.openembedded.org/pipermail/openembedded-core/2016-November/ > 128870.html > > What do you think about that? > > Also, was this the correct way for me to submit the issue and patch? Looks good, only missing one thing you need to conditional those lines to only work when systemd is enabled in DISTRO_FEATURES, see example: http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-support/consolekit/consolekit_0.4.6.bb#n26 68468 4 linus.wallgren 2016-11-21 21:05:05 +0000 (In reply to comment #3) > (In reply to comment #2) > > I submitted this patch: > > > > http://lists.openembedded.org/pipermail/openembedded-core/2016-November/ > > 128870.html > > > > What do you think about that? > > > > Also, was this the correct way for me to submit the issue and patch? > > Looks good, only missing one thing you need to conditional those lines to > only work when systemd is enabled in DISTRO_FEATURES, see example: > > http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-support/ > consolekit/consolekit_0.4.6.bb#n26 As Andreas mentioned[0] as a reply to the patch the systemd bbclass will ensure systemd files only are included if that DISTRO_FEATURE is enabled. I have however fixed indentation to be consistent with the rest of the file [1]. [0]: http://lists.openembedded.org/pipermail/openembedded-core/2016-November/128995.html [1]: http://lists.openembedded.org/pipermail/openembedded-core/2016-November/129031.html 68492 5 anibal.limon 2016-11-22 16:52:15 +0000 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > I submitted this patch: > > > > > > http://lists.openembedded.org/pipermail/openembedded-core/2016-November/ > > > 128870.html > > > > > > What do you think about that? > > > > > > Also, was this the correct way for me to submit the issue and patch? > > > > Looks good, only missing one thing you need to conditional those lines to > > only work when systemd is enabled in DISTRO_FEATURES, see example: > > > > http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-support/ > > consolekit/consolekit_0.4.6.bb#n26 > > As Andreas mentioned[0] as a reply to the patch the systemd bbclass will > ensure systemd files only are included if that DISTRO_FEATURE is enabled. > > I have however fixed indentation to be consistent with the rest of the file > [1]. > > [0]: > http://lists.openembedded.org/pipermail/openembedded-core/2016-November/ > 128995.html > [1]: > http://lists.openembedded.org/pipermail/openembedded-core/2016-November/ > 129031.html Fair enough, thanks for your patch. Cheers, alimon 70489 6 linus.wallgren 2017-02-07 15:34:31 +0000 cde67af8ce9b8e72b5818233a7ef4c2aa181404a seems to have solved this issue.