<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>107</bug_id>
          
          <creation_ts>2010-07-14 18:18:22 +0000</creation_ts>
          <short_desc>TCF RSE plug-in not handle the situation if the remote agent does NOT support terminal service</short_desc>
          <delta_ts>2019-08-29 15:17:19 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>Eclipse Plugin</product>
          <component>eclipse-plugin</component>
          <version>1.0</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>OBSOLETE</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>1.3 M3</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Lianhao Lu">lianhao.lu</reporter>
          <assigned_to name="Lianhao Lu">lianhao.lu</assigned_to>
          <cc>jessica.zhang</cc>
    
    <cc>ke.yu</cc>
    
    <cc>kevin.tian</cc>
    
    <cc>laurentiu.serban</cc>
    
    <cc>lianhao.lu</cc>
    
    <cc>liping.ke</cc>
    
    <cc>sgw</cc>
    
    <cc>shane.wang</cc>
    
    <cc>song.liu</cc>
    
    <cc>yp.ep.watcher</cc>
    
    <cc>yp.watcher</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>---</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>8984</commentid>
    <comment_count>0</comment_count>
    <who name="Lianhao Lu">lianhao.lu</who>
    <bug_when>2010-07-14 18:18:22 +0000</bug_when>
    <thetext>Currently, the TCF RSE plugin doesn&apos;t handle the situation if the remote agent does NOT support the terminal service, in which case when the user clicks &quot;launch terminal&quot;, a new terminal tab is created but nothing happens then.

An exception is thrown in this case, but it seems not being handled.

org.eclipse.rse.services.clientserver.messages.SystemMessageException: Remote peer does not support org.eclipse.tm.internal.tcf.terminals.ITerminalsService service
	at org.eclipse.tm.internal.tcf.rse.TCFRSETask.getS(TCFRSETask.java:48)
	at org.eclipse.tm.internal.tcf.rse.shells.TCFTerminalShell.&lt;init&gt;(TCFTerminalShell.java:215)
	at org.eclipse.tm.internal.tcf.rse.terminals.TCFTerminalService.launchTerminal(TCFTerminalService.java:35)
	at org.eclipse.rse.internal.terminals.ui.views.RSETerminalConnectionThread.run(RSETerminalConnectionThread.java:55)
TCF shell Service: Connect failed
Exception in thread &quot;Thread-13&quot; java.lang.NullPointerException
	at org.eclipse.rse.internal.terminals.ui.views.RSETerminalConnectionThread.readDataForever(RSETerminalConnectionThread.java:99)
	at org.eclipse.rse.internal.terminals.ui.views.RSETerminalConnectionThread.run(RSETerminalConnectionThread.java:70)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>9166</commentid>
    <comment_count>1</comment_count>
    <who name="Yongkang You">yongkang.you</who>
    <bug_when>2010-07-29 18:34:30 +0000</bug_when>
    <thetext>Changed to SDK Plugin/Eclipse component</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>9521</commentid>
    <comment_count>2</comment_count>
    <who name="liping Ke">liping.ke</who>
    <bug_when>2010-09-01 19:06:10 +0000</bug_when>
    <thetext>After investigation, I found in RSETerminalConnectThread.java (RSE code, not our part), it did catch the SystemMessageException we throw, but it only &quot;log&quot; the error and go on other jobs. Seems rollback operation is not considered at all in its implementation.

Since it&apos;s not our code part, this job can be delayed during our communicating with TCF/RSE community. 

I leave the bug as open and mark it as &quot;enhancement&quot;, put it off till &quot;M4&quot;. This bug should be kept tracking by us.


Thanks&amp; Regards,
criping</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>9689</commentid>
    <comment_count>3</comment_count>
    <who name="Jessica">jessica.zhang</who>
    <bug_when>2010-09-08 22:24:56 +0000</bug_when>
    <thetext>File an upstream bug</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>9783</commentid>
    <comment_count>4</comment_count>
    <who name="liping Ke">liping.ke</who>
    <bug_when>2010-09-13 20:46:02 +0000</bug_when>
    <thetext>Please refer to the bug in upstream bugzilla:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=325188</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>13139</commentid>
    <comment_count>5</comment_count>
    <who name="liping Ke">liping.ke</who>
    <bug_when>2011-04-05 22:23:52 +0000</bug_when>
    <thetext>Nobody cares about this bug. We will look@the bug in 1.1 when upgrading RSE versions. If the bug still exists, send a patch to the RSE directly to see whether they would accept the patch.

Thanks&amp; Regards,
criping</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22479</commentid>
    <comment_count>6</comment_count>
    <who name="Jessica">jessica.zhang</who>
    <bug_when>2012-06-21 18:49:24 +0000</bug_when>
    <thetext>Is this still a valid bug since our extension to agent is upstreamed which means the agent should support the teminal service by default, right?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22532</commentid>
    <comment_count>7</comment_count>
    <who name="Lianhao Lu">lianhao.lu</who>
    <bug_when>2012-06-25 08:59:46 +0000</bug_when>
    <thetext>(In reply to comment #6)
&gt; Is this still a valid bug since our extension to agent is upstreamed which
&gt; means the agent should support the teminal service by default, right?

Yes. The terminal service is supported by default now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22968</commentid>
    <comment_count>8</comment_count>
    <who name="Jessica">jessica.zhang</who>
    <bug_when>2012-07-10 17:47:57 +0000</bug_when>
    <thetext>Lianhao,

So can you close the bug since terminal service is by default supported by the agent?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>22978</commentid>
    <comment_count>9</comment_count>
    <who name="Lianhao Lu">lianhao.lu</who>
    <bug_when>2012-07-11 01:09:35 +0000</bug_when>
    <thetext>obsolete this bug because the terminal service is a default service on upstream tcf-agent.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>24163</commentid>
    <comment_count>10</comment_count>
    <who name="Laurentiu Serban">laurentiu.serban</who>
    <bug_when>2012-08-17 21:47:17 +0000</bug_when>
    <thetext>setting this to verified</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>84806</commentid>
    <comment_count>11</comment_count>
    <who name="Armin Kuster">akuster</who>
    <bug_when>2019-08-29 15:17:19 +0000</bug_when>
    <thetext>closing</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>