<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>10739</bug_id>
          
          <creation_ts>2016-11-28 20:02:12 +0000</creation_ts>
          <short_desc>patchwork: pw should not create new revisions from comments/replies containing patch-like content</short_desc>
          <delta_ts>2017-12-06 17:18:54 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>Patchwork/Patchtest</product>
          <component>Patchwork</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.3 M3</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jose Lamego">jose.a.lamego</reporter>
          <assigned_to name="Jose Lamego">jose.a.lamego</assigned_to>
          <cc>bluelightning</cc>
    
    <cc>leonardo.sandoval.gonzalez</cc>
    
    <cc>patrick.ohly</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>68647</commentid>
    <comment_count>0</comment_count>
    <who name="Jose Lamego">jose.a.lamego</who>
    <bug_when>2016-11-28 20:02:12 +0000</bug_when>
    <thetext>Pathchwork should identify message-replies that contain patch-like content and not create new series revisions from them.

An example of such is revision 2 at:
https://patchwork.openembedded.org/series/3843/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68650</commentid>
    <comment_count>1</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2016-11-28 20:33:12 +0000</bug_when>
    <thetext>How will you tell the difference between a genuine patch sent in reply to an earlier version (or even in reply to a discussion) and a reply with erroneous patch content?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68651</commentid>
    <comment_count>2</comment_count>
    <who name="Jose Lamego">jose.a.lamego</who>
    <bug_when>2016-11-28 20:39:46 +0000</bug_when>
    <thetext>(In reply to comment #1)
&gt; How will you tell the difference between a genuine patch sent in reply to an
&gt; earlier version (or even in reply to a discussion) and a reply with
&gt; erroneous patch content?

Exactly what I was wondering before filing this bug. I guess only after some investigation/testing I&apos;ll be able to answer.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68931</commentid>
    <comment_count>3</comment_count>
    <who name="Jose Lamego">jose.a.lamego</who>
    <bug_when>2016-12-08 14:46:35 +0000</bug_when>
    <thetext>Another example: https://patchwork.openembedded.org/series/4235/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>69493</commentid>
    <comment_count>4</comment_count>
    <who name="Jose Lamego">jose.a.lamego</who>
    <bug_when>2017-01-04 19:42:05 +0000</bug_when>
    <thetext>An example of a revision created from a reply (a ping, in this case) is at:
https://patchwork.openembedded.org/series/4578/

and a revision created from reply:
https://patchwork.openembedded.org/series/4506/#rev2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70625</commentid>
    <comment_count>5</comment_count>
    <who name="Jose Lamego">jose.a.lamego</who>
    <bug_when>2017-02-10 17:32:15 +0000</bug_when>
    <thetext>&quot;[PATCH&quot; prefix is now mandatory for any email message to be considered as a possible new patch, and any message starting with any character other than square bracket will be considered only as a possible comment (for example, messages starting with &quot;Re:&quot; or &quot;Fwd:&quot;). This guideline will avoid the reported issue.

This change is implemented in:
http://git.yoctoproject.org/cgit/cgit.cgi/patchwork/commit/?id=1a096ecdec71ad20e47af075e0126f77c54e7ec9</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>