<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>10799</bug_id>
          
          <creation_ts>2016-12-13 08:32:54 +0000</creation_ts>
          <short_desc>compatibility with rm_work.bbclass</short_desc>
          <delta_ts>2017-02-24 22:17:08 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>Other YP Layers</product>
          <component>meta-swupd</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.3</target_milestone>
          <dependson>10584</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Patrick Ohly">patrick.ohly</reporter>
          <assigned_to name="Aaron Zinghini">aaron.zinghini</assigned_to>
          <cc>aaron.zinghini</cc>
    
    <cc>sgw</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>69074</commentid>
    <comment_count>0</comment_count>
    <who name="Patrick Ohly">patrick.ohly</who>
    <bug_when>2016-12-13 08:32:54 +0000</bug_when>
    <thetext>Build breaks with meta-swupd fail when rm_work.bbclass is used because meta-swupd accesses content from other recipes which might have been removed already by do_rm_work.

I have patches ready, but they depend on enhancing do_rm_work. I intend to submit together with bug #10584.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70634</commentid>
    <comment_count>1</comment_count>
      <attachid>3631</attachid>
    <who name="Aaron Zinghini">aaron.zinghini</who>
    <bug_when>2017-02-10 19:39:47 +0000</bug_when>
    <thetext>Created attachment 3631
swupd-image.bbclass stacktrace</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70635</commentid>
    <comment_count>2</comment_count>
    <who name="Aaron Zinghini">aaron.zinghini</who>
    <bug_when>2017-02-10 19:41:22 +0000</bug_when>
    <thetext>This change appears to break things for me. I believe the problem is a missing expand arg in the &quot;workdir = d.getVar(&apos;WORKDIR&apos;)&quot; statement.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70636</commentid>
    <comment_count>3</comment_count>
    <who name="Aaron Zinghini">aaron.zinghini</who>
    <bug_when>2017-02-10 19:47:08 +0000</bug_when>
    <thetext>Actually this appears to be because I am not using the master branch of poky and that the default for getVars has changed. This leads me to the question of whether there will be a stable Morty branch of meta-swupd anytime soon?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70652</commentid>
    <comment_count>4</comment_count>
    <who name="Patrick Ohly">patrick.ohly</who>
    <bug_when>2017-02-13 08:48:15 +0000</bug_when>
    <thetext>(In reply to comment #3)
&gt; Actually this appears to be because I am not using the master branch of poky
&gt; and that the default for getVars has changed. This leads me to the question
&gt; of whether there will be a stable Morty branch of meta-swupd anytime soon?

I&apos;ve taken over maintenance of the layer for now, but it is unclear whether that will continue, and targeting older releases wasn&apos;t part of that (tentative) plan either.

I see two possible outcomes:
1. We have some interest in using swupd and resources to support it. Then proper testing needs to be set up, including older releases, and Morty will be supported.
2. There&apos;s not enough interest to justify the work. Then some of those still interested will need to step up and take over maintenance.

Regarding this particular problem, is it enough to add &quot;True&quot; to the d.getVar() call? If that works for you, can you submit a patch? That can go into the master branch and then we can avoid forking for a while longer.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70666</commentid>
    <comment_count>5</comment_count>
    <who name="Aaron Zinghini">aaron.zinghini</who>
    <bug_when>2017-02-13 17:13:26 +0000</bug_when>
    <thetext>Sad to hear there isn&apos;t much interest in this layer. The commercial project I work on is looking at using this so it would seem I will be helping to keep this alive.

I think adding the explicit &quot;True&quot; would suffice for now. I&apos;m pretty new to contributing to open-source projects and git. Do you have any info/guidelines I can use to get setup so I can submit patches?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70668</commentid>
    <comment_count>6</comment_count>
    <who name="Patrick Ohly">patrick.ohly</who>
    <bug_when>2017-02-13 17:33:12 +0000</bug_when>
    <thetext>(In reply to comment #5)
&gt; Sad to hear there isn&apos;t much interest in this layer. 

There is interest, it&apos;s just unclear whether there&apos;s an intersection between those willing to use it and those willing to maintain it ;-/

&gt; The commercial project
&gt; I work on is looking at using this so it would seem I will be helping to
&gt; keep this alive.

Out of curiosity, which features of swupd made you choose it over the competing solutions? See also 
https://wiki.yoctoproject.org/wiki/System_Update

&gt; I think adding the explicit &quot;True&quot; would suffice for now. I&apos;m pretty new to
&gt; contributing to open-source projects and git. Do you have any
&gt; info/guidelines I can use to get setup so I can submit patches?

&quot;git clone git://git.yoctoproject.org/meta-swupd&quot;, then make the change, test it, commit it with a commit message according to http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines, subscribe to openembedded-devel@lists.openembedded.org  (see http://www.openembedded.org/wiki/Mailing_lists) then send with &quot;git send-email --to=openembedded-devel@lists.openembedded.org &apos;--subject-prefix=meta-swupd][PATCH&apos; HEAD~..HEAD&quot;.

Then it ends up getting reviewed and merged.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70669</commentid>
    <comment_count>7</comment_count>
    <who name="Aaron Zinghini">aaron.zinghini</who>
    <bug_when>2017-02-13 17:47:01 +0000</bug_when>
    <thetext>The main reason for preferring swupd is for the fast minimal updates and moving away from our current approach which requires full system imaging to get OS updates. A lot of the competing projects also require U-boot, which is not an option for our HW.

I will follow the guidelines you mentioned and submit the patch today.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70670</commentid>
    <comment_count>8</comment_count>
    <who name="Patrick Ohly">patrick.ohly</who>
    <bug_when>2017-02-13 18:56:03 +0000</bug_when>
    <thetext>(In reply to comment #7)
&gt; The main reason for preferring swupd is for the fast minimal updates and
&gt; moving away from our current approach which requires full system imaging to
&gt; get OS updates.

Agreed, file-based approaches have an advantage there. Do you do live updates (including swapping out files which may be currently in use), followed by an obligatory reboot, or do you selectively restart daemons that use old files?

&gt; A lot of the competing projects also require U-boot, which
&gt; is not an option for our HW.

Is your hardware booting with UEFI?

&gt; I will follow the guidelines you mentioned and submit the patch today.

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70672</commentid>
    <comment_count>9</comment_count>
    <who name="Aaron Zinghini">aaron.zinghini</who>
    <bug_when>2017-02-13 21:35:34 +0000</bug_when>
    <thetext>The way we would use swupd would be to check for updates on boot, apply, then reboot. Yes HW is booting with UEFI.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70939</commentid>
    <comment_count>10</comment_count>
    <who name="Aaron Zinghini">aaron.zinghini</who>
    <bug_when>2017-02-24 21:45:52 +0000</bug_when>
    <thetext>Patch has been upstreamed.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>3631</attachid>
            <date>2017-02-10 19:39:47 +0000</date>
            <delta_ts>2017-02-10 19:39:47 +0000</delta_ts>
            <desc>swupd-image.bbclass stacktrace</desc>
            <filename>swupdlog.txt</filename>
            <type>text/plain</type>
            <size>898</size>
            <attacher name="Aaron Zinghini">aaron.zinghini</attacher>
            
              <data encoding="base64">RmlsZTogJy92YXIvbGliL2plbmtpbnMvd29ya3NwYWNlL3lvY3RvL21ldGEtc3d1cGQvY2xhc3Nl
cy9zd3VwZC1pbWFnZS5iYmNsYXNzJywgbGluZW5vOiAxNTgsIGZ1bmN0aW9uOiBfX2Fub25fMjQ3
X192YXJfbGliX2plbmtpbnNfd29ya3NwYWNlX09yaW9uX3lvY3RvX21ldGFfc3d1cGRfY2xhc3Nl
c19zd3VwZF9pbWFnZV9iYmNsYXNzCiAgICAgMDE1NDogICAgICAgIG1lZ2Ffcm9vdGZzID0gbWVn
YV9yb290ZnMucmVwbGFjZSgnLycgKyBwbiArJy8nLCAnL2J1bmRsZS0lcy1tZWdhLycgJSAocG5f
YmFzZSBvciBwbikpCiAgICAgMDE1NTogICAgICAgIGQuc2V0VmFyKCdNRUdBX0lNQUdFX1JPT1RG
UycsIG1lZ2Ffcm9vdGZzKQogICAgIDAxNTY6ICAgICAgICBtZWdhX2FyY2hpdmUgPSBtZWdhX3Jv
b3RmcyArICcudGFyJwogICAgIDAxNTc6ICAgICAgICB3b3JrZGlyID0gZC5nZXRWYXIoJ1dPUktE
SVInKQogKioqIDAxNTg6ICAgICAgICBkLnNldFZhcignTUVHQV9JTUFHRV9BUkNISVZFJywgbWVn
YV9hcmNoaXZlKQogICAgIDAxNTk6ICAgICAgICBtZWdhX2FyY2hpdmVfcmVsID0gb3MucGF0aC5y
ZWxwYXRoKG1lZ2FfYXJjaGl2ZSwgd29ya2RpcikKICAgICAwMTYwOiAgICAgICAgaWYgb3MucGF0
aC5zZXAgbm90IGluIG1lZ2FfYXJjaGl2ZV9yZWw6CiAgICAgMDE2MTogICAgICAgICAgICMgVGhl
IG1lZ2EgYXJjaGl2ZSBpcyBpbiBvdXIgd29yayBkaXJlY3RvcnkgYW5kIG11c3QgYmUKICAgICAw
MTYyOiAgICAgICAgICAgIyBwcmVzZXJ2ZWQgZm9yIG90aGVyIHZpcnR1YWwgaW1hZ2VzIGV2ZW4g
d2hlbiBybV93b3JrLmJiY2xhc3MKRXhjZXB0aW9uOiBUeXBlRXJyb3I6IGdldFZhcigpIG1pc3Np
bmcgMSByZXF1aXJlZCBwb3NpdGlvbmFsIGFyZ3VtZW50OiAnZXhwYW5kJw==
</data>

          </attachment>
      

    </bug>

</bugzilla>