<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>10807</bug_id>
          
          <creation_ts>2016-12-13 21:42:28 +0000</creation_ts>
          <short_desc>Extensible SDK: sdk-update deletes some meta-data</short_desc>
          <delta_ts>2017-12-06 17:21:06 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>eSDK</product>
          <component>eSDK</component>
          <version>2.2</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard>Backport to 2.3.1</status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.4 M4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Henry Bruce">henry.bruce</reporter>
          <assigned_to name="Paul Eggleton">bluelightning</assigned_to>
          <cc>gizero</cc>
    
    <cc>sgw</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Don&apos;t know</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>69107</commentid>
    <comment_count>0</comment_count>
    <who name="Henry Bruce">henry.bruce</who>
    <bug_when>2016-12-13 21:42:28 +0000</bug_when>
    <thetext>I built an eSDK for node.js development with SDK_EXT_TYPE = &quot;minimal and SDK_UPDATE_URL set. Target is qemux86. 

After publishing an updated eSDK and then running &quot;devtool sdk-update&quot;, some meta-data was deleted. In this case the missing files were in 
layers/meta-oe/recipes-devtools/android-tools/android-tools

Before running sdk update:
$ ls layers/meta-oe/recipes-devtools/android-tools/android-tools
adbd.mk
adb.mk
android-tools-adbd.service
define-shell-command.patch
ext4_utils.mk
fastboot.mk
implicit-declaration-function-strlcat-strlcopy.patch
mkbootimg-Add-dt-parameter-to-specify-DT-image.patch
mkbootimg.mk
preserve-ownership.patch
remove-bionic-android.patch
remove-selinux-android.patch
use-capability.patch
use-local-socket.patch

After running sdk update:
$ ls layers/meta-oe/recipes-devtools/android-tools/android-tools
adbd.mk  adb.mk  ext4_utils.mk  fastboot.mk  mkbootimg.mk

Subsequent devtool operations generate warnings due to missing files, even though android-tools is not built. There are multiple warnings like the one below, one for each missing file.

WARNING: /home/hbruce/Tools/yocto/npm-2.2/layers/meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb: Unable to get checksum for android-tools-native SRC_URI entry remove-selinux-android.patch: file could not be found

Note that even if sdk-update fails due to bug 10798 the files are still deleted.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>77092</commentid>
    <comment_count>1</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2017-09-25 00:24:27 +0000</bug_when>
    <thetext>I tried to reproduce this a few days ago without success. I&apos;ll give it another try but if anyone else is still seeing this, please let me know.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>77226</commentid>
    <comment_count>2</comment_count>
    <who name="Andrea Galbusera">gizero</who>
    <bug_when>2017-09-29 10:15:12 +0000</bug_when>
    <thetext>At the time this bug was filed, there was an issue with the .gitignore file shipped within the android-tools metadata [1]. IIRC, from my observations the reported warnings for missing files were evident since the first run of &apos;devtool sdk-update&apos;. To me they were a consequence of oe-publish-sdk script honoring the .gitignore file while publishing updated metadata.

That said, there is now a patch in meta-openembedded [2] that filtered out useful files (namely patches and systemd service files) from android-tools .gitignore. BTW the real need for .gitignore inside the metadata, which is really uncommon within public layers, is still not 100% clear to me.

[1] http://git.openembedded.org/meta-openembedded/tree/meta-oe/recipes-devtools/android-tools/android-tools/.gitignore
[2] http://git.openembedded.org/meta-openembedded/commit/meta-oe/recipes-devtools/android-tools/android-tools/.gitignore?id=e406d4f5ae8c3ad735611c2f1a4a8df1c9e1db6d

Unless any consideration arise on the eSDK scripts/logic side, IMO this should be closed as fixed in meta-openembedded.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>77254</commentid>
    <comment_count>3</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2017-10-01 19:44:23 +0000</bug_when>
    <thetext>Wow, that is bizarre - no wonder we were seeing problems there! I too would question why on earth we would need a .gitignore in the metadata. Thanks for pointing that out, I will indeed close this now.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>