10810 2016-12-14 18:12:29 +0000 sanity checks also need to run for multiconfigs 2017-03-14 21:29:37 +0000 1 1 7 Build System, Metadata & Runtime OE-Core core 2.3 x86 Multiple VERIFIED FIXED Medium+ enhancement 2.3 M3 1 patrick.ohly juro.bystricky jose.perez.carranza meta.mr.watcher meta.watcher sgw jose.perez.carranza --- --- No (bug/feature does not impact docs) oldest_to_newest 69133 0 patrick.ohly 2016-12-14 18:12:29 +0000 Steps to reproduce: - create conf/local.conf with BBMULTICONFIG = "foo" - create conf/multiconfig/foo.conf with MACHINE="foo" - bitbake world Result: ERROR: ...: Unable to determine endianness for architecture 'INVALID' The error comes from siteconfig.bbclass because HOST_ARCH is not set. Expected: The same sanity check error that one gets when using an invalid MACHINE in local.conf, i.e. something like: ERROR: OE-core's config sanity checker detected a potential misconfiguration. Either fix the cause of this error or at your own risk disable the checker (see sanity.conf). Following is the list of potential problems / advisories: Please set a valid MACHINE in your local.conf or environment The error message should mention the multiconfig file in addition to local.conf. 69734 1 juro.bystricky 2017-01-12 00:23:47 +0000 Currently testing running sanity check for all multiconfig builds (including the "default" build): diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py index 182d044..f6bad36 100644 --- a/bitbake/lib/bb/cooker.py +++ b/bitbake/lib/bb/cooker.py @@ -1610,7 +1610,9 @@ class BBCooker: if self.state != state.parsing and not self.parsecache_valid: self.parseConfiguration () if CookerFeatures.SEND_SANITYEVENTS in self.featureset: - bb.event.fire(bb.event.SanityCheck(False), self.data) + + for mc in self.multiconfigs: + bb.event.fire(bb.event.SanityCheck(False), self.databuilder.mcdata[mc]) for mc in self.multiconfigs: ignore = self.databuilder.mcdata[mc].getVar("ASSUME_PROVIDED") or "" As for "The error message should mention the multiconfig file in addition to local.conf", WIP 69736 2 3593 juro.bystricky 2017-01-12 00:46:56 +0000 Created attachment 3593 patch file to implement the fix for this bug 69737 3 juro.bystricky 2017-01-12 00:49:46 +0000 I attached the patch file that should fix this issue. I will test it a bit more a then send each patch to the corresponding mailing list: cooker.py -> bitbake, sanity.bbclass->oe-core 70873 4 juro.bystricky 2017-02-21 21:04:48 +0000 Patch merged with master: http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=e98757e267389267d96778a1b443293eae12799e 71289 5 jose.perez.carranza 2017-03-14 21:29:37 +0000 Verified on commit: 6e20b31d5d17133e0fca086e12a0ad06ab5c4cc8 is working correctly ERROR: OE-core's config sanity checker detected a potential misconfiguration. Either fix the cause of this error or at your own risk disable the checker (see sanity.conf). Following is the list of potential problems / advisories: MACHINE=foo is invalid. Please set a valid MACHINE in your local.conf, environment or other configuration file. 3593 2017-01-12 00:46:56 +0000 2017-01-12 00:46:56 +0000 patch file to implement the fix for this bug 10810.diff text/plain 1440 juro.bystricky ZGlmZiAtLWdpdCBhL2JpdGJha2UvbGliL2JiL2Nvb2tlci5weSBiL2JpdGJha2UvbGliL2JiL2Nv b2tlci5weQppbmRleCAxODJkMDQ0Li5mNmJhZDM2IDEwMDY0NAotLS0gYS9iaXRiYWtlL2xpYi9i Yi9jb29rZXIucHkKKysrIGIvYml0YmFrZS9saWIvYmIvY29va2VyLnB5CkBAIC0xNjEwLDcgKzE2 MTAsOSBAQCBjbGFzcyBCQkNvb2tlcjoKICAgICAgICAgaWYgc2VsZi5zdGF0ZSAhPSBzdGF0ZS5w YXJzaW5nIGFuZCBub3Qgc2VsZi5wYXJzZWNhY2hlX3ZhbGlkOgogICAgICAgICAgICAgc2VsZi5w YXJzZUNvbmZpZ3VyYXRpb24gKCkKICAgICAgICAgICAgIGlmIENvb2tlckZlYXR1cmVzLlNFTkRf U0FOSVRZRVZFTlRTIGluIHNlbGYuZmVhdHVyZXNldDoKLSAgICAgICAgICAgICAgICBiYi5ldmVu dC5maXJlKGJiLmV2ZW50LlNhbml0eUNoZWNrKEZhbHNlKSwgc2VsZi5kYXRhKQorCisgICAgICAg ICAgICAgICAgZm9yIG1jIGluIHNlbGYubXVsdGljb25maWdzOgorICAgICAgICAgICAgICAgICAg ICBiYi5ldmVudC5maXJlKGJiLmV2ZW50LlNhbml0eUNoZWNrKEZhbHNlKSwgc2VsZi5kYXRhYnVp bGRlci5tY2RhdGFbbWNdKQogCiAgICAgICAgICAgICBmb3IgbWMgaW4gc2VsZi5tdWx0aWNvbmZp Z3M6CiAgICAgICAgICAgICAgICAgaWdub3JlID0gc2VsZi5kYXRhYnVpbGRlci5tY2RhdGFbbWNd LmdldFZhcigiQVNTVU1FX1BST1ZJREVEIikgb3IgIiIKZGlmZiAtLWdpdCBhL21ldGEvY2xhc3Nl cy9zYW5pdHkuYmJjbGFzcyBiL21ldGEvY2xhc3Nlcy9zYW5pdHkuYmJjbGFzcwppbmRleCBjODc2 ZGM2Li44NDc3ZDM4IDEwMDY0NAotLS0gYS9tZXRhL2NsYXNzZXMvc2FuaXR5LmJiY2xhc3MKKysr IGIvbWV0YS9jbGFzc2VzL3Nhbml0eS5iYmNsYXNzCkBAIC04MjMsNyArODIzLDcgQEAgZGVmIGNo ZWNrX3Nhbml0eV9ldmVyeWJ1aWxkKHN0YXR1cywgZCk6CiAgICAgbWFjaGluZXZhbGlkID0gVHJ1 ZQogICAgIGlmIGQuZ2V0VmFyKCdNQUNISU5FJyk6CiAgICAgICAgIGlmIG5vdCBjaGVja19jb25m X2V4aXN0cygiY29uZi9tYWNoaW5lLyR7TUFDSElORX0uY29uZiIsIGQpOgotICAgICAgICAgICAg c3RhdHVzLmFkZHJlc3VsdCgnUGxlYXNlIHNldCBhIHZhbGlkIE1BQ0hJTkUgaW4geW91ciBsb2Nh bC5jb25mIG9yIGVudmlyb25tZW50XG4nKQorICAgICAgICAgICAgc3RhdHVzLmFkZHJlc3VsdCgn SW52YWxpZCBNQUNISU5FPSVzLiBQbGVhc2Ugc2V0IGEgdmFsaWQgTUFDSElORSBpbiB5b3VyIGxv Y2FsLmNvbmYsIGNvbmYvbXVsdGljb25maWcvKi5jb25mIG9yIGVudmlyb25tZW50XG4nICUgKGQu Z2V0VmFyKCdNQUNISU5FJykpKQogICAgICAgICAgICAgbWFjaGluZXZhbGlkID0gRmFsc2UKICAg ICAgICAgZWxzZToKICAgICAgICAgICAgIHN0YXR1cy5hZGRyZXN1bHQoY2hlY2tfc2FuaXR5X3Zh bGlkbWFjaGluZShkKSkK