10816 2016-12-15 16:54:09 +0000 wic: errors from exec_cmd don't show the error output 2017-01-18 16:09:14 +0000 1 1 7 Build System, Metadata & Runtime OE-Core Scripts and Tools unspecified x86 Multiple RESOLVED FIXED Medium normal 2.3 M2 10815 1 kergoth eduard.bartosh richard.purdie ross.burton --- --- No (bug/feature does not impact docs) oldest_to_newest 69166 0 kergoth 2016-12-15 16:54:09 +0000 See this logic: if out: msger.debug('"%s" output: %s' % (args[0], out)) if ret != 0: S> msger.error("exec_cmd: '%s' returned '%s' instead of 0" % \ (cmd_and_args, ret)) So it fails to show stdout/stderr to the user on failure unless the user passed -D to wic. This is not useful. Also, all of this runner/exec code duplicates the other wrapping of subprocess done elsewhere in bitbake and oe-core. 69192 1 eduard.bartosh 2016-12-16 21:16:30 +0000 Regarding code duplicates: Thanks for pointing out to it. I'm going to address it in refactoring bug 10619. 69201 2 3564 eduard.bartosh 2016-12-18 11:39:06 +0000 Created attachment 3564 v1 I fixed the issue, but it unveiled another bug, brought by your latest change. I'll provide more details in the bug 10815. 69665 3 eduard.bartosh 2017-01-10 18:19:40 +0000 patch has been sent for review: http://lists.openembedded.org/pipermail/openembedded-core/2017-January/130949.html 69888 4 eduard.bartosh 2017-01-18 16:09:14 +0000 The fix has been accepted to poky master 3564 2016-12-18 11:39:06 +0000 2016-12-18 11:39:06 +0000 v1 file_10816.txt text/plain 1356 eduard.bartosh LS0tIGEvc2NyaXB0cy9saWIvd2ljL3V0aWxzL29lL21pc2MucHkNCisrKyBiL3NjcmlwdHMvbGli L3dpYy91dGlscy9vZS9taXNjLnB5DQpAQCAtNjUsNiArNjUsMTAgQEAgZGVmIF9leGVjX2NtZChj bWRfYW5kX2FyZ3MsIGFzX3NoZWxsPUZhbHNlLCBjYXRjaD0zKToNCiAgICAgZWxzZToNCiAgICAg ICAgIHJldCwgb3V0ID0gcnVubmVyLnJ1bnRvb2woYXJncywgY2F0Y2gpDQogICAgIG91dCA9IG91 dC5zdHJpcCgpDQorICAgIGlmIHJldCAhPSAwOg0KKyAgICAgICAgbXNnZXIuZXJyb3IoIl9leGVj X2NtZDogJXMgcmV0dXJuZWQgJyVzJyBpbnN0ZWFkIG9mIDBcbm91dHB1dDogJXMiICUgXA0KKyAg ICAgICAgICAgICAgICAgICAgKGNtZF9hbmRfYXJncywgcmV0LCBvdXQpKQ0KKw0KICAgICBtc2dl ci5kZWJ1ZygiX2V4ZWNfY21kOiBvdXRwdXQgZm9yICVzIChyYyA9ICVkKTogJXMiICUgXA0KICAg ICAgICAgICAgICAgICAoY21kX2FuZF9hcmdzLCByZXQsIG91dCkpDQogDQpAQCAtNzksMTAgKzgz LDYgQEAgZGVmIGV4ZWNfY21kKGNtZF9hbmRfYXJncywgYXNfc2hlbGw9RmFsc2UsIGNhdGNoPTMp Og0KICAgICAiIiINCiAgICAgcmV0LCBvdXQgPSBfZXhlY19jbWQoY21kX2FuZF9hcmdzLCBhc19z aGVsbCwgY2F0Y2gpDQogDQotICAgIGlmIHJldCAhPSAwOg0KLSAgICAgICAgbXNnZXIuZXJyb3Io ImV4ZWNfY21kOiAlcyByZXR1cm5lZCAnJXMnIGluc3RlYWQgb2YgMCIgJSBcDQotICAgICAgICAg ICAgICAgICAgICAoY21kX2FuZF9hcmdzLCByZXQpKQ0KLQ0KICAgICByZXR1cm4gb3V0DQogDQog ZGVmIGV4ZWNfbmF0aXZlX2NtZChjbWRfYW5kX2FyZ3MsIG5hdGl2ZV9zeXNyb290LCBjYXRjaD0z LCBwc2V1ZG89IiIpOg0KQEAgLTEyNiwxMiArMTI2LDYgQEAgZGVmIGV4ZWNfbmF0aXZlX2NtZChj bWRfYW5kX2FyZ3MsIG5hdGl2ZV9zeXNyb290LCBjYXRjaD0zLCBwc2V1ZG89IiIpOg0KICAgICAg ICAgICAgIG1zZyArPSAiV2ljIGZhaWxlZCB0byBmaW5kIGEgcmVjaXBlIHRvIGJ1aWxkIG5hdGl2 ZSAlcy4gUGxlYXNlICJcDQogICAgICAgICAgICAgICAgICAgICJmaWxlIGEgYnVnIGFnYWluc3Qg d2ljLlxuIiAlIHByb2cNCiAgICAgICAgIG1zZ2VyLmVycm9yKG1zZykNCi0gICAgaWYgb3V0Og0K LSAgICAgICAgbXNnZXIuZGVidWcoJyIlcyIgb3V0cHV0OiAlcycgJSAoYXJnc1swXSwgb3V0KSkN Ci0NCi0gICAgaWYgcmV0ICE9IDA6DQotICAgICAgICBtc2dlci5lcnJvcigiZXhlY19jbWQ6ICcl cycgcmV0dXJuZWQgJyVzJyBpbnN0ZWFkIG9mIDAiICUgXA0KLSAgICAgICAgICAgICAgICAgICAg KGNtZF9hbmRfYXJncywgcmV0KSkNCiANCiAgICAgcmV0dXJuIHJldCwgb3V0