10878 2017-01-04 22:07:38 +0000 source code lines should not exceed more than 80 characters 2017-12-06 17:22:06 +0000 1 1 6 Yocto Project Subprojects Patchwork/Patchtest Patchtest Testsuite unspecified x86 Multiple RESOLVED FIXED Medium+ enhancement 2.3 M4 1 leonardo.sandoval.gonzalez leonardo.sandoval.gonzalez benjamin.esquivel bluelightning mariano.lopez ross.burton --- --- No (bug/feature does not impact docs) oldest_to_newest 69505 0 leonardo.sandoval.gonzalez 2017-01-04 22:07:38 +0000 perhaps this bug overlap bug 10789 but if not, suite should have its own test case checking for long (source code) lines. Before setting a hardcoded length (80) the current tracked code should be explored and see current max lengths and community guidelines on this area. 69509 1 ross.burton 2017-01-05 11:15:51 +0000 There are a *lot* of recipes that exceed 80 character lines, because this isn't 1970 anymore. :) A limit of something like 160 to check that recipes are not using giant lines is more realistic IMHO. 69518 2 mariano.lopez 2017-01-05 15:20:19 +0000 (In reply to comment #1) > There are a *lot* of recipes that exceed 80 character lines, because this > isn't 1970 anymore. :) Indeed, now we have vsplit in vim :) 69519 3 leonardo.sandoval.gonzalez 2017-01-05 15:22:07 +0000 (In reply to comment #1) > There are a *lot* of recipes that exceed 80 character lines, because this > isn't 1970 anymore. :) > > A limit of something like 160 to check that recipes are not using giant > lines is more realistic IMHO. Correct, that's why I mentioned to do some exploration first. Thanks for providing that limit, that is in fact more realistic. 69528 4 benjamin.esquivel 2017-01-05 16:21:07 +0000 (In reply to comment #1) > There are a *lot* of recipes that exceed 80 character lines, because this > isn't 1970 anymore. :) I guess the coding style guides haven't been updated since. > A limit of something like 160 to check that recipes are not using giant > lines is more realistic IMHO. my full screen terminal can handle 279 chars yet every time I open a new terminal window it comes at 80 chars wide. I think it is better to stick to the standards but recipes could be a 'special' case. 71276 5 leonardo.sandoval.gonzalez 2017-03-14 18:47:24 +0000 Fixed by http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe/commit/?id=cabfb858051a6eaa29d1fa6a6e39e558894f47c7 max length set to 160.