10897 2017-01-09 10:03:14 +0000 license.bbclass attempts chown(root.root) in build host context, hiding errors 2017-03-02 09:16:21 +0000 1 1 7 Build System, Metadata & Runtime OE-Core core 2.2 x86 Multiple RESOLVED FIXED Medium normal 2.3 1 olev.kartau markus.lehtonen markus.lehtonen meta.mr.watcher meta.watcher --- --- Don't know oldest_to_newest 69615 0 olev.kartau 2017-01-09 10:03:14 +0000 In Refkit build it happened that some license files appeared to be root-owned even when builder was running as user. Docker was used as build container method. It turned out some combination of docker and host kernel versions did let chown in docker to change host file to become root-owned. (instead of EPERM). Docker version 1.12.3 on openSUSE worker 42.2 with kernel 4.4.36 did that. After upgrading docker to 1.12.5, chroot failed with EPERM as it should. But this case demonstrated risky code in license.bbclass copy_license_files which does: 1. hardlinking to base file 2. chown(0,0) 3. hide any errors (because same code runs in and out of pseudo) in combination with badly managed capability drop in container system, may result in many files silently turned to root.root ownership in builder host context. Note that because of hardlinking, chown applied to other instances actually tries to change ownership of base license files, which should remain unchanged, as these are usually checked-out repo files. Re-using same code in and out- pseudo, then hiding errors to make things look clean, is lazy and risky solution. Code should avoid elevating permission levels where not really needed. 69617 1 olev.kartau 2017-01-09 11:46:32 +0000 Based on irc discussion, immediate fix is now seen as "chown only if under pseudo" 71029 2 markus.lehtonen 2017-03-02 09:16:21 +0000 Fix merged in http://git.openembedded.org/openembedded-core/commit/?id=19118a1408f32bb24d95ab3d7d7faed58cbae900