110 2010-07-16 04:46:37 +0000 Review GTK+ on VGA 2017-08-08 13:34:08 +0000 1 1 6 Yocto Project Subprojects Sato sato 1.0 x86 Multiple RESOLVED OBSOLETE Low normal Future 1615 1 josh jku bluelightning jessica.zhang josh julie.n.fleischer meta.mr.watcher meta.watcher richard.purdie ross.burton sgw shane.wang song.liu Xiaofeng.yan --- --- No (bug/feature does not impact docs) oldest_to_newest 8993 0 josh 2010-07-16 04:46:37 +0000 We need to merge patches to Gtk+'s file chooser for small screen optimisation 16895 1 josh 2011-10-18 10:22:27 +0000 We should be able to do this more cleanly, and therefore in a more easily maintainable way, by creating our own implementation of the Gtk+ File Chooser interface: http://developer.gnome.org/gtk/2.24/GtkFileChooser.html The hardest part will likely be working through the original patch to determine what changes are being made to the File Chooser. 17113 2 josh 2011-11-04 11:07:03 +0000 The Gtk+ 2.12.7 recipe has some patches which change the filechooser to work better on the target devices. More touch friendly, etc. We want these, or similar, changes ported to modern Gtk+ implementations. We need to first go through the filechooser patches in the gtk+ 2.12.7 directory[1] and figure out what they are actually doing and then create a FileChooser implementation which implements these changes. Finally we need to set this FileChooser implementation as the default. My preliminary research lead me to believe we can achieve all of this primarily through our own implementation of the filechooser interface and with as few patches to core gtk+ files as possible meaning this should be easier to maintain going forwards. 1. http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-gnome/gtk+/gtk+-2.12.7 17430 3 Xiaofeng.yan 2011-11-30 00:42:51 +0000 (In reply to comment #2) > The Gtk+ 2.12.7 recipe has some patches which change the filechooser to work > better on the target devices. More touch friendly, etc. > > We want these, or similar, changes ported to modern Gtk+ implementations. > > We need to first go through the filechooser patches in the gtk+ 2.12.7 > directory[1] and figure out what they are actually doing and then create a > FileChooser implementation which implements these changes. > > Finally we need to set this FileChooser implementation as the default. > > My preliminary research lead me to believe we can achieve all of this primarily > through our own implementation of the filechooser interface and with as few > patches to core gtk+ files as possible meaning this should be easier to > maintain going forwards. > > 1. > http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-gnome/gtk+/gtk+-2.12.7 Hi Joshua Lock, I doesn't have experience to code with gtk before. Do you have much experience on gtk? It is difficult for me to implement these changes in the newest version. It could take much time to implement these function. 17441 4 josh 2011-11-30 16:55:46 +0000 Hi Xiaofeng, I have some experience with Gtk+. I think it will take some time to implement this patch, regardless of experience, as a lot of the work revolves around determining the effects of the existing patch which isn't at all documented and is ~9.5KLOC. http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-gnome/gtk+/gtk+-2.12.7/filechooser-default.patch 17491 5 286 Xiaofeng.yan 2011-12-05 01:16:07 +0000 Created attachment 286 a test program for File Chooser 17492 6 Xiaofeng.yan 2011-12-05 01:16:50 +0000 (In reply to comment #4) > Hi Xiaofeng, > > I have some experience with Gtk+. I think it will take some time to implement > this patch, regardless of experience, as a lot of the work revolves around > determining the effects of the existing patch which isn't at all documented and > is ~9.5KLOC. > > http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-gnome/gtk+/gtk+-2.12.7/filechooser-default.patch Hi Joshua Lock, I want to build two images, one based on gtk+ 2.12.7, the other based on 2.24.8 I will make a comparison for them and get a result. the patch is better than no patch in 2.24.8. It need a test program to compare them. Please check the attachment. this is an example to test File Chooser. perhaps, you can give me better test program. Do you have any suggestion about my method ? or it is not necessary. Thanks Yan 17497 7 josh 2011-12-05 11:42:56 +0000 (In reply to comment #6) Yan, > I want to build two images, one based on gtk+ 2.12.7, the other based on 2.24.8 > > I will make a comparison for them and get a result. This seems like a reasonable step to take, whilst you'll be hard pressed to get specific details of the implementation differences the visual clue should at least help you determine which parts of the FileChooser patch to focus on. > perhaps, you can give me better test program. There are several Gtk+ programs shipped with a Sato image, I'd probably have just used one of those such as the file manager pcmanfm or the text editor leafpad. 17508 8 Xiaofeng.yan 2011-12-07 04:27:29 +0000 Hi Joshua, Do you know why the patches for File Chooser in 2.12 isn't accepted by gtk's official community? 17521 9 josh 2011-12-07 10:08:17 +0000 (In reply to comment #8) > Hi Joshua, > > Do you know why the patches for File Chooser in 2.12 isn't accepted by gtk's > official community? I don't know for certain but I imagine that it's because the patches are form-factor specific and overwrite the default chooser. The new FileChooser interface mentioned in comment 1 is newer than the patch but enables people to providing alternative FileChooser implementations without having to modify the stock Chooser. 17762 10 jessica.zhang 2011-12-20 11:41:06 +0000 per today's bug triage, it's probably a time for RP, Josh or Paul to own the bug 17764 11 josh 2011-12-20 11:43:21 +0000 I think we'd mostly agree that this is a non-trivial amount of work so my first question would be whether we are sure this issue is of value to the project? If so I'm happy to own this bug and see it scheduled and implemented. 17766 12 richard.purdie 2011-12-20 13:14:33 +0000 I think having the core reference UI fit on VGA screens is important. Having all the example customisations to do this present is therefore a good idea. Whilst this task is certainly not trivial, I don't believe it should take that long for someone with the relevant experience/background and it would be worthwhile to do that. 18379 13 richard.purdie 2012-01-26 12:39:54 +0000 *** Bug 1615 has been marked as a duplicate of this bug. *** 38558 14 ross.burton 2013-11-05 16:48:04 +0000 Generalising this to all of GTK+ on VGA screens. The move to GTK+ 3 is likely to improve and hinder this in different ways. 39036 15 richard.purdie 2013-11-22 16:29:21 +0000 Ross: You don't get out the bug quiet that easily ;-) 39037 16 ross.burton 2013-11-22 16:30:00 +0000 Foiled again! 58938 17 ross.burton 2016-02-11 23:27:26 +0000 Jussi can have was is likely the lowest open bug number as he's been busy rewriting Sato. 75720 18 ross.burton 2017-08-08 13:34:08 +0000 VGA isn't relevant in any meaningful way now, even in embedded. Closing wontfix. 286 2011-12-05 01:16:07 +0000 2011-12-05 01:16:07 +0000 a test program for File Chooser gtkfilechooser.c.no application/octet-stream 2579 Xiaofeng.yan I2luY2x1ZGU8Z3RrL2d0ay5oPgoKI2RlZmluZSBfKGEpIGEKCmdib29sZWFuIG9uX3dpbl9kZWxl dGUoR3RrV2lkZ2V0ICp3aWRnZXQsCiAgICAgICAgICAgICAgICAgICAgICBHZGtFdmVudCAgKmV2 ZW50LAogICAgICAgICAgICAgICAgICAgICAgZ3BvaW50ZXIgICB1c2VyX2RhdGEpCnsKCiAgICBn dGtfbWFpbl9xdWl0KCk7CiAgICByZXR1cm4gRkFMU0U7Cn0KCnZvaWQgb25fYnV0dG9uKEd0a0J1 dHRvbiAqYnV0dG9uLEd0a0VudHJ5ICplbnRyeSkKewoKICAgIEd0a1dpZGdldCAqZGlhbG9nOwoK ICAgIGRpYWxvZyA9IGd0a19maWxlX2Nob29zZXJfZGlhbG9nX25ldyAoIm9wZW4iLAogICAgICAg ICAgICAgICAgICAgICAgTlVMTCwvL2d0a193aWRnZXRfZ2V0X3RvcGxldmVsKEdUS19XSURHRVQo YnV0dG9uKSksCiAgICAgICAgICAgICAgICAgICAgICBHVEtfRklMRV9DSE9PU0VSX0FDVElPTl9T QVZFLAogICAgICAgICAgICAgICAgICAgICAgR1RLX1NUT0NLX0NBTkNFTCwgR1RLX1JFU1BPTlNF X0NBTkNFTCwKICAgICAgICAgICAgICAgICAgICAgIEdUS19TVE9DS19PUEVOLCBHVEtfUkVTUE9O U0VfQUNDRVBULAogICAgICAgICAgICAgICAgICAgICAgTlVMTCk7CgogICAgZ3RrX2ZpbGVfZmls dGVyX3NldF9uYW1lIChmaWx0ZXIsIF8oIkFsbCBmaWxlcyIpKTsKICAgIGd0a19maWxlX2ZpbHRl cl9hZGRfcGF0dGVybihmaWx0ZXIsIioiKTsKICAgIGd0a19maWxlX2Nob29zZXJfYWRkX2ZpbHRl ciAoR1RLX0ZJTEVfQ0hPT1NFUiAoZGlhbG9nKSxmaWx0ZXIpOwoKICAgIGZpbHRlciA9IGd0a19m aWxlX2ZpbHRlcl9uZXcoKTsKICAgIGd0a19maWxlX2ZpbHRlcl9zZXRfbmFtZSAoZmlsdGVyLCBf KCJUeHQgdGV4dCBmaWxlcyIpKTsKICAgIGd0a19maWxlX2ZpbHRlcl9hZGRfcGF0dGVybihmaWx0 ZXIsIiouW1R0XVtYeF1bVHRdIik7CiAgICBndGtfZmlsZV9jaG9vc2VyX2FkZF9maWx0ZXIgKEdU S19GSUxFX0NIT09TRVIgKGRpYWxvZyksZmlsdGVyKTsKCiAgICBmaWx0ZXIgPSBndGtfZmlsZV9m aWx0ZXJfbmV3KCk7CiAgICBndGtfZmlsZV9maWx0ZXJfc2V0X25hbWUgKGZpbHRlciwgXygicm0v cm12YiBmaWxlcyIpKTsKLy8gICAgZ3RrX2ZpbGVfZmlsdGVyX2FkZF9wYXR0ZXJuKGZpbHRlciwi Ki5bclJdW21NXSIpOwovLyAgICBndGtfZmlsZV9maWx0ZXJfYWRkX3BhdHRlcm4oZmlsdGVyLCIq LltyUl1bbU1dW3Z2XVtiQl0iKTsKICAgIGd0a19maWxlX2ZpbHRlcl9hZGRfbWltZV90eXBlIChm aWx0ZXIsImFwcGxpY2F0aW9uL3ZuZC5ybi1yZWFsbWVkaWEiKTsKICAgIGd0a19maWxlX2Nob29z ZXJfYWRkX2ZpbHRlciAoR1RLX0ZJTEVfQ0hPT1NFUiAoZGlhbG9nKSxmaWx0ZXIpOwoKICAgIGd0 a19maWxlX2Nob29zZXJfc2V0X2xvY2FsX29ubHkgKEdUS19GSUxFX0NIT09TRVIgKGRpYWxvZyks IEZBTFNFKTsKCiAgICBndGtfZmlsZV9jaG9vc2VyX3NldF9jdXJyZW50X2ZvbGRlciAoR1RLX0ZJ TEVfQ0hPT1NFUiAoZGlhbG9nKSwiL2V0YyIpOwoKICAgIGd0a193aW5kb3dfc2V0X3Bvc2l0aW9u KEdUS19XSU5ET1coZGlhbG9nKSxHVEtfV0lOX1BPU19DRU5URVJfT05fUEFSRU5UKTsKCiAgICBp ZiAoZ3RrX2RpYWxvZ19ydW4gKEdUS19ESUFMT0cgKGRpYWxvZykpID09IEdUS19SRVNQT05TRV9B Q0NFUFQpewogICAgICAgIGNoYXIgKmZpbGVuYW1lOwogICAgICAgIGZpbGVuYW1lID0gZ3RrX2Zp bGVfY2hvb3Nlcl9nZXRfZmlsZW5hbWUgKEdUS19GSUxFX0NIT09TRVIgKGRpYWxvZykpOwogICAg ICAgIGd0a19lbnRyeV9zZXRfdGV4dChlbnRyeSxmaWxlbmFtZSk7CiAgICAgICAgZ19mcmVlKGZp bGVuYW1lKTsKICAgIH0KICAgIGd0a193aWRnZXRfZGVzdHJveShkaWFsb2cpOwp9CgppbnQgbWFp bihpbnQgYXJnYyxjaGFyICoqYXJndikKewogICAgZ3RrX2luaXQoJmFyZ2MsJmFyZ3YpOwogICAg R3RrV2lkZ2V0ICp3aW47CiAgICBHdGtXaWRnZXQgKmVudHJ5OwogICAgR3RrV2lkZ2V0ICpidXR0 b247CiAgICBHdGtXaWRnZXQgKmhib3g7CgogICAgd2luID0gZ3RrX3dpbmRvd19uZXcoR1RLX1dJ TkRPV19UT1BMRVZFTCk7CgogICAgaGJveCA9IGd0a19oYm94X25ldyhGQUxTRSwwKTsKCiAgICBl bnRyeSA9IGd0a19lbnRyeV9uZXcoKTsKCiAgICBidXR0b24gPSBndGtfYnV0dG9uX25ld193aXRo X2xhYmVsICgib3BlbiIpOwoKICAgIGd0a19ib3hfcGFja19zdGFydChHVEtfQk9YKGhib3gpLGVu dHJ5LFRSVUUsVFJVRSwwKTsKICAgIGd0a19ib3hfcGFja19zdGFydChHVEtfQk9YKGhib3gpLGJ1 dHRvbixUUlVFLFRSVUUsMCk7CgogICAgZ3RrX2NvbnRhaW5lcl9hZGQoR1RLX0NPTlRBSU5FUih3 aW4pLGhib3gpOwoKICAgIGdfc2lnbmFsX2Nvbm5lY3QoYnV0dG9uLCJjbGlja2VkIixHX0NBTExC QUNLKG9uX2J1dHRvbiksZW50cnkpOwoKICAgIGdfc2lnbmFsX2Nvbm5lY3Qod2luLCJkZWxldGUt ZXZlbnQiLEdfQ0FMTEJBQ0sob25fd2luX2RlbGV0ZSksTlVMTCk7CgogICAgZ3RrX3dpZGdldF9z aG93X2FsbCh3aW4pOwoKICAgIGd0a19tYWluKCk7Ly8vc3RhcnQgbWFpbiBldmVudCBsb29wCiAg ICByZXR1cm4gMDsKfQo=