11017 2017-02-06 16:19:37 +0000 wic: per-image native tool dependencies 2017-04-04 19:22:19 +0000 1 1 7 Build System, Metadata & Runtime OE-Core Scripts and Tools unspecified x86 Multiple RESOLVED FIXED 04 April 2017: RESOLVED Medium+ normal 2.3 M4 1 patrick.ohly patrick.ohly mikko.ylinen ross.burton srifenbark --- --- Done (doc changes complete) oldest_to_newest 70446 0 patrick.ohly 2017-02-06 16:19:37 +0000 Image recipes can specify their own .wks files, and that file might use a custom source plugin. Currently there is no way to specify a dependency on native tools used by such a plugin without modifying the distro config of how wic-tools gets built. The approch that Ed and I discussed on IRC is to let wic check the native sysroot of the current image recipe first, then fall back to the sysroot of wic-tools. Ed, bonus points if those dependencies only get added to DEPENDS of the image recipe when the "wic" image type is really active. Something like (untested): my-image.bb: WKS_FILE_DEPENDS = "some-tool-native" image_types_wic.bbclass: WKS_FILE_DEPENDS ??= '' DEPENDS += "${@ '${WKS_FILE_DEPENDS}' if d.getVar('USING_WIC') else '' }" 70447 1 patrick.ohly 2017-02-06 16:20:59 +0000 While at it, also enhance the error message in exec_native_cmd() such that it is more obvious where the command was searched. I had to extend the output before I realized why my image recipe's DEPENDS was not having an effect. 70863 2 eduard.bartosh 2017-02-21 15:32:44 +0000 Fix has been sent to the mailing list for review: http://lists.openembedded.org/pipermail/openembedded-core/2017-February/133080.html 70865 3 eduard.bartosh 2017-02-21 15:35:22 +0000 Scott, can you help us to add WKS_FILE_DEPENDS to the documentation, please? 70988 4 srifenbark 2017-02-28 17:51:37 +0000 Ed, Yes - can you send me a base description of the variable? It doesn't have to be polished. Just make sure you include information on how a user applies it (i.e. conf file?) and what the possible values are and what effects they have. I will create a glossary entry for the variable and see about integrating it into wics documentation appropriately. Scott 70993 5 eduard.bartosh 2017-02-28 19:04:12 +0000 Here is what I came up with. Patrick, feel free to suggest better description. WKS_FILE_DEPENDS[doc] = "Lists a recipe's build-time dependencies specific to wic." This variable is similar to DEPENDS variable. It lists build-time dependencies that will be used only when wic images are active, i.e. when IMAGE_FSTYPES variable contains wic related entries. In this case dependencies mentioned in WIC_FILE_DEPENDS variable will be added to DEPENDS variable. If wic images are not active this variable doesn't influence the build. This approach gives recipe developer a possibility to specify list of additional dependencies that are required to build wic images: native tools, bootloaders, etc. 71079 6 eduard.bartosh 2017-03-06 11:39:53 +0000 The patchset has been merged to master. 71452 7 srifenbark 2017-03-20 16:40:05 +0000 Hi Patrick, I have created a new variable glossary definition for WKS_FILE_DEPENDS in the ref-manual at http://www.yoctoproject.org/docs/2.3/ref-manual/ref-manual.html#var-WKS_FILE_DEPENDS. Check it out and let me know if it is okay. If not, we can adjust it. Also, in the dev-manual in the section that covers how to use Wic, I added a small note in the "Plug-ins" section to cross-reference to the variable in context. See http://www.yoctoproject.org/docs/2.3/dev-manual/dev-manual.html#openembedded-kickstart-plugins. One thing I noticed in your original Comment 1 is that a class "image_types_wic.bbclass" is mentioned. We have a reference section for classes in the ref-manual and we do not document this class. Does the user have to alter this class in order to get dependencies to work as well? If so, we probably should list that class in the reference. I am REOPENING the bug since there is a documentation component. Also putting the target to 2.3 M4. Please review and send me your feedback here. Thanks, Scott 71469 8 srifenbark 2017-03-20 17:51:33 +0000 Setting to 2.3 M4 and putting at IN PROGRESS REVIEW 71779 9 srifenbark 2017-03-27 21:27:36 +0000 Still need some input on my question in Comment 7. Setting to NEEDINFO. Scott 72059 10 patrick.ohly 2017-04-04 07:41:18 +0000 (In reply to comment #7) > Hi Patrick, > > I have created a new variable glossary definition for WKS_FILE_DEPENDS in > the ref-manual at > http://www.yoctoproject.org/docs/2.3/ref-manual/ref-manual.html#var- > WKS_FILE_DEPENDS. Check it out and let me know if it is okay. If not, we > can adjust it. > > Also, in the dev-manual in the section that covers how to use Wic, I added a > small note in the "Plug-ins" section to cross-reference to the variable in > context. See > http://www.yoctoproject.org/docs/2.3/dev-manual/dev-manual.html#openembedded- > kickstart-plugins. Both looks good. > One thing I noticed in your original Comment 1 is that a class > "image_types_wic.bbclass" is mentioned. We have a reference section for > classes in the ref-manual and we do not document this class. Does the user > have to alter this class in order to get dependencies to work as well? No. It's an internal helper class that users typically won't interact with. 72083 11 srifenbark 2017-04-04 19:22:19 +0000 Thanks Patrick. I am going to mark the doc flag as "done." Scott