<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>11021</bug_id>
          
          <creation_ts>2017-02-07 01:41:28 +0000</creation_ts>
          <short_desc>Section on source archiving needs to discuss filtering options</short_desc>
          <delta_ts>2017-04-10 18:19:51 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>9</classification_id>
          <classification>Documentation</classification>
          <product>Development Manual</product>
          <component>development</component>
          <version>2.3</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard>10 April 2017: RESOLVED</status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>2.3 M4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Paul Eggleton">bluelightning</reporter>
          <assigned_to name="Scott Rifenbark">srifenbark</assigned_to>
          <cc>srifenbark</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Done (doc changes complete)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>70462</commentid>
    <comment_count>0</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2017-02-07 01:41:28 +0000</bug_when>
    <thetext>The &quot;Maintaining Open Source License Compliance During Your Product&apos;s Lifecycle&quot; section in the dev manual covers use of archiver.bbclass, but is missing mention of the filtering options e.g COPYLEFT_LICENSE_INCLUDE, COPYLEFT_LICENSE_EXCLUDE and COPYLEFT_RECIPE_TYPES - instead it includes a script to do this filtering. I suspect that script is no longer needed since the introduction of these variables (a few releases ago).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70507</commentid>
    <comment_count>1</comment_count>
    <who name="Scott Rifenbark">srifenbark</who>
    <bug_when>2017-02-07 18:17:02 +0000</bug_when>
    <thetext>Paul, 

We currently do not document the variables  COPYLEFT_LICENSE_INCLUDE, COPYLEFT_LICENSE_EXCLUDE and COPYLEFT_RECIPE_TYPES.  Can you provide some base explanations for these variables?  Once I understand them more I can see where they fit in or replace stuff in that &quot;Maintaining Open Source License Compliance During Your Product&apos;s Lifecycle&quot; section.  I read through the section and don&apos;t really understand it at this point.

Thanks, 
Scott</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70513</commentid>
    <comment_count>2</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2017-02-07 19:22:23 +0000</bug_when>
    <thetext>OK so here is something for each variable - I see there are a couple more related ones that weren&apos;t covered as well:

COPYLEFT_LICENSE_INCLUDE is a space-separated list of licenses to include in the source archived by the archiver class, i.e. if a license in a recipe&apos;s LICENSE value is in the value of COPYLEFT_LICENSE_INCLUDE then its source will be archived by the class. The value default set by the copyleft_filter class (which is inherited by the archiver class) is &quot;GPL* LGPL*&quot;.

COPYLEFT_LICENSE_EXCLUDE is a space-separated list of licenses to exclude from the source archived by the archiver class, i.e. if a license in a recipe&apos;s LICENSE value is in the value of COPYLEFT_LICENSE_EXCLUDE then its source will not be archived by the class. This takes precedence over COPYLEFT_LICENSE_INCLUDE. The default value set by the copyleft_filter class (which is inherited by the archiver class) is &quot;CLOSED Proprietary&quot;.

COPYLEFT_RECIPE_TYPES is a space-separated list of recipe types to include in the source archived by the archiver class - where the types are target, native, nativesdk, cross, crosssdk and cross-canadian. The default value set by the copyleft_filter class (which is inherited by the archiver class) is &quot;target&quot;.

COPYLEFT_PN_INCLUDE is a list of recipes to include in the source archived by the archiver class. This overrides the license inclusion / exclusion by COPYLEFT_LICENSE_INCLUDE / COPYLEFT_LICENSE_EXCLUDE. The default value set by the copyleft_filter class (which is inherited by the archiver class) is &quot;&quot; i.e. do not explicitly include any recipes by name.

COPYLEFT_PN_EXCLUDE is a list of recipes to exclude from the source archived by the archiver class. This overrides the license inclusion / exclusion by COPYLEFT_LICENSE_INCLUDE / COPYLEFT_LICENSE_EXCLUDE and COPYLEFT_PN_INCLUDE. The default value set by the copyleft_filter class (which is inherited by the archiver class) is &quot;&quot; i.e. do not explicitly exclude any recipes by name.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>70677</commentid>
    <comment_count>3</comment_count>
    <who name="Scott Rifenbark">srifenbark</who>
    <bug_when>2017-02-14 02:54:47 +0000</bug_when>
    <thetext>(In reply to comment #2)
&gt; OK so here is something for each variable - I see there are a couple more
&gt; related ones that weren&apos;t covered as well:
&gt; 
&gt; COPYLEFT_LICENSE_INCLUDE is a space-separated list of licenses to include in
&gt; the source archived by the archiver class, i.e. if a license in a recipe&apos;s
&gt; LICENSE value is in the value of COPYLEFT_LICENSE_INCLUDE then its source
&gt; will be archived by the class. The value default set by the copyleft_filter
&gt; class (which is inherited by the archiver class) is &quot;GPL* LGPL*&quot;.

See http://www.yoctoproject.org/docs/2.3/ref-manual/ref-manual.html#var-COPYLEFT_LICENSE_INCLUDE for the new description.

&gt; 
&gt; COPYLEFT_LICENSE_EXCLUDE is a space-separated list of licenses to exclude
&gt; from the source archived by the archiver class, i.e. if a license in a
&gt; recipe&apos;s LICENSE value is in the value of COPYLEFT_LICENSE_EXCLUDE then its
&gt; source will not be archived by the class. This takes precedence over
&gt; COPYLEFT_LICENSE_INCLUDE. The default value set by the copyleft_filter class
&gt; (which is inherited by the archiver class) is &quot;CLOSED Proprietary&quot;.

See http://www.yoctoproject.org/docs/2.3/ref-manual/ref-manual.html#var-COPYLEFT_LICENSE_EXCLUDE for the new description.

&gt; 
&gt; COPYLEFT_RECIPE_TYPES is a space-separated list of recipe types to include
&gt; in the source archived by the archiver class - where the types are target,
&gt; native, nativesdk, cross, crosssdk and cross-canadian. The default value set
&gt; by the copyleft_filter class (which is inherited by the archiver class) is
&gt; &quot;target&quot;.

See http://www.yoctoproject.org/docs/2.3/ref-manual/ref-manual.html#var-COPYLEFT_RECIPE_TYPES for the new description.

&gt; 
&gt; COPYLEFT_PN_INCLUDE is a list of recipes to include in the source archived
&gt; by the archiver class. This overrides the license inclusion / exclusion by
&gt; COPYLEFT_LICENSE_INCLUDE / COPYLEFT_LICENSE_EXCLUDE. The default value set
&gt; by the copyleft_filter class (which is inherited by the archiver class) is
&gt; &quot;&quot; i.e. do not explicitly include any recipes by name.

See http://www.yoctoproject.org/docs/2.3/ref-manual/ref-manual.html#var-COPYLEFT_PN_INCLUDE for the new description.

&gt; 
&gt; COPYLEFT_PN_EXCLUDE is a list of recipes to exclude from the source archived
&gt; by the archiver class. This overrides the license inclusion / exclusion by
&gt; COPYLEFT_LICENSE_INCLUDE / COPYLEFT_LICENSE_EXCLUDE and COPYLEFT_PN_INCLUDE.
&gt; The default value set by the copyleft_filter class (which is inherited by
&gt; the archiver class) is &quot;&quot; i.e. do not explicitly exclude any recipes by name.

See http://www.yoctoproject.org/docs/2.3/ref-manual/ref-manual.html#var-COPYLEFT_PN_EXCLUDE for the new description.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>71477</commentid>
    <comment_count>4</comment_count>
    <who name="Scott Rifenbark">srifenbark</who>
    <bug_when>2017-03-20 18:24:38 +0000</bug_when>
    <thetext>Setting to 2.3 M4 and need the review on the changes.

Scott</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>72231</commentid>
    <comment_count>5</comment_count>
    <who name="Scott Rifenbark">srifenbark</who>
    <bug_when>2017-04-10 18:19:51 +0000</bug_when>
    <thetext>Hi, 

No review since February - Assumed good.  Marking as RESOLVED and putting the doc flag to &quot;done.&quot;

thanks,
Scott</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>