<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>11302</bug_id>
          
          <creation_ts>2017-04-06 12:09:28 +0000</creation_ts>
          <short_desc>IMAGE_DEPENDS_* are added to do_rootfs[depends]</short_desc>
          <delta_ts>2017-06-29 07:59:37 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>Scripts and Tools</component>
          <version>2.0.3</version>
          <rep_platform>All</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ola Nilsson">ola.x.nilsson</reporter>
          <assigned_to name="Ed Bartosh">eduard.bartosh</assigned_to>
          <cc>ross.burton</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Yes (doc changes required)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>72128</commentid>
    <comment_count>0</comment_count>
    <who name="Ola Nilsson">ola.x.nilsson</who>
    <bug_when>2017-04-06 12:09:28 +0000</bug_when>
    <thetext>The IMAGE_DEPENDS variable can be overriden to add dependencies for individual image types.  Those dependencies are added to the do_rootfs task, while they really should be added to the specific image type tasks.

Also, the IMAGE_DEPENDS variable is not documented anywhere.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>72137</commentid>
    <comment_count>1</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2017-04-06 15:24:20 +0000</bug_when>
    <thetext>I did look and the code in image_types.bbclass does indeed put the dependencies onto do_rootfs rather than the specific image creation tasks.

I think we want to move to a model where these tasks have explicit dependencies, e.g. instead of IMAGE_DEPENDS_jffs2 = &quot;mtd-utils-native&quot; we&apos;d have do_image_jffs2[depends] += &quot;mtd-utils-native:do_populate_sysroot&quot;.

Since we&apos;re into feature freeze, I&apos;m not sure how far we want to change things at this point in the release cycle and this may well need to be a 2.4 M1 activity. The end result may be the deprecation and removal of IMAGE_DEPENDS.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>72171</commentid>
    <comment_count>2</comment_count>
    <who name="Ola Nilsson">ola.x.nilsson</who>
    <bug_when>2017-04-07 07:28:30 +0000</bug_when>
    <thetext>I guess the rootfs dependencies are leftovers from the switch to the separated image tasks. 

I kind of like the way I can add just recipe names without the :do_populate_sysroot, but I can see the point in eliminating this set of variables.

Anyway, it can certainly wait until 2.4.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>74193</commentid>
    <comment_count>3</comment_count>
    <who name="Ed Bartosh">eduard.bartosh</who>
    <bug_when>2017-06-15 12:06:05 +0000</bug_when>
    <thetext>Replaced usage of IMAGE_DEPENDS with explicitly added
dependencies to do_image_&lt;image type&gt; tasks: http://lists.openembedded.org/pipermail/openembedded-core/2017-June/138217.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>74197</commentid>
    <comment_count>4</comment_count>
    <who name="Ola Nilsson">ola.x.nilsson</who>
    <bug_when>2017-06-15 12:59:45 +0000</bug_when>
    <thetext>Looks good to me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>74282</commentid>
    <comment_count>5</comment_count>
    <who name="Ed Bartosh">eduard.bartosh</who>
    <bug_when>2017-06-16 14:19:34 +0000</bug_when>
    <thetext>Surprisingly I manage to get to v4 so far :)
http://lists.openembedded.org/pipermail/openembedded-core/2017-June/138386.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>74289</commentid>
    <comment_count>6</comment_count>
    <who name="Ed Bartosh">eduard.bartosh</who>
    <bug_when>2017-06-16 15:24:18 +0000</bug_when>
    <thetext>v5! http://lists.openembedded.org/pipermail/openembedded-core/2017-June/138388.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>74623</commentid>
    <comment_count>7</comment_count>
    <who name="Ed Bartosh">eduard.bartosh</who>
    <bug_when>2017-06-29 07:59:37 +0000</bug_when>
    <thetext>The fix has been accepted to poky master. Commit id: f93d58378fb4095a18c1403de03ca0e13ce465cd</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>