<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>11332</bug_id>
          
          <creation_ts>2017-04-11 16:32:07 +0000</creation_ts>
          <short_desc>opkg does not trim Provides strings and may miss Provides with Windows line endings</short_desc>
          <delta_ts>2017-04-19 21:36:29 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>opkg</product>
          <component>opkg</component>
          <version>0.3.4</version>
          <rep_platform>x86</rep_platform>
          <op_sys>x86_64</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Undecided</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>0.3.5</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Paul Spangler">paul.spangler</reporter>
          <assigned_to name="Alejandro del Castillo">alejandro.delcastillo</assigned_to>
          
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Don&apos;t know</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>72303</commentid>
    <comment_count>0</comment_count>
      <attachid>3708</attachid>
    <who name="Paul Spangler">paul.spangler</who>
    <bug_when>2017-04-11 16:32:07 +0000</bug_when>
    <thetext>Created attachment 3708
Example reproduction feed

opkg is tolerant for Windows line endings in a feed, but appears to have missed trimming the Provides string before processing it, unlike other relationship strings. Installing a package from a feed that uses Windows line endings results in the Provides string keeping an extra \r at the end, which prevents the solver from detecting other relationships such as a conflicts.

See the attached example feed with two empty packages that conflict using a virtual package. For example, I see the following in /var/lib/opkg/status:

Package: test-package-1
Version: 1.0.0-0
Provides: test-virtual-package^M
Replaces: test-virtual-package
Conflicts: test-virtual-package
Status: install ok installed
Architecture: x64
Installed-Time: 1491928274

Expectation
-----------
# opkg install test-package-1 test-package-2
Solver encountered 1 problem(s):
Problem 1/1:
  - package test-package-2-1.0.0-1.x64 conflicts with test-virtual-package provided by test-package-1-1.0.0-0.x64

Solution 1:
  - do not ask to install a package providing test-package-2

Solution 2:
  - do not ask to install a package providing test-package-1

Actual Result
-------------
# opkg -v
opkg version 0.3.4 (libsolv 0.6.24)
# opkg install test-package-1 test-package-2
Installing test-package-1 (1.0.0) on root
Installing test-package-2 (1.0.0) on root
Configuring test-package-1.
Configuring test-package-2.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>72683</commentid>
    <comment_count>1</comment_count>
    <who name="Alejandro del Castillo">alejandro.delcastillo</who>
    <bug_when>2017-04-19 21:36:29 +0000</bug_when>
    <thetext>fixed on commit f6f0aee288bf4cdd56fb355ba90d95039782528b</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>3708</attachid>
            <date>2017-04-11 16:32:07 +0000</date>
            <delta_ts>2017-04-11 16:32:07 +0000</delta_ts>
            <desc>Example reproduction feed</desc>
            <filename>TestPackages.zip</filename>
            <type>application/x-download</type>
            <size>2466</size>
            <attacher name="Paul Spangler">paul.spangler</attacher>
            
              <data encoding="base64">UEsDBBQAAAAIAIdZi0rSBzx1QwEAADsDAAAVAAAAVGVzdFBhY2thZ2VzL1BhY2thZ2VzvZFNasMw
EIX3At1BF7Cx/BM7ppSWhkIXhVI33QZZGqdDFNlIcmh6tS56pF6hSupVIZBF6EKLeW+GGb3v+/Pr
1so39CD9aKFm77OckrvedBqldzXz4Hy0Q+tHoaNByI1YAyULcNLi4LE3NXsJLezp12KcknvUYMQW
puFpKOIrHidxEiWrsCPGYUPJg3FeaA0qavAj9CeUPC6KZtzWLCuzruB5llQVFG1Vlq1KIWi5kJAV
5Tx0CjQ+PLB12D5q1gzCrDVYdjWEMnZTeWMwlv32mpLpxr93BcNib9HvaxbuMUpYddD6HSo4GcEz
DDrcctJvQqLHeJYeNXoEF7TjL4t5RcnSgX1Fh60Oyv5gvoJ1x4EpJkoouSyb9CSbdGLDz2LTQsaL
jIukzVVS8k7kslXdPC3VrGxBisuxSf+fzewMNvzA5gdQSwMEFAAAAAAAh1mLSl4J4iBVAQAAVQEA
ABgAAABUZXN0UGFja2FnZXMvUGFja2FnZXMuZ3ofiwgAXQDtWAADvZFNasMwEIX3At1BF7Cx/BM7
ppSWhkIXhVI33QZZGqdDFNlIcmh6tS56pF6hSupVIZBF6EKLeW+GGb3v+/Pr1so39CD9aKFm77Oc
krvedBqldzXz4Hy0Q+tHoaNByI1YAyULcNLi4LE3NXsJLezp12KcknvUYMQWpuFpKOIrHidxEiWr
sCPGYUPJg3FeaA0qavAj9CeUPC6KZtzWLCuzruB5llQVFG1Vlq1KIWi5kJAV5Tx0CjQ+PLB12D5q
1gzCrDVYdjWEMnZTeWMwlv32mpLpxr93BcNib9HvaxbuMUpYddD6HSo4GcEzDDrcctJvQqLHeJYe
NXoEF7TjL4t5RcnSgX1Fh60Oyv5gvoJ1x4EpJkoouSyb9CSbdGLDz2LTQsaLjIukzVVS8k7kslXd
PC3VrGxBisuxSf+fzewMNvzA5gfSBzx1OwMAAFBLAwQUAAAACACHWYtK/odQwDwAAABWAAAAHAAA
AFRlc3RQYWNrYWdlcy9QYWNrYWdlcy5zdGFtcHMzNLE0tDQyMzA1VShJLS7RLUhMzk5MT9U1jDfU
M9Az0DWIrzAz0cssyOblMgQrNTewNENVagRVaohQCgBQSwMEFAAAAAgAyFaLSrm9VmwCAgAAVgIA
ACsAAABUZXN0UGFja2FnZXMvdGVzdC1wYWNrYWdlLTFfMS4wLjAtMF94NjQuaXBrU7RJLErOsONK
SU3KTMzTTcrMSyyqVFBQMDSxNLQ0MDExNVNQMFAAAQhpaGBgZmKioGCiAAMJXEZ6BlzJ+XklRfk5
eiWJRXrpVYT1GxvCTEjgku/mYFD/8yaCgfntxINezIYCbd/nLD/B/cYsczuvjlJXnA3H0a17j+es
aTaMVLuZVFvlHi3KtVVcXPB78wQfo8k/J++XSN2r3DJjqmr97M6/ldInOgOELedpLNwxIUhr5sfM
/5c2ren2VPY8KHCpvPL4ue/y39013NR+tBz8euPxjP9PQ2p/6rP+tJ+nNbXw4uJl/v92/n+eIacQ
Odlqi2j9vKk5mYZOH0Snt2q46N2QUVRY4nv05eqaxRsTw+dNO3dTbf3D1lcanrPd9y5K3WT49K3Z
KdXd1x4I83aLzn997uOuq3VPdT5NnnZI6d0hY/5WTv/la9R0378V55RR2TBRd9FRVZcdxSX/28z0
ck043pq9nyb1KbZa72Zv7lwzs3dT1jAGL7/brlQm+Gcv82S+uecN1yy0jPh3u4yXh4fnj8R6By/e
fQxcDAwpiSWJ8CAnItYsDRGxhgj1y5fTF1gaAIGxYSDDRYcGP2eLtmNsz461uR17xvaMi62tre1Z
Gw/Xsi3lUszOmYWeSYIXNF1//lT9cUVwkvv3OxoSrIsTRHiKGBjeBIl/ZGBjYOACAFBLAwQUAAAA
CABzWYtKAt9xOvwBAABUAgAAKwAAAFRlc3RQYWNrYWdlcy90ZXN0LXBhY2thZ2UtMl8xLjAuMC0x
X3g2NC5pcGtTtEksSs6w40pJTcpMzNNNysxLLKpUUFAwNLE0tDQwNbE0U1AwUAABCGloYGBmYqKg
YKIAAwlcRnoGXMn5eSVF+Tl6JYlFeulVhPUbGxrB9ct3czBYMLyNYGB+O/Gg32EDnrbqc8FPWG+p
5l73EnVS2FHgsEritu2SxIiWJUV3Oj9+YTGz8GmKXSGwaL7I0b63P/znnJ10UdApJPXk/W8nHu4r
TlF85fTs8y6BGA/N1VYPP39cqnpSwCNxStO9y+WVxx+19/9WTjF+K7twu/I3C7P/RXHyZ+zXu0ws
MFy0zP/fzz/nA+0ZJH2ZZ7XZh6tGS/I8iD2cqmY00euaUgXLLTObuqmvRcrenHK9HHV5KXdFZ2nT
Vi/7VaUmJ1m8fs+d/uxNVOPiHTxme0Kbn3bH7dxqesL/14u0xPfzLE9sqbdK7V7xdO/fSQeYGjlz
JHnWKRyY2/s9//HBpZxSC+8/vXusreb+vOdvjn0JyxT+5mXWYKLxe2FHbEV5vuPl8I9if9l26Z+u
r44RBgL7Y9ot0V56DFwMDCmJJYnwACciziwNEXGGCPPLl9MXWBoAgbFhIMNFhwY/Z4u2Y2zPjrW5
LXt2jI2Lra2tLe0ZD9eyLeVSzM6ZhZ5Jghc0XX/+VP1xRXCS+/c7GhKsixNEeIoYGJpmaa9hYGNg
4AIAUEsBAhQAFAAAAAgAh1mLStIHPHVDAQAAOwMAABUAAAAAAAAAAQAgAAAAAAAAAFRlc3RQYWNr
YWdlcy9QYWNrYWdlc1BLAQIUABQAAAAAAIdZi0peCeIgVQEAAFUBAAAYAAAAAAAAAAAAIAAAAHYB
AABUZXN0UGFja2FnZXMvUGFja2FnZXMuZ3pQSwECFAAUAAAACACHWYtK/odQwDwAAABWAAAAHAAA
AAAAAAABACAAAAABAwAAVGVzdFBhY2thZ2VzL1BhY2thZ2VzLnN0YW1wc1BLAQIUABQAAAAIAMhW
i0q5vVZsAgIAAFYCAAArAAAAAAAAAAAAIAAAAHcDAABUZXN0UGFja2FnZXMvdGVzdC1wYWNrYWdl
LTFfMS4wLjAtMF94NjQuaXBrUEsBAhQAFAAAAAgAc1mLSgLfcTr8AQAAVAIAACsAAAAAAAAAAAAg
AAAAwgUAAFRlc3RQYWNrYWdlcy90ZXN0LXBhY2thZ2UtMl8xLjAuMC0xX3g2NC5pcGtQSwUGAAAA
AAUABQCFAQAABwgAAAAA
</data>

          </attachment>
      

    </bug>

</bugzilla>