11389 2017-04-20 02:58:10 +0000 devtool: add: automatically set branch for git URLs if not master 2017-10-09 03:05:30 +0000 1 1 7 Build System, Metadata & Runtime OE-Core Scripts and Tools 2.2 x86 Multiple VERIFIED FIXED Medium+ enhancement 2.4 M3 11393 1 bluelightning rebecca.swee.fun.chang brianx.j.kurle ee.peng.yeoh ross.burton shashwatx.pandey wmills shashwatx.pandey --- --- Don't know oldest_to_newest 72693 0 bluelightning 2017-04-20 02:58:10 +0000 If devtool add is run on a git URL and a revision is specified that is not on master, and branch= isn't already in the URL, then get the correct branch and add it to the URL. If the revision isn't on a branch, and it's not already there, add nobranch=1 to the URL. 73500 1 rebecca.swee.fun.chang 2017-05-25 09:37:36 +0000 Paul, certain repository has same source revision on multiple branches. How do we handle this kind of situation? It is not possible for devtool to get the correct branch in this situation. So, do we print out the branch that having the source revision and error out? 73514 2 bluelightning 2017-05-25 20:23:57 +0000 That's a good point. If the revision is on multiple branches, and we've already checked that one of them isn't master, then yes I don't think we have much choice but to error out telling the user they need to select one. 74988 3 rebecca.swee.fun.chang 2017-07-13 04:49:53 +0000 Submitted fix to mailing list. http://lists.openembedded.org/pipermail/openembedded-core/2017-July/139574.html 75533 4 rebecca.swee.fun.chang 2017-08-01 02:29:36 +0000 Patches are now staging at mut branch. Moving this to M3 as it has already overdue for M2. 75942 5 rebecca.swee.fun.chang 2017-08-17 05:36:49 +0000 v2 patch series fixed comment from Chris: http://lists.openembedded.org/pipermail/openembedded-core/2017-August/140860.html 76074 6 rebecca.swee.fun.chang 2017-08-23 08:02:07 +0000 OE-Core rev: ecca596b75cfda2f798a0bdde75f4f774e23a95b 77453 7 shashwatx.pandey 2017-10-09 03:05:30 +0000 Verification logs: a) Checkout to origin/master branch to get the fixes. b) Scenario1: When Revision is not on master- Perform devtool add bbexample-custom 'https://github.com/epyeoh/bbexample.git;rev=f26a5d9e53524edc72b9f476a628c35eb82e497b' c) Verify that the correct branch is added to the SRC_URI: SRC_URI = "git://github.com/epyeoh/bbexample.git;protocol=https;branch=dev1" d) Scenario2: If the revision is on multiple branches, and none of them is master: Perform devtool add bbexample 'https://github.com/epyeoh/bbexample.git;rev=a1e995ea27eb2e800cee1fc7b37672116aee2305' e) Verify the error for multiple branch of same revision: ERROR: Revision a1e995ea27eb2e800cee1fc7b37672116aee2305 was found on multiple branches: dev2 dev3 Please provide the correct branch with -B/--srcbranch ERROR: Command 'script -e -q -c "recipetool --color=always create --devtool -o /tmp/devtoolvnmzcrd_ 'https://github.com/epyeoh/bbexample.git;rev=a1e995ea27eb2e800cee1fc7b37672116aee2305' -x /workdir/build/workspace/sources/devtoolsrcqsb05ogk -N bbexample" /dev/null' failed f) Scenario3: If the revision is on multiple branch and branch is specified: Perform devtool add bbexample 'https://github.com/epyeoh/bbexample.git;rev=a1e995ea27eb2e800cee1fc7b37672116aee2305;branch=dev3' g) Verify that the correct branch is added to the SRC_URI: SRC_URI = "git://github.com/epyeoh/bbexample.git;branch=dev3;protocol=https" h) Scenario4: If the revision is on multiple branch and one of them is master: Perform devtool add bbexample 'https://github.com/shashwatpandey221091/bbexample.git;rev=60cca6f8fe6b74a9fa2f670fcb885be2d3f9bcb9' i) Verify that devtool should create the recipe without error and expected SRC_URI is : SRC_URI = “https://github.com/repo.git” without “branch=“: SRC_URI = "git://github.com/shashwatpandey221091/bbexample.git;protocol=https"