<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>11391</bug_id>
          
          <creation_ts>2017-04-20 03:31:50 +0000</creation_ts>
          <short_desc>recipetool: create: git URLs containing git@ have parameters stripped out</short_desc>
          <delta_ts>2017-10-09 03:32:10 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>Scripts and Tools</component>
          <version>2.2</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>VERIFIED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.4 M2</target_milestone>
          
          <blocked>11394</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Paul Eggleton">bluelightning</reporter>
          <assigned_to name="Stanley Phoong">stanley.cheong.kwan.phoong</assigned_to>
          <cc>brianx.j.kurle</cc>
    
    <cc>ee.peng.yeoh</cc>
    
    <cc>libertad.gonzalez.de.la.cruz</cc>
    
    <cc>ross.burton</cc>
    
    <cc>shashwatx.pandey</cc>
          
          <qa_contact name="Shashwat Pandey">shashwatx.pandey</qa_contact>
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>72697</commentid>
    <comment_count>0</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2017-04-20 03:31:50 +0000</bug_when>
    <thetext>If you specify git@ in a git URL it seems that we&apos;re chopping off any parameters, e.g. if you specify branch= then you won&apos;t actually get that branch specified in the SRC_URI nor will it be used to check out the source.

For example, if you run:

devtool add --version 2.4.2 mbedtls &quot;git@github.com:ARMmbed/mbedtls.git;branch=mbedtls-2.4&quot;

What you get in the recipe is:

SRC_URI = &quot;git://git@github.com/ARMmbed/mbedtls.git;protocol=ssh&quot;

Also what gets checked out is from master rather than the mbedtls-2.4 branch.

(Also related to bug 11390.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>74950</commentid>
    <comment_count>1</comment_count>
    <who name="Stanley Phoong">stanley.cheong.kwan.phoong</who>
    <bug_when>2017-07-12 09:31:11 +0000</bug_when>
    <thetext>Pushed commit to mailing list for review:
http://lists.openembedded.org/pipermail/openembedded-core/2017-July/139482.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75127</commentid>
    <comment_count>2</comment_count>
    <who name="Stanley Phoong">stanley.cheong.kwan.phoong</who>
    <bug_when>2017-07-19 01:04:39 +0000</bug_when>
    <thetext>Merged into Poky master:
http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=0df60c7de2e4a3ccbab28e338ee54a12c3008089</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>77454</commentid>
    <comment_count>3</comment_count>
    <who name="Shashwat Pandey">shashwatx.pandey</who>
    <bug_when>2017-10-09 03:32:10 +0000</bug_when>
    <thetext>Verification logs:

a) Checkout to origin/master branch to get the fixes.

b) Scenario1: Run recipetool create command by specifying git@ in the git URL:

	recipetool --color=always create --devtool -o workspace/recipes/mbedtls/mbedtls_git.bb  &apos;git://git@github.com/ARMmbed/mbedtls.git;branch=mbedtls-2.4;protocol=https&apos;  -x workspace/sources/mbedtls  -N mbedtls -V 2.4.2
	
c) Verify that the SRC_URI generated with correct URL:

	SRC_URI = &quot;git://git@github.com/ARMmbed/mbedtls.git;branch=mbedtls-2.4;protocol=https&quot;
	
d) Scenario2: Run devtool add command by specifying git@ in git URL:
	
	devtool add --version 2.4.2 mbedtls &quot;git@github.com:ARMmbed/mbedtls.git;branch=mbedtls-2.4;protocol=https&quot;
	
e) Verify that the SRC_URI generated with correct URL:
	
	SRC_URI = &quot;git://git@github.com/ARMmbed/mbedtls.git;branch=mbedtls-2.4;protocol=https&quot;

f) Verify bitbake mbedtls can build successfully:
	
	pokyuser@c86eac66192a:/workdir/build$ bitbake mbedtls
	Loading cache: 100% |##############################################################################################################################################################| Time: 0:00:00
	Loaded 1303 entries from dependency cache.
	Parsing recipes: 100% |############################################################################################################################################################| Time: 0:00:00
	Parsing of 819 .bb files complete (818 cached, 1 parsed). 1276 targets, 44 skipped, 0 masked, 0 errors.
	NOTE: Resolving any missing task queue dependencies
	
	Build Configuration:
	BB_VERSION        = &quot;1.35.0&quot;
	BUILD_SYS         = &quot;x86_64-linux&quot;
	NATIVELSBSTRING   = &quot;universal&quot;
	TARGET_SYS        = &quot;i586-poky-linux&quot;
	MACHINE           = &quot;qemux86&quot;
	DISTRO            = &quot;poky&quot;
	DISTRO_VERSION    = &quot;2.4&quot;
	TUNE_FEATURES     = &quot;m32 i586&quot;
	TARGET_FPU        = &quot;&quot;
	meta
	meta-poky
	meta-yocto-bsp    = &quot;master:fcdfe09d9cc4e2977bd602dfd18f729cd9f6d73d&quot;
	workspace         = &quot;&lt;unknown&gt;:&lt;unknown&gt;&quot;
	
	Initialising tasks: 100% |#########################################################################################################################################################| Time: 0:00:00
	Checking sstate mirror object availability: 100% |#################################################################################################################################| Time: 0:00:00
	NOTE: Executing SetScene Tasks
	NOTE: Executing RunQueue Tasks
	WARNING: mbedtls-2.4.2+git999-r0 do_populate_lic: mbedtls: No generic license file exists for: Unknown in any provider
	NOTE: mbedtls: compiling from external source tree /workdir/build/workspace/sources/mbedtls
	NOTE: Tasks Summary: Attempted 537 tasks of which 525 didn&apos;t need to be rerun and all succeeded.
	
	Summary: There was 1 WARNING message shown.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>