<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>11453</bug_id>
          
          <creation_ts>2017-05-03 21:55:13 +0000</creation_ts>
          <short_desc>misconfigured &quot;diff&quot; utility</short_desc>
          <delta_ts>2017-06-30 08:26:36 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>core</component>
          <version>2.3</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.4 M2</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Juro Bystricky">juro.bystricky</reporter>
          <assigned_to name="Jussi Kukkonen">jku</assigned_to>
          <cc>jku</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
    
    <cc>randy.macleod</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Don&apos;t know</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>73021</commentid>
    <comment_count>0</comment_count>
    <who name="Juro Bystricky">juro.bystricky</who>
    <bug_when>2017-05-03 21:55:13 +0000</bug_when>
    <thetext>When building &quot;core-image-minimal-initramfs-qemux86.cpio.gz&quot;,
the image contains the utility &quot;diff&quot;. (due to update alternatives it is called diff.diffutils). This utility relies on another utility &quot;pr&quot; to be present (for paginated output?). The location of this utility is hardcoded in the &quot;diff&quot; utility as &quot;/data/master-master/poky/build-repro-again/tmp/hosttools/pr&quot;, in other words the utility was detected from my local &quot;hosttools&quot; folder.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>73038</commentid>
    <comment_count>1</comment_count>
    <who name="Jussi Kukkonen">jku</who>
    <bug_when>2017-05-04 10:58:45 +0000</bug_when>
    <thetext>Is this known to break something (other than manually running &quot;diff -l&quot;)?

Fixing the path is easy (set ac_cv_path_PR_PROGRAM) but then we&apos;d have to RDEPEND on coreutils to actually have /usr/bin/pr ...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>73039</commentid>
    <comment_count>2</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2017-05-04 11:08:31 +0000</bug_when>
    <thetext>Assuming that its only diff -l that is broken then hardcoding the path and not adding a dependency seems right.

Juro, did you discover this by using diff -l, or some other way?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>73043</commentid>
    <comment_count>3</comment_count>
    <who name="Juro Bystricky">juro.bystricky</who>
    <bug_when>2017-05-04 14:18:59 +0000</bug_when>
    <thetext>I found out by using diffoscope, binary comparison of two different builds,
showing the build directory path.
Another possible way (I think) to fix this would be to remove &quot;pr&quot; from HOSTTOOLS in the recipe.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>73046</commentid>
    <comment_count>4</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2017-05-04 14:41:41 +0000</bug_when>
    <thetext>Removing pr from HOSTTOOLS causes libav&apos;s configure to moan.  Lets tell diff what pr to use.  Jussi, mind taking this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>74678</commentid>
    <comment_count>5</comment_count>
    <who name="Jussi Kukkonen">jku</who>
    <bug_when>2017-06-30 08:26:36 +0000</bug_when>
    <thetext>commit f1a5c7c53be36bbee3b7476b336bab5a04c2d46d
Author: Jussi Kukkonen &lt;jussi.kukkonen@intel.com&gt;
Date:   Fri Jun 9 10:36:18 2017 +0300

    diffutils: prevent host path leaks, set pr path
    
    Note that this just removes a host path leakage: diffutils still
    doesn&apos;t depend on coreutils so &apos;pr&apos; might not actually be there
    on image (this only breaks &quot;diff -l&quot; so no big deal).
    
    (From OE-Core rev: 3f7fd738981752a8c34c6cf4a1f2d4c035b081ca)</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>