11498 2017-05-11 06:38:16 +0000 INHERIT description ambiguous 2017-05-19 20:04:34 +0000 1 1 9 Documentation Development Manual development unspecified x86 Multiple RESOLVED FIXED 19 May 2017: RESOLVED Medium normal 2.4 1 patrick.ohly srifenbark patrick.ohly richard.purdie ross.burton srifenbark --- --- Done (doc changes complete) oldest_to_newest 73182 0 patrick.ohly 2017-05-11 06:38:16 +0000 Currently it says: INHERIT Causes the named class to be inherited at this point during parsing. The variable is only valid in configuration files. "this point" - which point? Not the point where the variable is set... "in configuration files" - is a .inc file a configuration file? I think what this is trying to say is that INHERIT can only be used as part of the base configuration (distro, machine, local configuration) and will inherit that class in the base configuration and each individual recipe. Perhaps phrase it like this: Causes the named class(es) to be inherited globally. Anonymous functions in it will get executed for the base configuration and in each individual recipe. Changes to this variable in individual recipes are ignored. 73183 1 patrick.ohly 2017-05-11 06:39:08 +0000 Richard, please check my enhancement proposal. 73194 2 richard.purdie 2017-05-11 14:56:15 +0000 This is basically correct but anonymous functions in it are probably not executed in the base configuration. 73215 3 srifenbark 2017-05-11 19:03:35 +0000 Hi, The glossaries of the BB Manual and the ref-manual both have INHERIT documented. I have updated each of these to match based on the comments below. Please look over the new description and let me know of any further changes. Also, there is a section on INHERIT in Chapter 3 of the BB manual. This section was not cross-referenced to the INHERIT variable in the BB manual glossary. I have cross-referenced it back to that variable. It might be worthwhile reading that section to see if it is still okay. Here are the various links to the sections that have changed: * The INHERIT glossary entry in the YP Dev manual - http://www.yoctoproject.org/docs/2.3/ref-manual/ref-manual.html#var-INHERIT * The INHERIT glossary entry in the YP BB manual - http://www.yoctoproject.org/docs/2.3/bitbake-user-manual/bitbake-user-manual.html#var-INHERIT * The section on how INHERIT is used in the BB manual - http://www.yoctoproject.org/docs/2.3/bitbake-user-manual/bitbake-user-manual.html#inherit-configuration-directive Thanks, Scott 73256 4 patrick.ohly 2017-05-15 11:31:48 +0000 Now that you've mentioned it, I also checked: http://www.yoctoproject.org/docs/2.3/bitbake-user-manual/bitbake-user-manual.html#inherit-configuration-directive It says: This configuration directive causes the named class to be inherited at the point of the directive during parsing. That's just not right. "the directive" presumably means the "INHERIT +=" statement, and that's not when the class gets inherited. I suggest replacing "at the point of the directive during parsing" with "after parsing the base configuration". Also add (because it is relevant, and the glossary shouldn't have more information than the detailed section): Anonymous functions in the class or classes are not executed for the base configuration and in each individual recipe. The OpenEmbedded build system ignores changes to INHERIT in individual recipes. 73379 5 srifenbark 2017-05-19 15:55:52 +0000 Hi Patrick, See http://www.yoctoproject.org/docs/2.3/bitbake-user-manual/bitbake-user-manual.html#inherit-configuration-directive for the changes and let me know if this is good. Thanks, Scott 73381 6 patrick.ohly 2017-05-19 16:06:32 +0000 (In reply to comment #5) > Hi Patrick, > > See > http://www.yoctoproject.org/docs/2.3/bitbake-user-manual/bitbake-user-manual. > html#inherit-configuration-directive for the changes and let me know if this > is good. I find "Anonymous functions in the class or classes are not executed for the base configuration and in each individual recipe." misleading. It might be misunderstood as "Anonymous functions in the class or classes are neither executed for the base configuration nor in each individual recipe.". I suggest "Anonymous functions in the class or classes are not executed for the base configuration. Instead they run once in each individual recipe." I also just noticed that the final example is broken (the section is about INHERIT, not inherit): inherit autotools pkgconfig => INHERIT += "buildhistory archiver" 73382 7 srifenbark 2017-05-19 16:22:08 +0000 Hi Patrick, How is this now? http://www.yoctoproject.org/docs/2.3/bitbake-user-manual/bitbake-user-manual.html#inherit-configuration-directive Scott 73384 8 patrick.ohly 2017-05-19 17:04:38 +0000 That's good now. 73388 9 srifenbark 2017-05-19 20:04:34 +0000 Thanks - setting the doc flag to "done." Scott