11507 2017-05-12 14:08:05 +0000 Assertion error when two buildset configurations use GitPoller for same repository 2017-06-07 14:52:33 +0000 1 1 5 Infrastructure AutoBuilder autobuilder unspecified x86 Multiple RESOLVED FIXED Medium normal 2.4 1 johannes.schrimpf joshuagloe infras.ab.watcher Infras.watcher pidge pokylinux --- --- No (bug/feature does not impact docs) oldest_to_newest 73235 0 3762 johannes.schrimpf 2017-05-12 14:08:05 +0000 Created attachment 3762 A suggested patch which is tested and working on my local setup When two different buildset configurations register a GitPoller for the same repository, an assertion error occurs in buildbot. To prevent this, a check should be implemented whether a GitPoller for this repository is already in yocto-sources and it should only be added if not. A suggested patch which is tested and working on my local setup is attached. When reproducing, please note that other than in the documentation different GitPollers have to have different names and that the second poller in the MultiBranch GitPoller example in the documentation overwrites the first one. This will be reported as an additional bug. 73808 1 joshuagloe 2017-06-07 14:52:33 +0000 Thanks for the report and the patch! I've merged the attached patch, with some slight changes to the format of the commit message, to the yocto-autobuilder repository: http://git.yoctoproject.org/clean/cgit.cgi/yocto-autobuilder/commit/?id=15aedc363019afc4361c93ac5571719d1dc6d453 For future contributions we ask that patches are sent to the mailing list yocto@yoctoproject.org for wider review. 3762 2017-05-12 14:08:05 +0000 2017-05-12 14:08:05 +0000 A suggested patch which is tested and working on my local setup 0001-lib-python2.7-site-packages-autobuilder-Autobuilder..patch application/octet-stream 2112 johannes.schrimpf RnJvbSBmZTcyNzdlY2EwOGM5YzQyN2MwMGExYmE2MDg1MjVlN2E1ZGNlOWZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2hhbm5lcyBTY2hyaW1wZiA8am9oYW5uZXMuc2NocmltcGZA Ymx1ZXllLm5vPgpEYXRlOiBGcmksIDEyIE1heSAyMDE3IDE1OjU2OjI3ICswMjAwClN1YmplY3Q6 IFtQQVRDSF0gbGliL3B5dGhvbjIuNy9zaXRlLXBhY2thZ2VzL2F1dG9idWlsZGVyL0F1dG9idWls ZGVyLnB5OiBDaGVjawogd2hldGhlciBHaXRQb2xsZXIgYWxyZWFkeSBpcyBpbiB5b2N0by1zb3Vy Y2VzCgpDaGVjayB3aGV0aGVyIEdpdFBvbGxlciBmb3IgdGhpcyByZXBvc2l0b3J5IGFscmVhZHkg aXMgaW4geW9jdG8tc291cmNlcyBhbmQgb25seSBhZGQgaXQgaWYgbm90LiBUaGlzIHByZXZlbnRz IGFuIGFzc2VydGlvbiBlcnJvciBvY2N1cmluZyBpbiBidWlsZGJvdCB3aGVuIHR3byBkaWZmZXJl bnQgYnVpbGRzZXQgY29uZmlndXJhdGlvbnMgcmVnaXN0ZXIgYSBHaXRQb2xsZXIgZm9yIHRoZSBz YW1lIHJlcG9zaXRvcnkuCgpTaWduZWQtb2ZmLWJ5OiBKb2hhbm5lcyBTY2hyaW1wZiA8am9oYW5u ZXMuc2NocmltcGZAYmx1ZXllLm5vPgotLS0KIGxpYi9weXRob24yLjcvc2l0ZS1wYWNrYWdlcy9h dXRvYnVpbGRlci9BdXRvYnVpbGRlci5weSB8IDggKysrKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCA2 IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGliL3B5dGhvbjIu Ny9zaXRlLXBhY2thZ2VzL2F1dG9idWlsZGVyL0F1dG9idWlsZGVyLnB5IGIvbGliL3B5dGhvbjIu Ny9zaXRlLXBhY2thZ2VzL2F1dG9idWlsZGVyL0F1dG9idWlsZGVyLnB5CmluZGV4IGMxYTVlOWIu LmM5NTc2ZTAgMTAwNjQ0Ci0tLSBhL2xpYi9weXRob24yLjcvc2l0ZS1wYWNrYWdlcy9hdXRvYnVp bGRlci9BdXRvYnVpbGRlci5weQorKysgYi9saWIvcHl0aG9uMi43L3NpdGUtcGFja2FnZXMvYXV0 b2J1aWxkZXIvQXV0b2J1aWxkZXIucHkKQEAgLTI2MCw4ICsyNjAsMTIgQEAgY2xhc3MgQXV0b2J1 aWxkZXI6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZWxzZToKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIyBkZWZhdWx0IHRvIDUgbWludXRlcyBwb2xsIGludGVydmFscwog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbnRlcnZhbCA9IDYwKjUKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICBzZWxmLnlvY3RvX3NvdXJjZXMuYXBwZW5kKEdpdFBvbGxlcihy ZXBvdXJsPXJlcG9bJ3JlcG91cmwnXSwgYnJhbmNoPWJyYW5jaCwgcG9sbEludGVydmFsPWludGVy dmFsKSkKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBsb2cubXNnKCJBZGRpbmcgR2l0UG9s bGVyIGFzIGNoYW5nZXNvdXJjZSBmb3IgIiArIHJlcG9uYW1lKQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGdpdHBvbGxlciA9IEdpdFBvbGxlcihyZXBvdXJsPXJlcG9bJ3JlcG91cmwnXSwg YnJhbmNoPWJyYW5jaCwgcG9sbEludGVydmFsPWludGVydmFsKQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGlmIGdpdHBvbGxlciBub3QgaW4gc2VsZi55b2N0b19zb3VyY2VzOgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxmLnlvY3RvX3NvdXJjZXMuYXBwZW5kKGdpdHBv bGxlcikKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbG9nLm1zZygiQWRkaW5nIEdp dFBvbGxlciBhcyBjaGFuZ2Vzb3VyY2UgZm9yICIgKyByZXBvbmFtZSkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICBlbHNlOgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsb2cu bXNnKCJHaXRQb2xsZXIgYWxyZWFkeSByZWdpc3RlcmVkIGFzIGNoYW5nZXNvdXJjZSBmb3IgIiAr IHJlcG9uYW1lKQogICAgICAgICAgICAgICAgICAgICAgICAgZWxzZToKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAjIGRlZmF1bHQgdG8gdXNlIFBCQ2hhbmdlU291cmNlIGFzIHRoZSBjaGFu Z2Vzb3VyY2UKICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxmLnlvY3RvX3NvdXJjZXMu YXBwZW5kKFBCQ2hhbmdlU291cmNlKHVzZXI9dXNlciwgcGFzc3dkPXBhc3N3ZCkpCi0tIAoyLjcu NAoK