11515 2017-05-17 03:54:59 +0000 test 'commit' first in get_vcs_reference 2017-08-07 19:27:32 +0000 1 1 7 Build System, Metadata & Runtime Toaster toaster 2.3 x86 Multiple RESOLVED FIXED Medium normal 2.4 M2 1 david.reyna david.reyna jessica.zhang stanciux.mihail libertad.gonzalez.de.la.cruz --- --- No (bug/feature does not impact docs) oldest_to_newest 73289 0 david.reyna 2017-05-17 03:54:59 +0000 The 'commit' value should be tested and used first when resolving the ref for a layer, since that is an explicit override in each layer index 'layeritem' record. If should take precedence over more-global 'branch' and 'release' values, instead of being last. Proposed patch is: def get_vcs_reference(self): + if self.commit is not None and len(self.commit) > 0: + return self.commit if self.branch is not None and len(self.branch) > 0: return self.branch if self.release is not None: return self.release.name - if self.commit is not None and len(self.commit) > 0: - return self.commit return 'N/A' 75698 1 david.reyna 2017-08-07 19:27:32 +0000 commit b4b2e6d4dfa4bac7aec100bae4bca36e371e4ed9