<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>11519</bug_id>
          
          <creation_ts>2017-05-17 14:46:26 +0000</creation_ts>
          <short_desc>check for four-space indented in python metadata</short_desc>
          <delta_ts>2017-11-30 20:46:17 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>Patchwork/Patchtest</product>
          <component>Patchtest Testsuite</component>
          <version>2.4</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>OBSOLETE</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>2.5 M2</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</reporter>
          <assigned_to name="Daniela Plascencia">daniela.plascencia</assigned_to>
          <cc>bluelightning</cc>
    
    <cc>ross.burton</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>73297</commentid>
    <comment_count>0</comment_count>
    <who name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</who>
    <bug_when>2017-05-17 14:46:26 +0000</bug_when>
    <thetext>According to [1] &quot;Python functions must be four space indented - no tabs.&quot;

[1] http://www.openembedded.org/wiki/Styleguide#Format_Guidelines</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>73326</commentid>
    <comment_count>1</comment_count>
    <who name="Daniela Plascencia">daniela.plascencia</who>
    <bug_when>2017-05-18 15:04:23 +0000</bug_when>
    <thetext>(In reply to comment #0)
&gt; According to [1] &quot;Python functions must be four space indented - no tabs.&quot;
&gt; 
&gt; [1] http://www.openembedded.org/wiki/Styleguide#Format_Guidelines

There&apos;s a Pylint option that catches tab indentation. We are already using Pylint to test Python code and I think changing a couple parameters will do the work. Do you think a new check is needed?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>73327</commentid>
    <comment_count>2</comment_count>
    <who name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</who>
    <bug_when>2017-05-18 15:07:16 +0000</bug_when>
    <thetext>(In reply to comment #1)
&gt; (In reply to comment #0)
&gt; &gt; According to [1] &quot;Python functions must be four space indented - no tabs.&quot;
&gt; &gt; 
&gt; &gt; [1] http://www.openembedded.org/wiki/Styleguide#Format_Guidelines
&gt; 
&gt; There&apos;s a Pylint option that catches tab indentation. We are already using
&gt; Pylint to test Python code and I think changing a couple parameters will do
&gt; the work. Do you think a new check is needed?

understood, then the pylint implementation should be the path to take.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>77113</commentid>
    <comment_count>3</comment_count>
    <who name="Daniela Plascencia">daniela.plascencia</who>
    <bug_when>2017-09-25 17:52:32 +0000</bug_when>
    <thetext>Changing to 2.5 M1. I&apos;m planning to tackle most of the test-suite enhancements on such milestone.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>77738</commentid>
    <comment_count>4</comment_count>
    <who name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</who>
    <bug_when>2017-10-20 14:45:23 +0000</bug_when>
    <thetext>This is not a M+, and can be work on M2.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>78439</commentid>
    <comment_count>5</comment_count>
    <who name="Daniela Plascencia">daniela.plascencia</who>
    <bug_when>2017-11-30 20:46:17 +0000</bug_when>
    <thetext>The test already checks for indentation errors/inconsistencies, but this issue is now obsolete as the pylint test case has to be refactored.
I&apos;m filing a new issue for tracking the refactoring process.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>