11738 2017-06-29 20:59:32 +0000 [gcc] compilation fails when using pre-compiled headers 2022-01-21 22:06:00 +0000 1 1 7 Build System, Metadata & Runtime OE-Core devtools / tool chain 2.3.2 BeagleBone arm RESOLVED FIXED Backport to 2.2.2, 2.3.2 if needed. Medium+ normal 2.4 M3 1 grolim64 juro.bystricky meta.mr.watcher meta.watcher pgowda.cve pinskia randy.macleod richard.purdie --- --- No (bug/feature does not impact docs) oldest_to_newest 74663 0 grolim64 2017-06-29 20:59:32 +0000 Hi all, Trying to update our code from krogoth to pyro, we have run into an issue where gcc/g++ (tested both versions 6.3 and 5.4). built under poky-pyro will segmentation fault when using pre-compiled headers and defining functions named 'major' or 'minor'. When using an ubuntu-provided cross-compiler (apt-get install g++-arm-linux-gnueabihf) or the host compiler, I cannot reproduce the behaviour (compiles without warning/error). To my knowledge the segmentation fault only occurs when using a compiler built via bitbake from the pyro branch. Environment: ----------------------- - ubuntu 16.04 x64 - pyro branch of poky - MACHINE set to beaglebone in local.conf - bblayers left at default (no extra layers) Example source files: ----------------------- $ cat precompiled.h #ifndef PRECOMPILED_H #define PRECOMPILED_H #include <algorithm> #endif // PRECOMPILED_H $ cat main.cpp #include "precompiled.h" class Version { public: void major() {} }; int main(void){ return 0;} Compilation: ----------------------- $ $CXX $CXXFLAGS -x c++-header precompiled.h $ $CXX $CXXFLAGS -H main.cpp ! precompiled.h.gch main.cpp main.cpp:5:2: internal compiler error: Segmentation fault void major() {} ^~~~ Please submit a full bug report, with preprocessed source if appropriate. See <http://gcc.gnu.org/bugs.html> for instructions. $ $CXX -v Using built-in specs. COLLECT_GCC=arm-poky-linux-gnueabi-g++ COLLECT_LTO_WRAPPER=/opt/work/poky/build/tmp/work/cortexa8hf-neon-poky-linux-gnueabi/meta-ide-support/1.0-r3/recipe-sysroot-native/usr/bin/arm-poky-linux-gnueabi/../../libexec/arm-poky-linux-gnueabi/gcc/arm-poky-linux-gnueabi/6.3.0/lto-wrapper Target: arm-poky-linux-gnueabi Configured with: ../../../../../../work-shared/gcc-6.3.0-r0/gcc-6.3.0/configure --build=x86_64-linux --host=x86_64-linux --target=arm-poky-linux-gnueabi --prefix=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot-native/usr --exec_prefix=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot-native/usr --bindir=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot-native/usr/bin/arm-poky-linux-gnueabi --sbindir=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot-native/usr/bin/arm-poky-linux-gnueabi --libexecdir=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot-native/usr/libexec/arm-poky-linux-gnueabi --datadir=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot-native/usr/share --sysconfdir=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot-native/etc --sharedstatedir=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot-native/com --localstatedir=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot-native/var --libdir=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot-native/usr/lib/arm-poky-linux-gnueabi --includedir=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot-native/usr/include --oldincludedir=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot-native/usr/include --infodir=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot-native/usr/share/info --mandir=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot-native/usr/share/man --disable-silent-rules --disable-dependency-tracking --with-libtool-sysroot=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot-native --enable-clocale=generic --with-gnu-ld --enable-shared --enable-languages=c,c++ --enable-threads=posix --disable-multilib --enable-c99 --enable-long-long --enable-symvers=gnu --enable-libstdcxx-pch --program-prefix=arm-poky-linux-gnueabi- --without-local-prefix --enable-lto --enable-libssp --enable-libitm --disable-bootstrap --disable-libmudflap --with-system-zlib --with-linker-hash-style=sysv --enable-linker-build-id --with-ppl=no --with-cloog=no --enable-checking=release --enable-cheaders=c_global --without-isl --with-gxx-include-dir=/not/exist/usr/include/c++/6.3.0 --with-sysroot=/not/exist --with-build-sysroot=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot --without-long-double-128 --enable-poison-system-directories --with-mpfr=/opt/work/poky/build/tmp/work/x86_64-linux/gcc-cross-arm/6.3.0-r0/recipe-sysroot-native/usr --with-system-zlib --disable-static --disable-nls --enable-initfini-array --with-arch=armv7-a Thread model: posix gcc version 6.3.0 (GCC) $ echo $CXXFLAGS -O2 -pipe -g -feliminate-unused-debug-types 74838 1 juro.bystricky 2017-07-06 16:09:08 +0000 I was also able to reproduce the problem with gcc version 7.1.0 (GCC) for i586 with the master (about June 28): $ $CXX -v Using built-in specs. COLLECT_GCC=i586-poky-linux-g++ COLLECT_LTO_WRAPPER=/home/juro/sdk-11587/sysroots/x86_64-pokysdk-linux/usr/libexec/i586-poky-linux/gcc/i586-poky-linux/7.1.0/lto-wrapper Target: i586-poky-linux Configured with: ../../../../../../work-shared/gcc-7.1.0-r0/gcc-7.1.0/configure --build=x86_64-linux --host=x86_64-pokysdk-linux --target=i586-poky-linux --prefix=/opt/poky/2.3/sysroots/x86_64-pokysdk-linux/usr --exec_prefix=/opt/poky/2.3/sysroots/x86_64-pokysdk-linux/usr --bindir=/opt/poky/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/i586-poky-linux --sbindir=/opt/poky/2.3/sysroots/x86_64-pokysdk-linux/usr/bin/i586-poky-linux --libexecdir=/opt/poky/2.3/sysroots/x86_64-pokysdk-linux/usr/libexec/i586-poky-linux --datadir=/opt/poky/2.3/sysroots/x86_64-pokysdk-linux/usr/share --sysconfdir=/opt/poky/2.3/sysroots/x86_64-pokysdk-linux/etc --sharedstatedir=/opt/poky/2.3/sysroots/x86_64-pokysdk-linux/com --localstatedir=/opt/poky/2.3/sysroots/x86_64-pokysdk-linux/var --libdir=/opt/poky/2.3/sysroots/x86_64-pokysdk-linux/usr/lib/i586-poky-linux --includedir=/opt/poky/2.3/sysroots/x86_64-pokysdk-linux/usr/include --oldincludedir=/opt/poky/2.3/sysroots/x86_64-pokysdk-linux/usr/include --infodir=/opt/poky/2.3/sysroots/x86_64-pokysdk-linux/usr/share/info --mandir=/opt/poky/2.3/sysroots/x86_64-pokysdk-linux/usr/share/man --disable-silent-rules --disable-dependency-tracking --with-libtool-sysroot=/data/master-master/poky/build-11587/tmp/work/x86_64-nativesdk-pokysdk-linux/gcc-cross-canadian-i586/7.1.0-r0/recipe-sysroot --with-gnu-ld --enable-shared --enable-languages=c,c++ --enable-threads=posix --enable-multilib --enable-c99 --enable-long-long --enable-symvers=gnu --enable-libstdcxx-pch --program-prefix=i586-poky-linux- --without-local-prefix --enable-lto --enable-libssp --enable-libitm --disable-bootstrap --disable-libmudflap --with-system-zlib --with-linker-hash-style=gnu --enable-linker-build-id --with-ppl=no --with-cloog=no --enable-checking=release --enable-cheaders=c_global --without-isl --with-gxx-include-dir=/not/exist/usr/include/c++/7.1.0 --with-build-time-tools=/data/master-master/poky/build-11587/tmp/work/x86_64-nativesdk-pokysdk-linux/gcc-cross-canadian-i586/7.1.0-r0/recipe-sysroot-native/usr/i586-poky-linux/bin --with-sysroot=/not/exist --with-build-sysroot=/data/master-master/poky/build-11587/tmp/work/x86_64-nativesdk-pokysdk-linux/gcc-cross-canadian-i586/7.1.0-r0/recipe-sysroot --without-long-double-128 --enable-targets=all --enable-poison-system-directories --with-mpfr=/data/master-master/poky/build-11587/tmp/work/x86_64-nativesdk-pokysdk-linux/gcc-cross-canadian-i586/7.1.0-r0/recipe-sysroot --with-mpc=/data/master-master/poky/build-11587/tmp/work/x86_64-nativesdk-pokysdk-linux/gcc-cross-canadian-i586/7.1.0-r0/recipe-sysroot --disable-static --enable-nls --enable-initfini-array --enable-__cxa_atexit Thread model: posix gcc version 7.1.0 (GCC) 74841 2 juro.bystricky 2017-07-06 16:36:42 +0000 As you noticed, the culprit is "major". After adding #include <sys/types.h> to the main.cpp: #include <sys/types.h> #include "precompiled.h" class Version { public: void major() {} }; int main(void){ return 0;} We get: $CXX $CXXFLAGS main.cpp main.cpp:6:13: warning: In the GNU C Library, "major" is defined by <sys/sysmacros.h>. For historical compatibility, it is currently defined by <sys/types.h> as well, but we plan to remove this soon. To use "major", include <sys/sysmacros.h> directly. If you did not intend to use a system-defined macro "major", you should undefine it after including <sys/types.h>. void major() {} ^~~~ So a quick work-around would be to either explicitly include <sys/types.h> or rename the method "major" to something like "version_major". Of course, there is no good excuse for the segmentation fault so I will look further. 74843 3 juro.bystricky 2017-07-06 17:16:51 +0000 Just a quick observation: Works for me if the pre-compiled header is created with "-save-temps": $CXX $CXXFLAGS -save-temps -x c++-header precompiled.h 74848 4 grolim64 2017-07-06 21:10:09 +0000 Confirming Juro's workaround of 'save-temps' works for me. Another workaround appears to be including <sys/sysmacros.h> before anything else in the pre-compiled header (which also defines major and minor). The bug appears possibly limited to how the 'major()'/'minor()' macros/functions are defined in <sys/types.h>? 75656 5 juro.bystricky 2017-08-04 16:47:50 +0000 Filed a bug report with GCC: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81721 75664 6 3919 juro.bystricky 2017-08-04 22:34:39 +0000 Created attachment 3919 This patch fixes the problem 75666 7 juro.bystricky 2017-08-04 22:50:20 +0000 Sent a patch to the mailing list: http://lists.openembedded.org/pipermail/openembedded-core/2017-August/140485.html 75677 8 grolim64 2017-08-07 01:33:38 +0000 Patch applies cleanly against the version 6.3 gcc recipe as well. Fixes the issue in both the reported test case and where I originally encountered the issue. In both cases I get the expected warning: warning: In the GNU C Library, "major" is defined by <sys/sysmacros.h>. <snip> Thanks for the help! 75902 9 juro.bystricky 2017-08-16 15:23:55 +0000 Merged with master: http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=b9b6ede7f8a191b82e8c8c711ad7425fa774c876 92067 10 pinskia 2021-11-25 06:11:05 +0000 (In reply to comment #9) > Merged with master: > http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/ > ?id=b9b6ede7f8a191b82e8c8c711ad7425fa774c876 This patch is no longer needed post GCC 10 as it was fixed correctly upstream. 92075 11 randy.macleod 2021-11-25 21:44:24 +0000 Andrew, Thanks for the report! I've asked Naveen Gowda to take a look and remove the patch. ../Randy 92379 12 randy.macleod 2022-01-21 22:06:00 +0000 FYI, The patch was dropped in: https://git.openembedded.org/openembedded-core/commit/?id=20aea61385e1a53ac245353899277ba20104ed2f 3919 2017-08-04 22:34:39 +0000 2017-08-04 22:34:39 +0000 This patch fixes the problem 0001-gcc7-fix-potential-segmentation-fault.patch text/plain 3564 juro.bystricky RnJvbSBkNWQzMmNiY2I4ZGU0YmI0MzUzNTcyMDZiZTk1OTVkOGI2M2EzMTQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKdXJvIEJ5c3RyaWNreSA8anVyby5ieXN0cmlja3lAaW50ZWwu Y29tPgpEYXRlOiBGcmksIDQgQXVnIDIwMTcgMTU6MDA6MDQgLTA3MDAKU3ViamVjdDogW1BBVENI XSBnY2M3OiBmaXggcG90ZW50aWFsIHNlZ21lbnRhdGlvbiBmYXVsdAoKVW5kZXIgc29tZSByYXJl IGNpcmN1bXN0YW5jZXMgd2UgbWF5IGVuZCB1cCB3aXRoIEdDQyBzZWdtZW50YXRpb24gZmF1bHQu ClRoaXMgd2FzIG9ic2VydmVkIHdpdGggdmVyc2lvbnMgb2Ygc3lzbWFjcm9zLmgsIHdoaWNoIGNv bnRhaW4gbWFjcm9zCndpdGggZW1iZWRkZWQgd2FybmluZyBtZXNzYWdlcyA6CgpXaGVuIHRyeWlu ZyB0byBhY3R1YWxseSBkaXNwbGF5IHRoZSB3YXJuaW5nLCB3ZSBtYXkgZW5kIHVwIHdpdGggYSBz ZWdtZW50YXRpb24KZmF1bHQgaW5zdGVhZC4gVGhlIHJlYXNvbiBpcyB0aGUgYWN0dWFsIHdhcm5p bmcgbWVzc2FnZSBnZXRzIHBhcnNlZCAodGhlIHRleHQgaXMKdW5xdW90ZWQpIGFuZCB3b3JkcyBp biB0aGUgbWVzc2FnZSBzdWNoIGFzICJub3QiLCAiYW5kIiBldGMuIGFyZSBpbnRlcnByZXRlZCBh cwpvcGVyYXRvcnMgQ1BQX05PVCwgQ1BQX0FORC4gV2hlbiB0aGUgdGltZSBjb21lcyB0byBkaXNw bGF5IHRoZSB3YXJuaW5nLCB0aGUgY29kZQp1c2VzIHdyb25nIHN0cnVjdHVyZSB0byBhY2Nlc3Mg dGhlICJuYW1lIiBjb3JyZXNwb25kaW5nIHRvIHRoZSBvcGVyYXRvcnMuCgpbWU9DVE8gIzExNzM4 XQoKU2lnbmVkLW9mZi1ieTogSnVybyBCeXN0cmlja3kgPGp1cm8uYnlzdHJpY2t5QGludGVsLmNv bT4KLS0tCiBtZXRhL3JlY2lwZXMtZGV2dG9vbHMvZ2NjL2djYy03LjEuaW5jICAgICAgICAgICAg ICB8ICAxICsKIC4uLi9maXgtc2VnbWVudGF0aW9uLWZhdWx0LXByZWNvbXBpbGVkLWhkci5wYXRj aCAgIHwgNDkgKysrKysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCA1MCBpbnNl cnRpb25zKCspCiBjcmVhdGUgbW9kZSAxMDA2NDQgbWV0YS9yZWNpcGVzLWRldnRvb2xzL2djYy9n Y2MtNy4xL2ZpeC1zZWdtZW50YXRpb24tZmF1bHQtcHJlY29tcGlsZWQtaGRyLnBhdGNoCgpkaWZm IC0tZ2l0IGEvbWV0YS9yZWNpcGVzLWRldnRvb2xzL2djYy9nY2MtNy4xLmluYyBiL21ldGEvcmVj aXBlcy1kZXZ0b29scy9nY2MvZ2NjLTcuMS5pbmMKaW5kZXggM2YxYzA2ZC4uMmQ5Y2E4MiAxMDA2 NDQKLS0tIGEvbWV0YS9yZWNpcGVzLWRldnRvb2xzL2djYy9nY2MtNy4xLmluYworKysgYi9tZXRh L3JlY2lwZXMtZGV2dG9vbHMvZ2NjL2djYy03LjEuaW5jCkBAIC03NSw2ICs3NSw3IEBAIFNSQ19V UkkgPSAiXAogICAgICAgICAgICBmaWxlOi8vMDA0OC1nY2MtRW5hYmxlLXN0YXRpYy1QSUUucGF0 Y2ggXAogICAgICAgICAgICBmaWxlOi8vMDA0OS1saWJzYW5pdGl6ZXItVXNlLXN0YWNrX3QtaW5z dGVhZC1vZi1zdHJ1Y3Qtc2lnYWx0c3RhLnBhdGNoIFwKICAgICAgICAgICAgZmlsZTovLzAwNTAt cmVwbGFjZS1zdHJ1Y3QtdWNvbnRleHQtd2l0aC11Y29udGV4dF90LnBhdGNoIFwKKyAgICAgICAg ICAgZmlsZTovL2ZpeC1zZWdtZW50YXRpb24tZmF1bHQtcHJlY29tcGlsZWQtaGRyLnBhdGNoIFwK ICAgICAgICAgICAgJHtCQUNLUE9SVFN9IFwKICIKIEJBQ0tQT1JUUyA9ICJcCmRpZmYgLS1naXQg YS9tZXRhL3JlY2lwZXMtZGV2dG9vbHMvZ2NjL2djYy03LjEvZml4LXNlZ21lbnRhdGlvbi1mYXVs dC1wcmVjb21waWxlZC1oZHIucGF0Y2ggYi9tZXRhL3JlY2lwZXMtZGV2dG9vbHMvZ2NjL2djYy03 LjEvZml4LXNlZ21lbnRhdGlvbi1mYXVsdC1wcmVjb21waWxlZC1oZHIucGF0Y2gKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYzBhZGVmNgotLS0gL2Rldi9udWxsCisrKyBiL21l dGEvcmVjaXBlcy1kZXZ0b29scy9nY2MvZ2NjLTcuMS9maXgtc2VnbWVudGF0aW9uLWZhdWx0LXBy ZWNvbXBpbGVkLWhkci5wYXRjaApAQCAtMCwwICsxLDQ5IEBACisKK1ByZXZlbnQgYSBzZWdtZW50 YXRpb24gZmF1bHQgd2hpY2ggb2NjdXJzIHdoZW4gdXNpbmcgaW5jb3JyZWN0CitzdHJ1Y3R1cmUg dHJ5aW5nIHRvIGFjY2VzcyBuYW1lIG9mIHNvbWUgbmFtZWQgb3BlcmF0b3JzLCBzdWNoIGFzIAor Q1BQX05PVCwgQ1BQX0FORCBldGMuICJ0b2tlbi0+dmFsLm5vZGUuc3BlbGxpbmciIGNhbm5vdCBi ZSB1c2VkIGluCit0aG9zZSBjYXNlcywgYXMgaXMgbWF5IG5vdCBiZSBpbml0aWFsaXplZCBhdCBh bGwuCisKKworW1lPQ1RPICMxMTczOF0KKworVXBzdHJlYW0tU3RhdHVzOiBQZW5kaW5nCisKK1Np Z25lZC1vZmYtYnk6IEp1cm8gQnlzdHJpY2t5IDxqdXJvLmJ5c3RyaWNreUBpbnRlbC5jb20+CisK K2RpZmYgLS1naXQgYS9saWJjcHAvbGV4LmMgYi9saWJjcHAvbGV4LmMKKy0tLSBhL2xpYmNwcC9s ZXguYworKysrIGIvbGliY3BwL2xleC5jCitAQCAtMzIyOSwxMSArMzIyOSwyNyBAQAorICAgICBz cGVsbF9pZGVudDoKKyAgICAgY2FzZSBTUEVMTF9JREVOVDoKKyAgICAgICBpZiAoZm9yc3RyaW5n KQorLQl7CistCSAgbWVtY3B5IChidWZmZXIsIE5PREVfTkFNRSAodG9rZW4tPnZhbC5ub2RlLnNw ZWxsaW5nKSwKKy0JCSAgTk9ERV9MRU4gKHRva2VuLT52YWwubm9kZS5zcGVsbGluZykpOworLQkg IGJ1ZmZlciArPSBOT0RFX0xFTiAodG9rZW4tPnZhbC5ub2RlLnNwZWxsaW5nKTsKKy0JfQorKyAg ICAgICAgeworKyAgICAgICAgICBpZiAodG9rZW4tPnR5cGUgPT0gQ1BQX05BTUUpCisrICAgICAg ICAgICAgeworKyAgICAgICAgICAgICAgbWVtY3B5IChidWZmZXIsIE5PREVfTkFNRSAodG9rZW4t PnZhbC5ub2RlLnNwZWxsaW5nKSwKKysgICAgICAgICAgICAgICAgICAgIE5PREVfTEVOICh0b2tl bi0+dmFsLm5vZGUuc3BlbGxpbmcpKTsKKysgICAgICAgICAgICAgIGJ1ZmZlciArPSBOT0RFX0xF TiAodG9rZW4tPnZhbC5ub2RlLnNwZWxsaW5nKTsKKysgICAgICAgICAgICAgIGJyZWFrOworKyAg ICAgICAgICAgIH0KKysgICAgICAgICAgLyogTkFNRURfT1AsIGNhbm5vdCB1c2Ugbm9kZS5zcGVs bGluZyAqLworKyAgICAgICAgICBpZiAodG9rZW4tPmZsYWdzICYgTkFNRURfT1ApCisrICAgICAg ICAgICAgeworKyAgICAgICAgICAgICAgY29uc3QgY2hhciAqc3RyID0gY3BwX25hbWVkX29wZXJh dG9yMm5hbWUgKHRva2VuLT50eXBlKTsKKysgICAgICAgICAgICAgIGlmIChzdHIpCisrICAgICAg ICAgICAgICAgIHsKKysgICAgICAgICAgICAgICAgICBzaXplX3QgbGVuID0gc3RybGVuKHN0cik7 CisrICAgICAgICAgICAgICAgICAgbWVtY3B5KGJ1ZmZlciwgc3RyLCBsZW4pOworKyAgICAgICAg ICAgICAgICAgIGJ1ZmZlciArPSBsZW47CisrICAgICAgICAgICAgICAgIH0KKysgICAgICAgICAg ICAgIGJyZWFrOworKyAgICAgICAgICAgIH0KKysgICAgICAgIH0KKyAgICAgICBlbHNlCisgCWJ1 ZmZlciA9IF9jcHBfc3BlbGxfaWRlbnRfdWNucyAoYnVmZmVyLCB0b2tlbi0+dmFsLm5vZGUubm9k ZSk7CisgICAgICAgYnJlYWs7Ci0tIAoyLjcuNAoK