<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>11757</bug_id>
          
          <creation_ts>2017-07-05 07:08:33 +0000</creation_ts>
          <short_desc>selftests: do not touch existing build artifacts</short_desc>
          <delta_ts>2017-11-07 15:21:05 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>IoT Reference OS Kit</product>
          <component>intel-iot-refkit-tools</component>
          <version>2.4</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.5 M1</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Patrick Ohly">patrick.ohly</reporter>
          <assigned_to name="Patrick Ohly">patrick.ohly</assigned_to>
          
          
          <qa_contact name="yeoh ee peng">ee.peng.yeoh</qa_contact>
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>74762</commentid>
    <comment_count>0</comment_count>
    <who name="Patrick Ohly">patrick.ohly</who>
    <bug_when>2017-07-05 07:08:33 +0000</bug_when>
    <thetext>At the moment, some tests rebuild &quot;normal&quot; recipes with different settings:
- system update: refkit-image-common
- secure boot: ovmf (and others?)

This causes extra work in the CI testing because:
- system update runs and modifies refkit-image-common
- image installer needs to rebuild the original refkit-image-common,
  which wouldn&apos;t be needed if system update hadn&apos;t modified it

Changing the test order could be used to work around that but that is merely a workaround and doesn&apos;t work in practice because of bug #11756.

All tests should be written so that they either use the original recipes unmodified, or use their own test-specific recipes. For example, system update should have its own refkit-system-update.bb which just includes refkit-image-common.bb.

We probably need some infrastructure for creating test recipes. OE-core does it via meta-selftest, but that doesn&apos;t scale to other layers.

Another aspect involves ovmf: running a virtual machine with &quot;runqemu ovmf&quot; potentially modifies the ovmf.qcow2 file when allowing image writes to persist. Each test which needs to do that (image installer!) should make a copy of ovmf.qcow2 first and use the copy.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>74763</commentid>
    <comment_count>1</comment_count>
    <who name="Patrick Ohly">patrick.ohly</who>
    <bug_when>2017-07-05 07:09:37 +0000</bug_when>
    <thetext>I&apos;ve filed this because I don&apos;t want to forget about it, and because perhaps someone else than myself can work on this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>74921</commentid>
    <comment_count>2</comment_count>
    <who name="Patrick Ohly">patrick.ohly</who>
    <bug_when>2017-07-11 14:10:17 +0000</bug_when>
    <thetext>Partly fixed by https://github.com/intel/intel-iot-refkit/pull/238/commits/01641909eaafc51941cec27ef2d830582a0f886c (for system update).

Let&apos;s re-evaluate the impact on the current testing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>78027</commentid>
    <comment_count>3</comment_count>
    <who name="Patrick Ohly">patrick.ohly</who>
    <bug_when>2017-11-07 15:21:05 +0000</bug_when>
    <thetext>I believe this has been addressed sufficiently well.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>