11790 2017-07-14 12:56:45 +0000 WIC creates wrong partition number 2018-02-28 12:32:02 +0000 1 1 7 Build System, Metadata & Runtime OE-Core Scripts and Tools 2.4 x86 Multiple RESOLVED FIXED Medium normal 2.4 M2 1 fink eduard.bartosh kai.ruhnau ross.burton --- --- Don't know oldest_to_newest 75032 0 fink 2017-07-14 12:56:45 +0000 Hi, I could of course be wrong, but with the wks file here: part /boot --source bootimg-partition --ondisk mmcblk0 --fstype=vfat --label boot --active --align 4096 --size 40 part / --source rootfs --ondisk mmcblk0 --fstype=ext4 --label root_a --align 4096 --size 300 part /rescue --ondisk mmcblk0 --fstype=ext4 --label root_b --align 4096 --size 300 part /usr/local --ondisk mmcblk0 --fstype=ext4 --label userdata --align 4096 --size 100 I get the following entries in /dev: sh-4.3# ls -l /dev/mmc* brw-rw---- 1 root disk 179, 0 Jul 11 07:18 /dev/mmcblk0 brw-rw---- 1 root disk 179, 1 Jul 11 07:18 /dev/mmcblk0p1 brw-rw---- 1 root disk 179, 2 Jul 11 07:18 /dev/mmcblk0p2 brw-rw---- 1 root disk 179, 3 Jul 11 07:18 /dev/mmcblk0p3 brw-rw---- 1 root disk 179, 4 Jul 11 07:18 /dev/mmcblk0p4 - which is as expected. The problem: My /etc/fstab looks like this: sh-4.3# cat /etc/fstab # stock fstab - you probably want to override this with a machine specific one /dev/root / auto defaults 1 1 proc /proc proc defaults 0 0 devpts /dev/pts devpts mode=0620,gid=5 0 0 tmpfs /run tmpfs mode=0755,nodev,nosuid,strictatime 0 0 tmpfs /var/volatile tmpfs defaults 0 0 # uncomment this if your device has a SD/MMC/Transflash slot #/dev/mmcblk0p1 /media/card auto defaults,sync,noauto 0 0 /dev/mmcblk0p3 /rescue ext4 defaults 0 0 /dev/mmcblk0p5 /usr/local ext4 defaults 0 0 Please look at the last line: I would expect that /etc/fstab would refer to /dev/mmcblk0p4 instead /dev/mmcblk0p5 for the /usr/local partition !?!? Is it me doing something wrong or is this a bug? BR RaceMouse of Denmark 75036 1 eduard.bartosh 2017-07-14 14:43:44 +0000 Looks like a bug to me. Can you try if it's fixed by this patch? diff --git a/scripts/lib/wic/plugins/imager/direct.py b/scripts/lib/wic/plugins/imager/direct.py index f2e6127..31d07ba 100644 --- a/scripts/lib/wic/plugins/imager/direct.py +++ b/scripts/lib/wic/plugins/imager/direct.py @@ -312,7 +312,7 @@ class PartitionedImage(): part.realnum = 0 else: realnum += 1 - if self.ptable_format == 'msdos' and realnum > 3: + if self.ptable_format == 'msdos' and realnum > 3 and len(partitions) > 4: part.realnum = realnum + 1 continue part.realnum = realnum BTW, you've specified Yocto version 2.3.2. this version doesn't exist yet, I believe. Can you tell which Yocto version do you use? 75048 2 fink 2017-07-14 19:24:10 +0000 (In reply to comment #1) > Looks like a bug to me. Can you try if it's fixed by this patch? > > diff --git a/scripts/lib/wic/plugins/imager/direct.py > b/scripts/lib/wic/plugins/imager/direct.py > index f2e6127..31d07ba 100644 > --- a/scripts/lib/wic/plugins/imager/direct.py > +++ b/scripts/lib/wic/plugins/imager/direct.py > @@ -312,7 +312,7 @@ class PartitionedImage(): > part.realnum = 0 > else: > realnum += 1 > - if self.ptable_format == 'msdos' and realnum > 3: > + if self.ptable_format == 'msdos' and realnum > 3 and > len(partitions) > 4: > part.realnum = realnum + 1 > continue > part.realnum = realnum > > Hi, Damn, you are fast !! :-) Well, it seems to have cured my issue. Now fstab correctly shows mmcblk0p4 on the right spot. From my point of view this can be closed. Again: Thanks a lot for the prompt reply :-) > BTW, you've specified Yocto version 2.3.2. this version doesn't exist yet, I > believe. Can you tell which Yocto version do you use? I-m using "YP Core - Pyro 2.3", so I assumed 2.3.2 was that. I was obviously wrong, then. Should I change the field into something else? Please advise :-) BR RaceMouse of Denmark 75054 3 eduard.bartosh 2017-07-17 07:53:12 +0000 Please review fixes for master, pyro and morty: http://lists.openembedded.org/pipermail/openembedded-core/2017-July/139683.html http://lists.openembedded.org/pipermail/openembedded-core/2017-July/139684.html http://lists.openembedded.org/pipermail/openembedded-core/2017-July/139685.html 75240 4 eduard.bartosh 2017-07-24 07:33:45 +0000 The fix has been merged into poky master. Commit id 8fb8a21b7d4f1fb69f0407f03fd5907d861f7d42 79626 5 kai.ruhnau 2018-02-28 12:32:02 +0000 I have just tested this patch on my ARM platform and it doesn't work as intended: The `len(partitions) > 4` also counts those with the --no-table flag so my u-boot "partition" is counted as well. Although there are only 4 real partitions in my wks, the fstab still ends up with mmcblk1p5 for the fourth partition.