<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>11831</bug_id>
          
          <creation_ts>2017-07-24 22:08:52 +0000</creation_ts>
          <short_desc>Proposal to replace/rewrite gitsm</short_desc>
          <delta_ts>2019-05-15 11:47:28 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>BitBake</product>
          <component>bitbake</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>Future</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Christopher Larson">kergoth</reporter>
          <assigned_to name="Mark Hatle">mark.hatle</assigned_to>
          <cc>mark.hatle</cc>
    
    <cc>mark.jonas</cc>
    
    <cc>poky.bs.watcher</cc>
    
    <cc>poky.watcher</cc>
    
    <cc>randy.macleod</cc>
    
    <cc>rebecca.swee.fun.chang</cc>
    
    <cc>sgw</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Yes (doc changes required)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>75265</commentid>
    <comment_count>0</comment_count>
    <who name="Christopher Larson">kergoth</who>
    <bug_when>2017-07-24 22:08:52 +0000</bug_when>
    <thetext>The current gitsm implementation is naive at best, broken at worst, and lets git itself do the fetching of the submodules, so we can&apos;t use our mirror tarballs or shallow tarballs for them, among other issues, such as the already reported issue with license.bbclass.

This issue is to track its replacement with a version that uses the bitbake fetcher to fetch the submodules recursively, and provides the urls of all the submodules to the metadata (likely stored as a member of the fetcher object, so anyone that needs it will have to isinstance() and grab it from there, as we can&apos;t get that information at parse time, only after the download()).

We can implement direct logic to do this, or we can try implementing a fetch helper to let git call back to us to do the repository fetch for it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>76238</commentid>
    <comment_count>1</comment_count>
    <who name="Christopher Larson">kergoth</who>
    <bug_when>2017-08-29 15:19:37 +0000</bug_when>
    <thetext>I&apos;ve created a thus-far working prototype of a rewritten gitsm that uses the bitbake fetcher for the submodules, and am currently testing it, mulling over how to address shallow support, and starting on thorough unit tests which don&apos;t all rely on network connectivity (we can construct the repositories we need on the fly, the way we do in the shallow unit tests). See https://gist.github.com/kergoth/9c163433c33cf883b21256459d743a98 for the current implementation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>82529</commentid>
    <comment_count>2</comment_count>
    <who name="Mark Jonas">mark.jonas</who>
    <bug_when>2018-12-18 09:41:24 +0000</bug_when>
    <thetext>My team is affected by this issue as well. We are looking forward to a solution. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>83816</commentid>
    <comment_count>3</comment_count>
    <who name="Mark Hatle">mark.hatle</who>
    <bug_when>2019-05-15 11:47:03 +0000</bug_when>
    <thetext>The gitsm fetcher has been refactored and rewritten to address this, locking and other issues.  The code changes went into the thud version (1.40).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>83817</commentid>
    <comment_count>4</comment_count>
    <who name="Mark Hatle">mark.hatle</who>
    <bug_when>2019-05-15 11:47:28 +0000</bug_when>
    <thetext>resolved</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>