<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>11842</bug_id>
          
          <creation_ts>2017-07-26 21:17:30 +0000</creation_ts>
          <short_desc>Setting NOHDD=1 and NOISO=1 no longer allows you to build a &gt;4GB image</short_desc>
          <delta_ts>2017-08-09 08:55:29 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>core</component>
          <version>2.4</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="brian avery">brian.avery</reporter>
          <assigned_to name="Ed Bartosh">eduard.bartosh</assigned_to>
          <cc>brian.avery</cc>
    
    <cc>eduard.bartosh</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
    
    <cc>randy.macleod</cc>
    
    <cc>sgw</cc>
    
    <cc>todor.minchev</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>75326</commentid>
    <comment_count>0</comment_count>
    <who name="brian avery">brian.avery</who>
    <bug_when>2017-07-26 21:17:30 +0000</bug_when>
    <thetext>Sometimes we need to make an x86 image that is greater than 4GB. On pyro the following works:
in local.conf:
IMAGE_ROOTFS_EXTRA_SPACE = &quot;10000000&quot;                                                                                                 NOHDD=&quot;1&quot;                                                                                                                             NOISO=&quot;1

In master , you now get the  4 GB error even with the above added to local.conf

A git bisect shows:
Summary: There was 1 WARNING message shown.                                                                                           
ec251ee98fdbf83bb7f36b179ba3978d7c31b66e is the first bad commit                                                                      
commit ec251ee98fdbf83bb7f36b179ba3978d7c31b66e                                                                                       
Author: Joshua Lock &lt;joshua.g.lock@intel.com&gt;                                                                                         
Date:   Wed Jul 12 20:08:21 2017 +0100                                                                                                
                                                                                                                                      
    x86-base: build only hddimg, rather than iso and hddimg, for x86 machines                                                         
                                                                                                                                      
    (From OE-Core rev: 1e05d488f9f09230d2f7cd3f43a385ad206066f8)                                                                      
                                                                                                                                      
    Signed-off-by: Joshua Lock &lt;joshua.g.lock@intel.com&gt;                                                                              
    Signed-off-by: Ross Burton &lt;ross.burton@intel.com&gt;                                                                                
    Signed-off-by: Richard Purdie &lt;richard.purdie@linuxfoundation.org&gt;                                                                
                                                                                                                                      
:040000 040000 aaa11bdbad4a90bbf9dcb400bb1110be30ab8d61 8d34cec7eb350d7f06f48a4ef888bc3efe73905e M      meta                          
bisect run success                                                                                                                    
bavery@echidna:~/work/esdk-menuconfig/poky$ git status                                                                                
HEAD detached at 1b11a65                                                                                                              
You are currently bisecting, started from branch &apos;master&apos;.                                                                            
  (use &quot;git bisect reset&quot; to get back to the original branch)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75327</commentid>
    <comment_count>1</comment_count>
    <who name="brian avery">brian.avery</who>
    <bug_when>2017-07-26 21:18:12 +0000</bug_when>
    <thetext>adding todor since he ran across this first.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75333</commentid>
    <comment_count>2</comment_count>
    <who name="Joshua Lock">joshuagloe</who>
    <bug_when>2017-07-27 11:01:51 +0000</bug_when>
    <thetext>The logic of build_live() in image.bbclass may be incorrect. 

It&apos;s overriding the NOISO and NOHDD settings when resp. iso and hddimg are in IMAGE_FSTYPES but doesn&apos;t do so when live is in IMAGE_FSTYPES.

It&apos;s not clear to me on first read through whether build_live() should be setting the NOISO and NOHDD values in d, or just using their value to determine its own return value.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75384</commentid>
    <comment_count>3</comment_count>
    <who name="Ed Bartosh">eduard.bartosh</who>
    <bug_when>2017-07-28 11:14:18 +0000</bug_when>
    <thetext>I was able to produce more than 9.6Gb ext4 image on master (commit id 3c1c4ceaa470957fe5633d65215f165a38d61be7) with these settings in local.conf:

NOHDD=&quot;1&quot;
NOISO=&quot;1&quot;
IMAGE_ROOTFS_EXTRA_SPACE = &quot;10000000&quot;

$ ls -lh tmp/deploy/images/qemux86-64/
total 28M
lrwxrwxrwx 2 ed users   76 Jul 28 13:00 bzImage -&gt; bzImage--4.10.17+git0+e92bd55409_6648a34e00-r0-qemux86-64-20170728093839.bin
-rw-r--r-- 2 ed users 6.7M Jul 28 13:00 bzImage--4.10.17+git0+e92bd55409_6648a34e00-r0-qemux86-64-20170728093839.bin
lrwxrwxrwx 2 ed users   76 Jul 28 13:00 bzImage-qemux86-64.bin -&gt; bzImage--4.10.17+git0+e92bd55409_6648a34e00-r0-qemux86-64-20170728093839.bin
-rw-r--r-- 2 ed users 1.4K Jul 28 13:34 core-image-minimal-qemux86-64-20170728103327.qemuboot.conf
-rw-r--r-- 2 ed users 9.6G Jul 28 13:34 core-image-minimal-qemux86-64-20170728103327.rootfs.ext4
-rw-r--r-- 2 ed users  905 Jul 28 13:34 core-image-minimal-qemux86-64-20170728103327.rootfs.manifest
-rw-r--r-- 2 ed users 3.2M Jul 28 13:34 core-image-minimal-qemux86-64-20170728103327.rootfs.tar.bz2
-rw-r--r-- 1 ed users  89K Jul 28 13:34 core-image-minimal-qemux86-64-20170728103327.testdata.json
lrwxrwxrwx 2 ed users   56 Jul 28 13:34 core-image-minimal-qemux86-64.ext4 -&gt; core-image-minimal-qemux86-64-20170728103327.rootfs.ext4
lrwxrwxrwx 2 ed users   60 Jul 28 13:34 core-image-minimal-qemux86-64.manifest -&gt; core-image-minimal-qemux86-64-20170728103327.rootfs.manifest
lrwxrwxrwx 2 ed users   58 Jul 28 13:34 core-image-minimal-qemux86-64.qemuboot.conf -&gt; core-image-minimal-qemux86-64-20170728103327.qemuboot.conf
lrwxrwxrwx 2 ed users   59 Jul 28 13:34 core-image-minimal-qemux86-64.tar.bz2 -&gt; core-image-minimal-qemux86-64-20170728103327.rootfs.tar.bz2
lrwxrwxrwx 1 ed users   58 Jul 28 13:34 core-image-minimal-qemux86-64.testdata.json -&gt; core-image-minimal-qemux86-64-20170728103327.testdata.json
-rw-r--r-- 2 ed users 6.1M Jul 28 13:00 modules--4.10.17+git0+e92bd55409_6648a34e00-r0-qemux86-64-20170728093839.tgz
lrwxrwxrwx 2 ed users   76 Jul 28 13:00 modules-qemux86-64.tgz -&gt; modules--4.10.17+git0+e92bd55409_6648a34e00-r0-qemux86-64-20170728093839.tgz

Please, clarify which image you&apos;re trying to produce and which error did you get. Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75387</commentid>
    <comment_count>4</comment_count>
    <who name="Ed Bartosh">eduard.bartosh</who>
    <bug_when>2017-07-28 12:29:00 +0000</bug_when>
    <thetext>Reproduced on genericx86 machine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75388</commentid>
    <comment_count>5</comment_count>
    <who name="Ed Bartosh">eduard.bartosh</who>
    <bug_when>2017-07-28 13:10:07 +0000</bug_when>
    <thetext>NOHDD and NOISO variables seem to influence only &apos;live&apos; image build. Their purpose is to disable generation of hdd or iso only if live image build is requested. By default both hdd and iso are generated if &apos;live&apos; is in IMAGE_FSTYPES. 

In this particular case hddimg image is explicitly requested, but live image is not, so NOHDD=1 has not effect.

I&apos;d suggest this change to make user experience less confusing:
diff --git a/meta/conf/machine/include/x86-base.inc b/meta/conf/machine/include/x86-base.inc
index a29641a..bc0c27b 100644
--- a/meta/conf/machine/include/x86-base.inc
+++ b/meta/conf/machine/include/x86-base.inc
@@ -10,7 +10,8 @@ MACHINE_FEATURES += &quot;screen keyboard pci usbhost ext2 ext3 x86 \
 
 MACHINE_EXTRA_RRECOMMENDS += &quot;kernel-modules&quot;
 
-IMAGE_FSTYPES ?= &quot;hddimg&quot;
+IMAGE_FSTYPES ?= &quot;live&quot;
+NOISO ?= &quot;1&quot;
 
 KERNEL_IMAGETYPE ?= &quot;bzImage&quot;


It produces the same result (only hddimg is built), but allows usage of NOHDD and NOISO variables.

Please, let me know if this fixes this issue for you and I&apos;ll send this patch for review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75399</commentid>
    <comment_count>6</comment_count>
    <who name="Todor Minchev">todor.minchev</who>
    <bug_when>2017-07-28 17:29:45 +0000</bug_when>
    <thetext>+1. The patch looks good and does what it should.

@ed - are you going to send it upstream?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75453</commentid>
    <comment_count>7</comment_count>
    <who name="Ed Bartosh">eduard.bartosh</who>
    <bug_when>2017-07-30 10:54:58 +0000</bug_when>
    <thetext>please review: http://lists.openembedded.org/pipermail/openembedded-core/2017-July/140287.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75760</commentid>
    <comment_count>8</comment_count>
    <who name="Ed Bartosh">eduard.bartosh</who>
    <bug_when>2017-08-09 08:55:29 +0000</bug_when>
    <thetext>The fix has been merged into poky master. Commit id: b8cb2bb17508020899a5ffaa29aee941922d68e0</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>