<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>11949</bug_id>
          
          <creation_ts>2017-08-18 16:20:04 +0000</creation_ts>
          <short_desc>qemu-2.10-rc2 build error (patch failed)</short_desc>
          <delta_ts>2017-09-12 04:53:43 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>IoT Reference OS Kit</product>
          <component>intel-iot-refkit-tools</component>
          <version>2.4</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>major</bug_severity>
          <target_milestone>2.4 M4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Juro Bystricky">juro.bystricky</reporter>
          <assigned_to name="Mikko Ylinen">mikko.ylinen</assigned_to>
          <cc>jku</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
    
    <cc>mikko.ylinen</cc>
          
          <qa_contact name="yeoh ee peng">ee.peng.yeoh</qa_contact>
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>75993</commentid>
    <comment_count>0</comment_count>
    <who name="Juro Bystricky">juro.bystricky</who>
    <bug_when>2017-08-18 16:20:04 +0000</bug_when>
    <thetext>As seen in Autobuilder
https://autobuilder.yocto.io/builders/nightly-refkit/builds/122/steps/BuildImages/logs/stdio

ERROR: qemu-native-2.10.0-rc2-r0 do_patch: Command Error: &apos;quilt --quiltrc /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-refkit/build/build/tmp-glibc/work/x86_64-linux/qemu-native/2.10.0-rc2-r0/recipe-sysroot-native/etc/quiltrc push&apos; exited with 0  Output:
Applying patch 0004-Add-support-for-VM-suspend-resume-for-TPM-TIS-v2.9.patch
patching file hw/tpm/tpm_passthrough.c
Hunk #1 FAILED at 34.
Hunk #2 succeeded at 47 with fuzz 1 (offset -2 lines).
Hunk #3 FAILED at 80.
Hunk #4 succeeded at 350 with fuzz 1 (offset 43 lines).
Hunk #5 FAILED at 365.
Hunk #6 FAILED at 399.
Hunk #7 FAILED at 471.
Hunk #8 FAILED at 493.
Hunk #9 succeeded at 411 (offset -195 lines).
Hunk #10 FAILED at 666.
Hunk #11 FAILED at 683.
Hunk #12 FAILED at 790.
Hunk #13 FAILED at 826.
10 out of 13 hunks FAILED -- rejects in file hw/tpm/tpm_passthrough.c
patching file hw/tpm/tpm_tis.c
Hunk #1 FAILED at 368.
Hunk #2 succeeded at 403 with fuzz 1 (offset -12 lines).
Hunk #3 succeeded at 1020 (offset -12 lines).
1 out of 3 hunks FAILED -- rejects in file hw/tpm/tpm_tis.c
patching file hw/tpm/tpm_tis.h
patching file hw/tpm/tpm_util.c
patching file hw/tpm/tpm_util.h
patching file include/sysemu/tpm_backend.h
Patch 0004-Add-support-for-VM-suspend-resume-for-TPM-TIS-v2.9.patch does not apply (enforce with -f)
ERROR: qemu-native-2.10.0-rc2-r0 do_patch: Function failed: patch_do_patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>75994</commentid>
    <comment_count>1</comment_count>
    <who name="Juro Bystricky">juro.bystricky</who>
    <bug_when>2017-08-18 16:24:49 +0000</bug_when>
    <thetext>BTW, observed with refkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>76050</commentid>
    <comment_count>2</comment_count>
    <who name="Jussi Kukkonen">jku</who>
    <bug_when>2017-08-22 12:15:47 +0000</bug_when>
    <thetext>Could this be an issue with some patch from another layer? The oe-core patching looks kind of unlikely to fail.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>76051</commentid>
    <comment_count>3</comment_count>
    <who name="Jussi Kukkonen">jku</who>
    <bug_when>2017-08-22 12:33:30 +0000</bug_when>
    <thetext>meta-refkit-core has this:


SRC_URI_remove_df-refkit-config = &quot; \
    file://0001-Provide-support-for-the-CUSE-TPM.patch \
    file://0002-Introduce-condition-to-notify-waiters-of-completed-c.patch \
    file://0003-Introduce-condition-in-TPM-backend-for-notification.patch \
    file://0004-Add-support-for-VM-suspend-resume-for-TPM-TIS.patch \
&quot;


That last should probably be
 
    file://0004-Add-support-for-VM-suspend-resume-for-TPM-TIS-v2.9.patch \</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>76057</commentid>
    <comment_count>4</comment_count>
    <who name="Juro Bystricky">juro.bystricky</who>
    <bug_when>2017-08-22 14:59:15 +0000</bug_when>
    <thetext>yes, this is exactly the root of the problem.
The patch needed to be modified for QEMU 2.9 +.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>76110</commentid>
    <comment_count>5</comment_count>
    <who name="Mikko Ylinen">mikko.ylinen</who>
    <bug_when>2017-08-24 03:16:48 +0000</bug_when>
    <thetext>I have the fix available in https://github.com/intel/intel-iot-refkit/pull/296</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>