<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>12091</bug_id>
          
          <creation_ts>2017-09-15 08:09:45 +0000</creation_ts>
          <short_desc>wic support more mounting option</short_desc>
          <delta_ts>2018-10-09 06:04:37 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>Scripts and Tools</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>4.99</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Diego">diego.ml</reporter>
          <assigned_to name="Kevin Hao">kexin.hao</assigned_to>
          <cc>kexin.hao</cc>
    
    <cc>ross.burton</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Yes (doc changes required)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>76884</commentid>
    <comment_count>0</comment_count>
    <who name="Diego">diego.ml</who>
    <bug_when>2017-09-15 08:09:45 +0000</bug_when>
    <thetext>Currently wic supports the &quot;--ondisk&quot; parameter to have fstab entries automatically generated.
This though is quite problematic when the there are multiple disks on the same subsystem, think of a board with multiple SD card readers and / or eMMC: the same image could be put in mmcblk0, mmcblk1 or mmcblk2. Same goes for USB / Sata disk on sda, sdb, etc.

Alternative mounting ways are now supported (by label, by gpt-label, by UUID):
https://wiki.archlinux.org/index.php/Fstab#Identifying_filesystems

It would be easier if wic could give more freedom to the developer, maybe allowing him to just freely enter the string for the &lt;device&gt; field for the fstab.

Think of:
wic ... --device=&quot;LABEL=/recovery&quot; ...

Afterall --ondisk is not currently used that much, it&apos;s just ignored for boot and root partitions.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>81351</commentid>
    <comment_count>1</comment_count>
    <who name="Kevin Hao">kexin.hao</who>
    <bug_when>2018-08-15 02:45:03 +0000</bug_when>
    <thetext>Hi Diego,

Have you tried &quot;--use-uuid&quot; parameter?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>81467</commentid>
    <comment_count>2</comment_count>
    <who name="Diego">diego.ml</who>
    <bug_when>2018-08-31 13:53:54 +0000</bug_when>
    <thetext>(In reply to comment #1)
&gt; Hi Diego,
&gt; 
&gt; Have you tried &quot;--use-uuid&quot; parameter?

IIRC I tried but it didn&apos;t work, and I haven&apos;t investigated exactly why.

Nonetheless label or gpt-label support would be nice anyway.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>81481</commentid>
    <comment_count>3</comment_count>
    <who name="Kevin Hao">kexin.hao</who>
    <bug_when>2018-09-02 09:01:32 +0000</bug_when>
    <thetext>(In reply to comment #2)
&gt; (In reply to comment #1)
&gt; &gt; Hi Diego,
&gt; &gt; 
&gt; &gt; Have you tried &quot;--use-uuid&quot; parameter?
&gt; 
&gt; IIRC I tried but it didn&apos;t work, and I haven&apos;t investigated exactly why.

As I know several boards supported by meta-yocto-bsp use the &quot;--use-uuid&quot; parameter, all of them work pretty well. Could you provide more details about  the scenario you use this parameter?

&gt; 
&gt; Nonetheless label or gpt-label support would be nice anyway.

There already has the support for the label. Please see the &quot;--label&quot; parameter.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>81489</commentid>
    <comment_count>4</comment_count>
    <who name="Diego">diego.ml</who>
    <bug_when>2018-09-03 12:01:19 +0000</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #2)
&gt; &gt; (In reply to comment #1)
&gt; &gt; &gt; Hi Diego,
&gt; &gt; &gt; 
&gt; &gt; &gt; Have you tried &quot;--use-uuid&quot; parameter?
&gt; &gt; 
&gt; &gt; IIRC I tried but it didn&apos;t work, and I haven&apos;t investigated exactly why.
&gt; 
&gt; As I know several boards supported by meta-yocto-bsp use the &quot;--use-uuid&quot;
&gt; parameter, all of them work pretty well. Could you provide more details
&gt; about  the scenario you use this parameter?

I think I last tested when I originally reported this issue, so ~1 year ago, if I remember correctly no fstab entry was created.
Glad it works for some boards, I&apos;ll give it another shot and open a proper bug issue if it still doesn&apos;t work for me.

&gt; 
&gt; &gt; 
&gt; &gt; Nonetheless label or gpt-label support would be nice anyway.
&gt; 
&gt; There already has the support for the label. Please see the &quot;--label&quot;
&gt; parameter.

The &apos;--label&apos; parameter doesn&apos;t create an fstab entry as far as I know, so it is  not related to what this feature request issue is about.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>81490</commentid>
    <comment_count>5</comment_count>
    <who name="Diego">diego.ml</who>
    <bug_when>2018-09-03 12:13:46 +0000</bug_when>
    <thetext>(In reply to comment #4)
&gt; (In reply to comment #3)
&gt; &gt; (In reply to comment #2)
&gt; &gt; &gt; (In reply to comment #1)
&gt; &gt; &gt; &gt; Hi Diego,
&gt; &gt; &gt; &gt; 
&gt; &gt; &gt; &gt; Have you tried &quot;--use-uuid&quot; parameter?
&gt; &gt; &gt; 
&gt; &gt; &gt; IIRC I tried but it didn&apos;t work, and I haven&apos;t investigated exactly why.
&gt; &gt; 
&gt; &gt; As I know several boards supported by meta-yocto-bsp use the &quot;--use-uuid&quot;
&gt; &gt; parameter, all of them work pretty well. Could you provide more details
&gt; &gt; about  the scenario you use this parameter?
&gt; 
&gt; I think I last tested when I originally reported this issue, so ~1 year ago,
&gt; if I remember correctly no fstab entry was created.
&gt; Glad it works for some boards, I&apos;ll give it another shot and open a proper
&gt; bug issue if it still doesn&apos;t work for me.
&gt; 

I think this is the fix that was not available at the time:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=7707961e9f95429044f8de5ca30bfefc797cf371</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>81562</commentid>
    <comment_count>6</comment_count>
    <who name="Kevin Hao">kexin.hao</who>
    <bug_when>2018-09-14 01:30:35 +0000</bug_when>
    <thetext>I have added the support to use the label in the /etc/fstab, please see the commit:
commit 821711bf2edc
Author: Kevin Hao &lt;kexin.hao@windriver.com&gt;
Date:   Wed Sep 12 08:44:46 2018 +0800

    wic: Introduce the --use-label partition parameter
    
    We can use this parameter to make the wic use the label to name a
    partition in /etc/fstab.
    
    (From OE-Core rev: 51638edaa00befaed58e2def255d46ae44d9234f)
    
    Signed-off-by: Kevin Hao &lt;kexin.hao@windriver.com&gt;
    Reviewed-by: Tom Rini &lt;trini@konsulko.com&gt;
    Signed-off-by: Richard Purdie &lt;richard.purdie@linuxfoundation.org&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>81783</commentid>
    <comment_count>7</comment_count>
    <who name="Diego">diego.ml</who>
    <bug_when>2018-10-09 06:04:37 +0000</bug_when>
    <thetext>(In reply to comment #6)
&gt; I have added the support to use the label in the /etc/fstab, please see the
&gt; commit:

Thanks. It works fine for me.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>