<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>12383</bug_id>
          
          <creation_ts>2017-11-27 19:08:14 +0000</creation_ts>
          <short_desc>qemu inclusion of kernel modules is inconsistent.</short_desc>
          <delta_ts>2018-08-02 10:22:47 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>core</component>
          <version>2.4</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.6 M3</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="brian avery">brian.avery</reporter>
          <assigned_to name="Maxin B. John">maxin.john</assigned_to>
          <cc>california.l.sullivan</cc>
    
    <cc>maxin.john</cc>
    
    <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
    
    <cc>randy.macleod</cc>
    
    <cc>ross.burton</cc>
    
    <cc>todor.minchev</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Yes (doc changes required)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>78356</commentid>
    <comment_count>0</comment_count>
    <who name="brian avery">brian.avery</who>
    <bug_when>2017-11-27 19:08:14 +0000</bug_when>
    <thetext>qemumips and qemumips64 both have the line
MACHINE_EXTRA_RRECOMMENDS = &quot; kernel-modules&quot;  

genericx86* pulls this in by including x86-base.inc.

Unfortunately, the other qemu machiens, including x86*, fail to pull the kernel modules into the image.  If you are trying to test something that relies on them, and have specifically built core-image-base or core-image-sato in order to make sure they are there; that would cause a great deal of confusion.

The inclusion of kernel-modules should be consistent. My vote would be to add the 
MACHINE_EXTRA_RRECOMMENDS = &quot; kernel-modules&quot; 
across the board.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>78357</commentid>
    <comment_count>1</comment_count>
    <who name="brian avery">brian.avery</who>
    <bug_when>2017-11-27 19:08:43 +0000</bug_when>
    <thetext>+cal,todor</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>78423</commentid>
    <comment_count>2</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2017-11-30 16:16:58 +0000</bug_when>
    <thetext>I think Randy changed the milestone by mistake</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>78432</commentid>
    <comment_count>3</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2017-11-30 16:56:40 +0000</bug_when>
    <thetext>Indeed. Thanks for catching that Ross.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>80368</commentid>
    <comment_count>4</comment_count>
    <who name="Maxin B. John">maxin.john</who>
    <bug_when>2018-04-22 09:50:08 +0000</bug_when>
    <thetext>patch sent to oe-core mailing list:
http://lists.openembedded.org/pipermail/openembedded-core/2018-April/150098.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>80551</commentid>
    <comment_count>5</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2018-05-10 08:28:41 +0000</bug_when>
    <thetext>Richard feels that adding kernel-modules isn&apos;t the best idea as it would hide kernel module dependencies.

So:
1) use git blame to identify if there is a good reason qemumips pulls in every module by recommending kernel-modules, and if it is for a specific module then make that a recommends or depends as appropriate
2) Remove kernel-module from recommends and verify images still work.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>81221</commentid>
    <comment_count>6</comment_count>
    <who name="Maxin B. John">maxin.john</who>
    <bug_when>2018-08-02 10:22:47 +0000</bug_when>
    <thetext>https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=fae1ccdcf5696770774679bcbedd083ad777b039</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>