<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>12397</bug_id>
          
          <creation_ts>2017-12-05 18:14:51 +0000</creation_ts>
          <short_desc>patch_do_patch fails to detect patch failure</short_desc>
          <delta_ts>2017-12-07 16:01:21 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>Meta-yocto</product>
          <component>meta-yocto</component>
          <version>unspecified</version>
          <rep_platform>Other</rep_platform>
          <op_sys>arm</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>9982</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.5 M2</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Thomas Epperson">thomas.epperson</reporter>
          <assigned_to name="Ross Burton">ross.burton</assigned_to>
          <cc>poky.bs.watcher</cc>
    
    <cc>poky.watcher</cc>
    
    <cc>thomas.epperson</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Don&apos;t know</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>78519</commentid>
    <comment_count>0</comment_count>
    <who name="Thomas Epperson">thomas.epperson</who>
    <bug_when>2017-12-05 18:14:51 +0000</bug_when>
    <thetext>I&apos;m using the krogoth branch of yocto poky.
My manifest is https://github.com/uglyoldbob/yocto-manifest

patch_do_patch tells me that python function do_patch finished. No error appears in the log.do_patch

My recipe is https://github.com/uglyoldbob/oe-custom/blob/verdex/recipes-bsp/u-boot/u-boot-verdex_1.2.0.bb

A scan through tmp/work/armv5e-poky-linux-gnueabi/u-boot-verdex/1.2.0-r7/git shows me the patch has not changed any files.

Running &quot;bitbake -f -c patch u-boot-verdex&quot; properly applies the patch and actually modifies the source code.

Running the resulting u-boot binary reflects the source code as it appears in tmp/work/armv5e-poky-linux-gnueabi/u-boot-verdex/1.2.0-r7/git, both when the patch is actually applied vs not applied.

Here is a rundown of what I see.
https://pastebin.com/BNuCavSP

Modifying or even removing the &quot;FILESEXTRAPATHS_prepend&quot; line has no effect.
Adding &quot;;branch=master&quot; to the git line also has no effect.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>78556</commentid>
    <comment_count>1</comment_count>
    <who name="Thomas Epperson">thomas.epperson</who>
    <bug_when>2017-12-06 18:38:21 +0000</bug_when>
    <thetext>It seems the patches folder present in the SRC_URI git repository (https://github.com/ashcharles/verdex-uboot/tree/master/patches) is responsible for causing the problem.
Quilt tries to remove all patches, removes none, then tries to apply the non-existant add-gumstix-board-to-build.patch, notices it does not exist, and instead applies an empty patch and then returns success.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>78570</commentid>
    <comment_count>2</comment_count>
    <who name="Thomas Epperson">thomas.epperson</who>
    <bug_when>2017-12-07 14:28:04 +0000</bug_when>
    <thetext>I have found a potential fix.
I have a pastebin of a patch

https://pastebin.com/wRz3D8zZ</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>78589</commentid>
    <comment_count>3</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2017-12-07 16:01:21 +0000</bug_when>
    <thetext>The proper fix is to stop using $S/patches as a holding place for patches, so marking this as a duplicate.

*** This bug has been marked as a duplicate of bug 9982 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>