<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>12628</bug_id>
          
          <creation_ts>2018-03-26 14:35:46 +0000</creation_ts>
          <short_desc>MACHINE_EXTRA_RRECOMMEND syntax not the best</short_desc>
          <delta_ts>2018-05-17 11:11:29 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>BSPs</product>
          <component>bsps-configuration</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.5 M4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Scott Rifenbark">srifenbark</reporter>
          <assigned_to name="Stephano Cetola">stephano</assigned_to>
          <cc>randy.macleod</cc>
    
    <cc>richard.purdie</cc>
    
    <cc>stephano</cc>
    
    <cc>yp.bsp.watcher</cc>
    
    <cc>yp.watcher</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>79992</commentid>
    <comment_count>0</comment_count>
    <who name="Scott Rifenbark">srifenbark</who>
    <bug_when>2018-03-26 14:35:46 +0000</bug_when>
    <thetext>The machine configuration file for the BeagleBone BSP (https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf) has the following statement:

MACHINE_EXTRA_RRECOMMENDS = &quot; kernel-modules kernel-devicetree&quot;

This should probably be the following:

MACHINE_EXTRA_RRECOMMENDS += &quot;kernel-modules kernel-devicetree&quot;

The reason is because the string wants to use a space at the front, which assumes the value of the string is being appended to any current value of MACHINE_EXTRA_RRECOMMENDS. The &quot;+=&quot; operator will insert its own space when appending the string.  Another way would be to do the following:

MACHINE_EXTRA_RRECOMMENDS .= &quot; kernel-modules kernel-devicetree&quot;

I know this probably doesn&apos;t make much difference, but I am providing a detailed description of this particular machine configuration file in the BSP manual and it looks pretty poor.

Scott</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>80606</commentid>
    <comment_count>1</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2018-05-17 07:55:15 +0000</bug_when>
    <thetext>http://git.yoctoproject.org/cgit.cgi/meta-yocto/commit/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf?id=36d20206b73d2efbf72353030b786483eb8749b6</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>80607</commentid>
    <comment_count>2</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2018-05-17 07:56:01 +0000</bug_when>
    <thetext>Fixed in the above commit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>80611</commentid>
    <comment_count>3</comment_count>
    <who name="Scott Rifenbark">srifenbark</who>
    <bug_when>2018-05-17 11:11:29 +0000</bug_when>
    <thetext>Also fixed in the manual now... 

Thanks
Scott

https://www.yoctoproject.org/docs/2.5/bsp-guide/bsp-guide.html#bsp-machine-configuration-example</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>