12631 2018-03-28 08:04:37 +0000 Go 1.10 generates invalid code 2018-10-29 15:17:40 +0000 1 1 7 Build System, Metadata & Runtime OE-Core devtools / tool chain 2.5 x86 Multiple RESOLVED FIXED Medium+ critical 2.6 M4 1 otavio raj.khem matt meta.mr.watcher meta.watcher otavio raj.khem richard.purdie ross.burton stephano --- Regression (Used to work) No (bug/feature does not impact docs) oldest_to_newest 80004 0 otavio 2018-03-28 08:04:37 +0000 The following code: <pre> package main import ( "net/http" "github.com/sirupsen/logrus" ) func main() { logrus.Info("starting") client := &http.Client{} r, _ := http.NewRequest("GET", "https://google.com", nil) client.Do(r) logrus.Info("started") } </pre> Works when using 1.9.4 and fails with 1.10. However, when using Go from our host to cross build it for same target, it works fine. 80005 1 juro.bystricky 2018-03-28 08:27:01 +0000 This bug is filed under "BuildAppliance". Does it mean the problem is observed in BuildAppliance? 80006 2 otavio 2018-03-28 08:57:46 +0000 (In reply to comment #1) > This bug is filed under "BuildAppliance". Does it mean the problem is > observed in BuildAppliance? I chose runtime. 80007 3 matt 2018-03-28 09:49:50 +0000 I tested the sample code, and it worked fine for me, but I may have been building it differently than Otavio. MACHINE: qemuarm - created recipe for the sample code - added recipe for logrus, set DEPENDS in recipe for sample code to point to it If you're using glide or godep or some other Go dependency manager, though, you might be running into an issue with the change in how go1.10 handles build flags. Used to be that if you used the `-linkshared' build flag, the go tool would automatically propagate that build modifier to all packages built. With go1.10, it now only applies that modifier to packages explicitly listed on the command line. So go.bbclass might need to be changed to add "-gcflags=all:linkshared -asmflags=all:linkshared" to GOBUILDFLAGS when building against the shared runtime, so that any dependencies being handled internally by godep/glide/go get/etc. get compiled with the correct matching settings. 80008 4 raj.khem 2018-03-28 09:53:25 +0000 I think this seems a good thing to do. I have few apps which are using other go build systems. Matt can you post this change ? 80009 5 matt 2018-03-28 09:59:14 +0000 Yes, I'll work up a patch for that change. Hopefully Otavio can verify that it actually helps with this particular issue. 80010 6 otavio 2018-03-28 10:56:34 +0000 The suggested change does not build. Log data follows: | DEBUG: Executing shell function do_compile | invalid value "all:linkshared" for flag -gcflags: missing =<value> in <pattern>=<value> | usage: list [-e] [-f format] [-json] [build flags] [packages] | Run 'go help list' for details. | invalid value "all:linkshared" for flag -gcflags: missing =<value> in <pattern>=<value> | usage: install [-i] [build flags] [packages] 80011 7 otavio 2018-03-28 13:51:53 +0000 Using the recipe in: https://gist.github.com/gustavosbarreto/38216d2c50f9af589b91989dbc9916f3 You can reproduce this. 80021 8 4243 matt 2018-03-29 04:58:07 +0000 Created attachment 4243 Patch for testing - not final version Sorry, I fat-fingered the needed compiler/assembler flags. I still can't reproduce the problem with a qemuarm target, but that could be due to compiler output being identical for armv5 in the static vs. dynamic linkage case. I might be able to with another target, will give that a try. In the meantime, could you try with the attached patch to see if it helps? I think I'll need to rework the patch a bit before submitting since the bbclass needs to work with both 1.9.4 and 1.10, but only 1.10 supports the new flag format, but this should at least tell me whether I'm on the right track. Thanks, -Matt 80022 9 otavio 2018-03-29 07:20:31 +0000 It does not seem to help. The issue seems to happen in ARM using hardfp. Also, we found that if we use "http" instead of "http", it "works". 80047 10 matt 2018-03-30 15:13:21 +0000 I can reproduce this now on an ARMv7 target, provided the image also includes the ca-certificates package. Also, you have to wait until /dev/random has enough entropy. I can also reproduce this natively by building go 1.10 from source, building a shared runtime with 'go install -linkshared -buildmode=shared std', and doing a 'go get -linkshared github.com/gustavosbarreto/go-crazy'. So it's not ARM-specific. It's a panic due to a segfault, always appearing to happen around a sync.Pool request in logrus's Entry.log function. However, it only seems to happen if the https request is also getting processed in other goroutines. Panic tracebacks always point to the logrus package as the running thread, sometimes with and sometimes without other goroutines being active. It does seem to happen only when the program is linked against shared runtime, not when linked statically. Definitely an upstream issue, just not 100% sure that it's really in the Go runtime, or if logrus is misusing the sync package. 80065 11 otavio 2018-04-02 06:41:14 +0000 I am glad you succeed in reproducing it. Did you find any upstream issue related to it? 80066 12 matt 2018-04-02 07:44:47 +0000 I haven't found an upstream bug report that matches this exactly, and it's hard to know whether the root cause is in the go shared runtime support or in the logrus package. Some possibly related issues: https://github.com/golang/go/issues/23199 https://github.com/sirupsen/logrus/issues/740 https://bugzilla.redhat.com/show_bug.cgi?format=multiple&id=1561619 80067 13 otavio 2018-04-02 09:03:07 +0000 I reported this upstream: https://github.com/golang/go/issues/24640 80334 14 richard.purdie 2018-04-19 08:29:56 +0000 Move to 2.6 M1 since this is now not the default for the 2.5 release. 80802 15 raj.khem 2018-06-18 17:32:07 +0000 Otavio Can you see if https://github.com/sirupsen/logrus/pull/752/commits/8369e2f077642788e2ef31f342a0a4621b2b4607 when applied to logrus fixes the issue or not? 80803 16 raj.khem 2018-06-18 17:33:56 +0000 We might have to wait until 1.11 release ( tentative Due by July 31, 2018) 80980 17 sjolley.yp.pm 2018-06-29 15:04:07 +0000 I have put this into Accepted, since it is not waiting on information, but waiting for an upgrade to be available. 81780 18 raj.khem 2018-10-08 16:31:48 +0000 I think we have to move this to 2.7 which 1.11 has been released, we might not be able to integrate that into 2.6 as of now, given the release is so close. 81919 19 raj.khem 2018-10-19 03:05:32 +0000 Posted patch to ml. https://patchwork.openembedded.org/series/14602/ 81965 20 raj.khem 2018-10-29 15:17:40 +0000 this is fixed 4243 2018-03-29 04:58:07 +0000 2018-03-29 04:58:07 +0000 Patch for testing - not final version 0001-go-set-compiler-and-assembler-flags-when-using-share.patch text/plain 1991 matt RnJvbSAyYjFiMzIxNTIzZWMxMTUwZTU3NmM3MDBjY2Y3MDk0MTM0ZjBkMmU3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXR0IE1hZGlzb24gPG1hdHRAbWFkaXNvbi5zeXN0ZW1zPgpE YXRlOiBUaHUsIDI5IE1hciAyMDE4IDA0OjQ4OjI1IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gZ286 IHNldCBjb21waWxlciBhbmQgYXNzZW1ibGVyIGZsYWdzIHdoZW4gdXNpbmcgc2hhcmVkCiBydW50 aW1lCgpJbiBnbzEuMTAsIHRoZSBidWlsZCB0b29sIG5vIGxvbmdlciBhcHBsaWVzIGNvbXBpbGVy IGFuZAphc3NlbWJsZXIgZmxhZ3MgdG8gYWxsIHBhY2thZ2VzIGJ1aWx0IHVubGVzcyBleHBsaWNp dGx5IHRvbGQKdG8uICBUaGlzIGNhbiBjYXVzZSBhIG1pc21hdGNoIGJldHdlZW4gYSBwcm9ncmFt IGJ1aWx0IHRvCnVzZSBzaGFyZWQgcnVudGltZSBhbmQgYW55IHZlbmRvcmVkIHBhY2thZ2VzLiBU ZWxsIHRoZSBidWlsZAp0b29sIHRvIGNvbXBpbGUgZm9yIGR5bmFtaWMgbGlua2luZyB3aGVuIGJ1 aWxkaW5nIGFnYWluc3QKc2hhcmVkIHJ1bnRpbWUuCgpTaWduZWQtb2ZmLWJ5OiBNYXR0IE1hZGlz b24gPG1hdHRAbWFkaXNvbi5zeXN0ZW1zPgotLS0KIG1ldGEvY2xhc3Nlcy9nby5iYmNsYXNzICAg ICAgICAgICAgICAgICAgICAgfCAyICstCiBtZXRhL3JlY2lwZXMtZGV2dG9vbHMvZ28vZ28tcnVu dGltZV8xLjEwLmJiIHwgMSArCiAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL21ldGEvY2xhc3Nlcy9nby5iYmNsYXNzIGIvbWV0YS9j bGFzc2VzL2dvLmJiY2xhc3MKaW5kZXggZDMzZDgzZWE3Zi4uNjYzOTU1ZTMyNyAxMDA2NDQKLS0t IGEvbWV0YS9jbGFzc2VzL2dvLmJiY2xhc3MKKysrIGIvbWV0YS9jbGFzc2VzL2dvLmJiY2xhc3MK QEAgLTE0LDcgKzE0LDcgQEAgREVQRU5EU19HT0xBTkdfY2xhc3MtbmF0aXZlc2RrID0gInZpcnR1 YWwvJHtUQVJHRVRfUFJFRklYfWdvLWNyb3Nzc2RrIHZpcnR1YWwvJHsKIAogREVQRU5EU19hcHBl bmQgPSAiICR7REVQRU5EU19HT0xBTkd9IgogCi1HT19MSU5LU0hBUkVEID89ICIke0AnLWxpbmtz aGFyZWQnIGlmIGQuZ2V0VmFyKCdHT19EWU5MSU5LJykgZWxzZSAnJ30iCitHT19MSU5LU0hBUkVE ID89ICIke0AnLWxpbmtzaGFyZWQgLWdjZmxhZ3M9YWxsPS1keW5saW5rIC1hc21mbGFncz1hbGw9 LWR5bmxpbmsnIGlmIGQuZ2V0VmFyKCdHT19EWU5MSU5LJykgZWxzZSAnJ30iCiBHT19SUEFUSF9M SU5LID0gIiR7QCctV2wsLXJwYXRoLWxpbms9JHtTVEFHSU5HX0RJUl9UQVJHRVR9JHtsaWJkaXJ9 L2dvL3BrZy8ke1RBUkdFVF9HT1RVUExFfV9keW5saW5rJyBpZiBkLmdldFZhcignR09fRFlOTElO SycpIGVsc2UgJyd9IgogR09fUlBBVEggPSAiJHtAJy1yICR7bGliZGlyfS9nby9wa2cvJHtUQVJH RVRfR09UVVBMRX1fZHlubGluaycgaWYgZC5nZXRWYXIoJ0dPX0RZTkxJTksnKSBlbHNlICcnfSIK IEdPX1JQQVRIX2NsYXNzLW5hdGl2ZSA9ICIke0AnLXIgJHtTVEFHSU5HX0xJQkRJUl9OQVRJVkV9 L2dvL3BrZy8ke1RBUkdFVF9HT1RVUExFfV9keW5saW5rJyBpZiBkLmdldFZhcignR09fRFlOTElO SycpIGVsc2UgJyd9IgpkaWZmIC0tZ2l0IGEvbWV0YS9yZWNpcGVzLWRldnRvb2xzL2dvL2dvLXJ1 bnRpbWVfMS4xMC5iYiBiL21ldGEvcmVjaXBlcy1kZXZ0b29scy9nby9nby1ydW50aW1lXzEuMTAu YmIKaW5kZXggNDNiNjhiNGU0Ni4uN2I3NjA4ZTMwNSAxMDA2NDQKLS0tIGEvbWV0YS9yZWNpcGVz LWRldnRvb2xzL2dvL2dvLXJ1bnRpbWVfMS4xMC5iYgorKysgYi9tZXRhL3JlY2lwZXMtZGV2dG9v bHMvZ28vZ28tcnVudGltZV8xLjEwLmJiCkBAIC0xLDIgKzEsMyBAQAogcmVxdWlyZSBnby0ke1BW fS5pbmMKIHJlcXVpcmUgZ28tcnVudGltZS5pbmMKK0dPX1NITElCX0xERkxBR1MgKz0gIi1nY2Zs YWdzPWFsbD0tZHlubGluayAtYXNtZmxhZ3M9YWxsPS1keW5saW5rIgotLSAKMi4xNC4xCgo=