12728 2018-05-02 08:33:52 +0000 git fetcher: Fixed remote removal not throwing exception on failure. 2018-08-30 09:29:36 +0000 1 1 7 Build System, Metadata & Runtime BitBake bitbake unspecified x86 Multiple RESOLVED FIXED Medium normal 2.6 1 ptsneves ptsneves poky.bs.watcher poky.watcher richard.purdie stephano --- --- No (bug/feature does not impact docs) oldest_to_newest 80465 0 4295 ptsneves 2018-05-02 08:33:52 +0000 Created attachment 4295 Patch that allows for earlier failure message. A caught exception in runfectcmd is assumed to always be benign when it is not. Before this fix it is assumed that the removal of the remote can only fail because there is not remote to remove. This is a false assumption. Example error which would be ignored: git -c core.fsyncobjectfiles=0 remote rm origin failed with exit code 1, output: Note: A branch outside the refs/remotes/ hierarchy was not removed; to delete it, use: git branch -d master error: could not lock config file config error: Could not remove config section 'remote.origin' Due to the masking of this error a stranger error will be presented to the user, because this time we do not mask the exception: git -c core.fsyncobjectfiles=0 remote add --mirror=fetch origin https://github.com/ptsneves/tl-wn722.git failed with exit code 128, output: fatal: remote origin already exists. The most likely reason that the remote cannot be removed nor modified is that the DL_DIR/git2 does not have write permissions compatible with the user running bitbake. This happened to me while pointing to a pre-populated download directory. The patch below allowed me to see the true nature of the problems I was facing. 80479 1 stephano 2018-05-03 08:06:32 +0000 Thank you for the patch. I think this will require some discussion on the bitbake mailing list. Please send this in: https://www.openembedded.org/wiki/Mailing_lists For more info on submitting patches: https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded Thanks! 81449 2 ptsneves 2018-08-28 14:12:49 +0000 Submitted patch to bitbake-devel. I was getting some emails to solve this..so i finally did it. 81454 3 richard.purdie 2018-08-30 09:29:36 +0000 Thanks, the patch merged so we can resolve this: http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=a8368651ffed1bd6c4715a37dfe9f40c48ca23c4 (Chris Larson did comment on the patch with a small tweak we might also want to add) 4295 2018-05-02 08:33:52 +0000 2018-05-02 08:33:52 +0000 Patch that allows for earlier failure message. 0001-fetcher-Fixed-remote-removal-not-throw-exception-on-.patch text/plain 2210 ptsneves RnJvbSA1N2NkODc5OGM0NGUwNWI3YWI2Yjk2YzFjMTg1YzY3NzYzYmM4YWIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsbyBOZXZlcyA8cHRzbmV2ZXNAZ21haWwuY29tPgpEYXRl OiBUdWUsIDEgTWF5IDIwMTggMTc6MzI6MzYgKzAyMDAKU3ViamVjdDogW1BBVENIIDEvMV0gZmV0 Y2hlcjogRml4ZWQgcmVtb3RlIHJlbW92YWwgbm90IHRocm93IGV4Y2VwdGlvbiBvbgogZmFpbHVy ZS4KCkJlZm9yZSB0aGlzIGZpeCBpdCBpcyBhc3N1bWVkIHRoYXQgdGhlIHJlbW92YWwgb2YgdGhl CnJlbW90ZSBjYW4gb25seSBmYWlsIGJlY2F1c2UgdGhlcmUgaXMgbm90IHJlbW90ZSB0byByZW1v dmUuIFRoaXMKaXMgYSBmYWxzZSBhc3N1bXB0aW9uLiBFeGFtcGxlIGVycm9yIHdoaWNoIHdvdWxk IGJlIGlnbm9yZWQ6CgpnaXQgLWMgY29yZS5mc3luY29iamVjdGZpbGVzPTAgcmVtb3RlIHJtIG9y aWdpbiBmYWlsZWQgd2l0aCBleGl0IGNvZGUgMSwgb3V0cHV0OgpOb3RlOiBBIGJyYW5jaCBvdXRz aWRlIHRoZSByZWZzL3JlbW90ZXMvIGhpZXJhcmNoeSB3YXMgbm90IHJlbW92ZWQ7CnRvIGRlbGV0 ZSBpdCwgdXNlOgogIGdpdCBicmFuY2ggLWQgbWFzdGVyCmVycm9yOiBjb3VsZCBub3QgbG9jayBj b25maWcgZmlsZSBjb25maWcKZXJyb3I6IENvdWxkIG5vdCByZW1vdmUgY29uZmlnIHNlY3Rpb24g J3JlbW90ZS5vcmlnaW4nCgpEdWUgdG8gdGhlIG1hc2tpbmcgb2YgdGhpcyBlcnJvciBhIHN0cmFu Z2VyIGVycm9yIHdpbGwgYmUKcHJlc2VudGVkIHRvIHRoZSB1c2VyLCBiZWNhdXNlIHRoaXMgdGlt ZSB3ZSBkbyBub3QgbWFzayB0aGUKZXhjZXB0aW9uOgoKZ2l0IC1jIGNvcmUuZnN5bmNvYmplY3Rm aWxlcz0wIHJlbW90ZSBhZGQgLS1taXJyb3I9ZmV0Y2ggb3JpZ2luIGh0dHBzOi8vZ2l0aHViLmNv bS9wdHNuZXZlcy90bC13bjcyMi5naXQgZmFpbGVkIHdpdGggZXhpdCBjb2RlIDEyOCwgb3V0cHV0 OgpmYXRhbDogcmVtb3RlIG9yaWdpbiBhbHJlYWR5IGV4aXN0cy4KClRoZSBtb3N0IGxpa2VseSBy ZWFzb24gdGhhdCB0aGUgcmVtb3RlIGNhbm5vdCBiZSByZW1vdmVkIG5vcgptb2RpZmllZCBpcyB0 aGF0IHRoZSBETF9ESVIvZ2l0MiBkb2VzIG5vdCBoYXZlIHBlcm1pc3Npb25zCmNvbXBhdGlibGUg d2l0aCB0aGUgdXNlciBydW5uaW5nIGJpdGJha2UuCi0tLQogYml0YmFrZS9saWIvYmIvZmV0Y2gy L2dpdC5weSB8IDQgKysrLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbigtKQoKZGlmZiAtLWdpdCBhL2JpdGJha2UvbGliL2JiL2ZldGNoMi9naXQucHkgYi9iaXRi YWtlL2xpYi9iYi9mZXRjaDIvZ2l0LnB5CmluZGV4IGFkMjg2OTUyZmM1YTgzYTQ2NDQzYzdmY2Y3 YWFlZDA5Y2Q3ZDAzMGQuLjdiOTA2OWQ5NGYwYzBjOTgxYTQxNjc0YzQ2MjdjZjdlODM1NWNjN2Yg MTAwNjQ0Ci0tLSBhL2JpdGJha2UvbGliL2JiL2ZldGNoMi9naXQucHkKKysrIGIvYml0YmFrZS9s aWIvYmIvZmV0Y2gyL2dpdC5weQpAQCAtMjYxLDcgKzI2MSw5IEBAIGNsYXNzIEdpdChGZXRjaE1l dGhvZCk6CiAgICAgICAgICAgICBpZiBub3Qgc2VsZi5fY29udGFpbnNfcmVmKHVkLCBkLCBuYW1l LCB1ZC5jbG9uZWRpcik6CiAgICAgICAgICAgICAgICAgbmVlZHVwZGF0ZSA9IFRydWUKICAgICAg ICAgaWYgbmVlZHVwZGF0ZToKLSAgICAgICAgICAgIHJ1bmZldGNoY21kKCIlcyByZW1vdGUgcm0g b3JpZ2luIiAlIHVkLmJhc2VjbWQsIGQsIHdvcmtkaXI9dWQuY2xvbmVkaXIpCisgICAgICAgICAg ICBvdXRwdXQgPSBydW5mZXRjaGNtZCgiJXMgcmVtb3RlIiAlIHVkLmJhc2VjbWQsIGQsIHF1aWV0 PVRydWUsIHdvcmtkaXI9dWQuY2xvbmVkaXIpCisgICAgICAgICAgICBpZiAib3JpZ2luIiBpbiBv dXRwdXQ6CisgICAgICAgICAgICAgIHJ1bmZldGNoY21kKCIlcyByZW1vdGUgcm0gb3JpZ2luIiAl IHVkLmJhc2VjbWQsIGQsIHdvcmtkaXI9dWQuY2xvbmVkaXIpCiAKICAgICAgICAgICAgIHJ1bmZl dGNoY21kKCIlcyByZW1vdGUgYWRkIC0tbWlycm9yPWZldGNoIG9yaWdpbiAlcyIgJSAodWQuYmFz ZWNtZCwgcmVwb3VybCksIGQsIHdvcmtkaXI9dWQuY2xvbmVkaXIpCiAgICAgICAgICAgICBmZXRj aF9jbWQgPSAiTEFORz1DICVzIGZldGNoIC1mIC0tcHJ1bmUgLS1wcm9ncmVzcyAlcyByZWZzLyo6 cmVmcy8qIiAlICh1ZC5iYXNlY21kLCByZXBvdXJsKQotLSAKMi4xNC4xCgo=