<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>12752</bug_id>
          
          <creation_ts>2018-05-16 03:55:40 +0000</creation_ts>
          <short_desc>Check that patches don&apos;t have a github /archive/ URL</short_desc>
          <delta_ts>2022-08-04 14:58:22 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>Patchwork/Patchtest</product>
          <component>Patchtest Testsuite</component>
          <version>unspecified</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>4.99</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ross Burton">ross.burton</reporter>
          <assigned_to name="Tim Orling">tim.orling</assigned_to>
          <cc>paul</cc>
    
    <cc>randy.macleod</cc>
    
    <cc>tim.orling</cc>
    
    <cc>twoerner</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>80589</commentid>
    <comment_count>0</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2018-05-16 03:55:40 +0000</bug_when>
    <thetext>We shouldn&apos;t be using github /archive/ URLs in recipes because the resulting tarball isn&apos;t reliable.

For example https://github.com/madler/pigz/archive/v1.2.tar.gz

Vague pseudo-expression to match is https?://github.com/*/*/archive/*

Patchtest should check for this and emit an error.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>80601</commentid>
    <comment_count>1</comment_count>
    <who name="Trevor Woerner">twoerner</who>
    <bug_when>2018-05-16 14:18:05 +0000</bug_when>
    <thetext>or:
    grep -r -l -E github\\.com/.*/archive/ *</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86836</commentid>
    <comment_count>2</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2020-03-26 17:26:14 +0000</bug_when>
    <thetext>Paul, would you like to add this check?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>93722</commentid>
    <comment_count>3</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2022-08-04 14:58:22 +0000</bug_when>
    <thetext>Fixed: 

https://git.openembedded.org/openembedded-core/commit/?id=21f84fcdd659544437fe393285c407e1e9432043

Thanks Ross!</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>