<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>12831</bug_id>
          
          <creation_ts>2018-06-29 02:18:56 +0000</creation_ts>
          <short_desc>Typo in python3-reprlib does not include correct files in package</short_desc>
          <delta_ts>2018-11-27 14:56:13 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>devtools / tool chain</component>
          <version>2.4.5</version>
          <rep_platform>All</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>CLOSED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>minor</bug_severity>
          <target_milestone>2.4.4</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tim Burke">tim</reporter>
          <assigned_to name="Armin Kuster">akuster</assigned_to>
          <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
    
    <cc>ross.burton</cc>
    
    <cc>tim</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>80978</commentid>
    <comment_count>0</comment_count>
    <who name="Tim Burke">tim</who>
    <bug_when>2018-06-29 02:18:56 +0000</bug_when>
    <thetext>The python-3.5-manifest.inc file used to define packages for the python3 stdlib modules has a typo that incorrectly lists the files that should be included in the python3-reprlib package.  In particular, it does not include the *.pyc files due to what appears to be a copy-paste error.

This doesn&apos;t appear to have any impact on a normal build since the missing files are still packaged up in python3-misc so they still get installed.

I hit this issue when trying to remove extraneous uncompiled *.py files in the stdlib to save space.  Since the python3-reprlib package consists only of *.py files (because it omits the *.pyc file), splitting the *.py files into a new python3-src package caused python3-reprlib to be empty.  However, python3-core depends on it, leading to the overall image generation failing.

The line in question is linked here:
http://cgit.openembedded.org/openembedded-core/tree/meta/recipes-devtools/python/python-3.5-manifest.inc?h=rocko#n196

In particular it reads:
FILES_${PN}-reprlib=&quot;${libdir}/python3.5/reprlib.py ${libdir}/python3.5/__pycache__/reprlib.py &quot;

I believe it should be instead:
FILES_${PN}-reprlib=&quot;${libdir}/python3.5/reprlib.py ${libdir}/python3.5/__pycache__/reprlib.*&quot;

Note the difference where the current line looks for a .py file inside which __pycache__ which is not present rather than looking for the compiled *.pyc file.

I based this proposed delta on an analogy with the python3-signal package:
FILES_${PN}-signal=&quot;${libdir}/python3.5/signal.* ${libdir}/python3.5/__pycache__/signal.* &quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>82076</commentid>
    <comment_count>1</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2018-11-08 16:14:41 +0000</bug_when>
    <thetext>As this refers to the manifest.inc it doesn&apos;t apply to 2.5 onwards, which uses a new manifest which doesn&apos;t have this problem (reprlib is part of python3-core there).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>82189</commentid>
    <comment_count>2</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2018-11-13 10:35:43 +0000</bug_when>
    <thetext>Patch queued in rocko-next, over to Armin.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>82198</commentid>
    <comment_count>3</comment_count>
    <who name="Armin Kuster">akuster</who>
    <bug_when>2018-11-13 16:45:22 +0000</bug_when>
    <thetext>in rocko-nmut for building</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>82331</commentid>
    <comment_count>4</comment_count>
    <who name="Armin Kuster">akuster</who>
    <bug_when>2018-11-27 14:55:48 +0000</bug_when>
    <thetext>in rocko proper

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=rocko&amp;id=68a612b7d31d270348ef5439d7f779c309bdb6ec</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>82332</commentid>
    <comment_count>5</comment_count>
    <who name="Armin Kuster">akuster</who>
    <bug_when>2018-11-27 14:56:01 +0000</bug_when>
    <thetext>checked in</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>82333</commentid>
    <comment_count>6</comment_count>
    <who name="Armin Kuster">akuster</who>
    <bug_when>2018-11-27 14:56:13 +0000</bug_when>
    <thetext>done</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>