12909 2018-08-31 20:31:42 +0000 kernel.bbclass silently ignores non-existing initramfs when INITRAMFS_IMAGE_BUNDLE=1 2019-03-11 04:44:30 +0000 1 1 7 Build System, Metadata & Runtime OE-Core core 2.5.2 All Multiple RESOLVED FIXED Medium+ normal 2.7 M3 1 leon richard.purdie akuster meta.mr.watcher meta.watcher ross.burton --- --- No (bug/feature does not impact docs) oldest_to_newest 81475 0 4364 leon 2018-08-31 20:31:42 +0000 Created attachment 4364 Proposed fix for kernel.bbclass not asserting that bundled initramfs image exists The code in kernel.bbclass does a few things wrong: 1) If ${DEPLOY_DIR_IMAGE}/${INITRAMFS_IMAGE_NAME}.cpio does not exist, nor any of the compressed variants, nothing is copied to kernel build's ./usr directory. The code does not fail, but silently proceeds without a bundled initramfs. (Or, an older initramfs that was copied in ./usr earlier.) The expected outcome is that the build stops ("die") because the user explicitly set both INITRAMFS_IMAGE="some-name" and INITRAMFS_IMAGE_BUNDLE = "1" Typical use-case is when the user has set INITRAMFS_IMAGE but not has set INITRAMFS_IMAGE_NAME. (The kernel class will create INITRAMFS_IMAGE_NAME from INITRAMFS_IMAGE appending "-${MACHINE}" by default, which might not be what the user did.) 2) If an initramfs is found, contrary to the comments, it does not stop at the first uncompressed/compressed cpio image found. Instead it keeps processing all. (This is a much less critical bug.) 81476 1 leon 2018-08-31 21:25:36 +0000 I have given this more thoughts and tests. I think we should also delete the existing ./usr/${INITRAMFS_IMAGE_NAME}.cpio in the build, before we are copying the to-be-bundled initramfs image. This way, we can be certain that the final check [ -f ./usr/${INITRAMFS_IMAGE_NAME}.cpio ] checks for a *copied* initramfs, rather then possibly a left-over. (This can happen when the user is explicitly running separate tasks.) We want to bundle task to be stand-alone-correct. 81479 2 leon 2018-09-01 20:02:40 +0000 (In reply to comment #1) > I have given this more thoughts and tests. I think we should also delete the > existing ./usr/${INITRAMFS_IMAGE_NAME}.cpio in the build, before we are > copying the to-be-bundled initramfs image. > Foget this remark, as this actually already happens. It's the check whether a new initramfs image was copied that is missing and that is important to have. 81480 3 4365 leon 2018-09-01 21:20:26 +0000 Created attachment 4365 Updated fix with more clear user message, telling what might be wrong. 81488 4 ross.burton 2018-09-03 11:36:02 +0000 Please send the patch to openembedded-core@lists.openembedded.org as we don't accept patches via bugzilla. 82075 5 ross.burton 2018-11-08 16:13:09 +0000 Leon, can you post this to the list please? 83119 6 richard.purdie 2019-02-25 23:04:14 +0000 http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=a5b7c86f23110cad2aa1d4ee378058ca1eb5f1c1 83237 7 akuster 2019-03-11 04:44:03 +0000 back ported to stable/thud-next http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=stable/thud-next&id=ec52ff0ddc11bbfe226da528dfdc8bb75615530f 83238 8 akuster 2019-03-11 04:44:30 +0000 do we need for sumo? 4364 2018-08-31 20:31:42 +0000 2018-09-01 21:20:26 +0000 Proposed fix for kernel.bbclass not asserting that bundled initramfs image exists kernel-bbclass-assert-bundled-initramfs-exists.patch text/plain 1147 leon ZGlmZiAtLWdpdCBhL21ldGEvY2xhc3Nlcy9rZXJuZWwuYmJjbGFzcyBiL21ldGEvY2xhc3Nlcy9r ZXJuZWwuYmJjbGFzcwppbmRleCA3OGQ2YzMwLi5jNDc1MjQ0IDEwMDY0NAotLS0gYS9tZXRhL2Ns YXNzZXMva2VybmVsLmJiY2xhc3MKKysrIGIvbWV0YS9jbGFzc2VzL2tlcm5lbC5iYmNsYXNzCkBA IC0xOTAsNyArMTkwLDkgQEAgY29weV9pbml0cmFtZnMoKSB7CiAJIyBGaW5kIGFuZCB1c2UgdGhl IGZpcnN0IGluaXRyYW1mcyBpbWFnZSBhcmNoaXZlIHR5cGUgd2UgZmluZAogCXJtIC1mICR7Qn0v dXNyLyR7SU5JVFJBTUZTX0lNQUdFX05BTUV9LmNwaW8KIAlmb3IgaW1nIGluIGNwaW8gY3Bpby5n eiBjcGlvLmx6NCBjcGlvLmx6byBjcGlvLmx6bWEgY3Bpby54ejsgZG8KKwkJZWNobyAiU2VlaW5n IGlmICR7REVQTE9ZX0RJUl9JTUFHRX0vJHtJTklUUkFNRlNfSU1BR0VfTkFNRX0uJGltZyBleGlz dHMuLi4iCiAJCWlmIFsgLWUgIiR7REVQTE9ZX0RJUl9JTUFHRX0vJHtJTklUUkFNRlNfSU1BR0Vf TkFNRX0uJGltZyIgXTsgdGhlbgorCQkJZWNobyAiQ29weWluZyAke0RFUExPWV9ESVJfSU1BR0V9 LyR7SU5JVFJBTUZTX0lNQUdFX05BTUV9LiRpbWcgaW50byAuL3VzciAuLi4iCiAJCQljcCAke0RF UExPWV9ESVJfSU1BR0V9LyR7SU5JVFJBTUZTX0lNQUdFX05BTUV9LiRpbWcgJHtCfS91c3IvLgog CQkJY2FzZSAkaW1nIGluCiAJCQkqZ3opCkBAIC0yMTksOSArMjIxLDExIEBAIGNvcHlfaW5pdHJh bWZzKCkgewogCQkJCWJyZWFrCiAJCQkJOzsKIAkJCWVzYWMKKwkJCWJyZWFrCiAJCWZpCiAJZG9u ZQotCWVjaG8gIkZpbmlzaGVkIGNvcHkgb2YgaW5pdHJhbWZzIGludG8gLi91c3IiCisJIyBWZXJp ZnkgdGhhdCB0aGUgYWJvdmUgbG9vcCBmb3VuZCBhIGluaXRyYW1mcywgZmFpbCBvdGhlcndpc2UK KwlbIC1mICR7Qn0vdXNyLyR7SU5JVFJBTUZTX0lNQUdFX05BTUV9LmNwaW8gXSAmJiBlY2hvICJG aW5pc2hlZCBjb3B5IG9mIGluaXRyYW1mcyBpbnRvIC4vdXNyIiB8fCBkaWUgIkZhaWxlZCB0byBj b3B5ICR7SU5JVFJBTUZTX0lNQUdFX05BTUV9LmNwaW8gaW50byAuL3VzciIKIH0KIAogSU5JVFJB TUZTX0JBU0VfTkFNRSA/PSAiaW5pdHJhbWZzLSR7UFZ9LSR7UFJ9LSR7TUFDSElORX0tJHtEQVRF VElNRX0iCg== 4365 2018-09-01 21:20:26 +0000 2018-09-01 21:20:26 +0000 Updated fix with more clear user message, telling what might be wrong. kernel-bbclass-assert-bundled-initramfs-exists.patch text/plain 696 leon ZGlmZiAtLWdpdCBhL21ldGEvY2xhc3Nlcy9rZXJuZWwuYmJjbGFzcyBiL21ldGEvY2xhc3Nlcy9r ZXJuZWwuYmJjbGFzcwppbmRleCA3OGQ2YzMwLi5iMzQxNzMzIDEwMDY0NAotLS0gYS9tZXRhL2Ns YXNzZXMva2VybmVsLmJiY2xhc3MKKysrIGIvbWV0YS9jbGFzc2VzL2tlcm5lbC5iYmNsYXNzCkBA IC0yMTksOSArMjE5LDExIEBAIGNvcHlfaW5pdHJhbWZzKCkgewogCQkJCWJyZWFrCiAJCQkJOzsK IAkJCWVzYWMKKwkJCWJyZWFrCiAJCWZpCiAJZG9uZQotCWVjaG8gIkZpbmlzaGVkIGNvcHkgb2Yg aW5pdHJhbWZzIGludG8gLi91c3IiCisJIyBWZXJpZnkgdGhhdCB0aGUgYWJvdmUgbG9vcCBmb3Vu ZCBhIGluaXRyYW1mcywgZmFpbCBvdGhlcndpc2UKKwlbIC1mICR7Qn0vdXNyLyR7SU5JVFJBTUZT X0lNQUdFX05BTUV9LmNwaW8gXSAmJiBlY2hvICJGaW5pc2hlZCBjb3B5IG9mIGluaXRyYW1mcyBp bnRvIC4vdXNyIiB8fCBkaWUgIkNvdWxkIG5vdCBmaW5kIGFueSAke0RFUExPWV9ESVJfSU1BR0V9 LyR7SU5JVFJBTUZTX0lNQUdFX05BTUV9LmNwaW97Lmd6fC5sejR8Lmx6b3wubHptYXwueHopIGZv ciBidW5kbGluZzsgSU5JVFJBTUZTX0lNQUdFX05BTUUgbWlnaHQgYmUgd3JvbmcuIgogfQogCiBJ TklUUkFNRlNfQkFTRV9OQU1FID89ICJpbml0cmFtZnMtJHtQVn0tJHtQUn0tJHtNQUNISU5FfS0k e0RBVEVUSU1FfSIK