<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>13168</bug_id>
          
          <creation_ts>2019-02-04 14:00:43 +0000</creation_ts>
          <short_desc>devtool: cannot add new recipe if reproducible_build class is inherited</short_desc>
          <delta_ts>2019-07-04 04:06:15 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>OE-Core</product>
          <component>devtools / tool chain</component>
          <version>2.6.2</version>
          <rep_platform>All</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard>Backport 2.5 and 2.6</status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>2.8 M2</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Romuald Jeanne">romuald.jeanne</reporter>
          <assigned_to name="Paul Eggleton">bluelightning</assigned_to>
          <cc>meta.mr.watcher</cc>
    
    <cc>meta.watcher</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>Don&apos;t know</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>82954</commentid>
    <comment_count>0</comment_count>
    <who name="Romuald Jeanne">romuald.jeanne</who>
    <bug_when>2019-02-04 14:00:43 +0000</bug_when>
    <thetext>Preconditions/Environment
-------------------------
Setup default Yocto configuration on THUD release:
DISTRO=nodistro
MACHINE=(any machine)

Add in &apos;local.conf&apos; file
INHERIT += &quot;reproducible_build&quot;

Triggering Action/Cause
-----------------------
Once bitbake environment enabled, run devtool command to add a new recipe:
devtool add godot https://github.com/godotengine/godot

Expectation
-----------
The devtool command should successfully donwload source code and create a recipe
skeleton.

Actual Result
-------------
The devtool command ends with error:
ERROR: Command &apos;script -e -q -c &quot;recipetool --color=always create --devtool -o /tmp/devtoolpessb4ed &apos;https://github.com/godotengine/godot&apos;  -x /home/yocto-thud/build/workspace/sources/devtoolsrcko5unxkk -N godot&quot; /dev/null&apos; failed

Reproducibility
---------------
1/1

Pre-Analysis:
-------------
With &apos;reproducible_build&apos; class, it appears that new folder &apos;source-date-epoch&apos; (cf. SDE_DIR) is not yet properly handled by &apos;create.py&apos; script.
In this script, line 507, a filtering is done like this:
  filterout = [&apos;git.indirectionsymlink&apos;]
While it should be:
  filterout = [&apos;git.indirectionsymlink&apos;, &apos;source-date-epoch&apos;]
Such modification makes &apos;devtool add&apos; command successful, but the &apos;source-date-epoch&apos; folder can be redefined to other value...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>84352</commentid>
    <comment_count>1</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2019-07-01 21:00:09 +0000</bug_when>
    <thetext>I cannot reproduce this with thud or master - devtool add succeeds every time. Is there possibly a missing step in your instructions? Some configuration missing perhaps? Is it still reproducible with current thud?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>84358</commentid>
    <comment_count>2</comment_count>
    <who name="Romuald Jeanne">romuald.jeanne</who>
    <bug_when>2019-07-02 09:15:19 +0000</bug_when>
    <thetext>You&apos;re right.
Since &apos;recipetool: fix unbound variable when fixed SRCREV can&apos;t be found&apos; commit has been merged in thud branch, there is no more issue.
Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>84366</commentid>
    <comment_count>3</comment_count>
    <who name="Paul Eggleton">bluelightning</who>
    <bug_when>2019-07-04 04:06:15 +0000</bug_when>
    <thetext>OK - this is the commit:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=568f0ab886cbcf83fcd9f154886280a7881d30fe

I can&apos;t quite see the connection at the moment, but we&apos;ll mark it as fixed.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>