<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>13319</bug_id>
          
          <creation_ts>2019-05-02 13:02:55 +0000</creation_ts>
          <short_desc>Add SPDX license headers to all source files for matchbox/sato</short_desc>
          <delta_ts>2020-08-17 08:41:19 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>Sato</product>
          <component>Matchbox</component>
          <version>svn</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard>NEWCOMER</status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>3.2 M3</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Richard Purdie">richard.purdie</reporter>
          <assigned_to name="Matthew Zeng">matthew.zeng</assigned_to>
          <cc>cody.yu</cc>
    
    <cc>david.reyna</cc>
    
    <cc>randy.macleod</cc>
    
    <cc>ross.burton</cc>
    
    <cc>tim.orling</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>83682</commentid>
    <comment_count>0</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2019-05-02 13:02:55 +0000</bug_when>
    <thetext>We should model best practices and clean up the matchbox/sato codebase to have SPDX license headers in all the source files.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>83703</commentid>
    <comment_count>1</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2019-05-02 14:49:54 +0000</bug_when>
    <thetext>https://spdx.org/licenses/
Also see the bitbake repository.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>84244</commentid>
    <comment_count>2</comment_count>
    <who name="David Reyna">david.reyna</who>
    <bug_when>2019-06-19 10:44:35 +0000</bug_when>
    <thetext>To be clear, the scope is just this directory?

  meta/recipes-sato/matchbox-sato

Or is is all &quot;matchbox&quot; content within the &quot;recipe-sato&quot; directory?

  [recipes-sato]$ ls -d *matchbox*
  matchbox-config-gtk  matchbox-desktop  matchbox-keyboard  
  matchbox-panel-2     matchbox-sato     matchbox-terminal  
  matchbox-theme-sato
  [recipes-sato]$ 

- David</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>84296</commentid>
    <comment_count>3</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2019-06-20 15:17:05 +0000</bug_when>
    <thetext>Matchbox is the window manager, Sato is the desktop using Matchbox, matchbox-sato itself is just some glue.  The scope is all of the matchbox-* recipes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86765</commentid>
    <comment_count>4</comment_count>
    <who name="Matthew Zeng">matthew.zeng</who>
    <bug_when>2020-03-20 16:36:16 +0000</bug_when>
    <thetext>Is this adding license headers to all matchbox-* source files in http://git.yoctoproject.org/ or adding them to recipe files in meta/recipes-sato/matchbox-* ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86766</commentid>
    <comment_count>5</comment_count>
    <who name="Ross Burton">ross.burton</who>
    <bug_when>2020-03-20 16:47:04 +0000</bug_when>
    <thetext>The former: adding to the source, not the recipes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86768</commentid>
    <comment_count>6</comment_count>
    <who name="Matthew Zeng">matthew.zeng</who>
    <bug_when>2020-03-20 18:35:59 +0000</bug_when>
    <thetext>From the repositories, it&apos;s unclear which SPDX License does matchbox apply. Is it same as Yocto itself, which is MIT?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86769</commentid>
    <comment_count>7</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2020-03-20 18:55:46 +0000</bug_when>
    <thetext>Some are pretty clear since they have a COPYING file in the top dir, eg:
http://git.yoctoproject.org/cgit/cgit.cgi/matchbox-desktop-2/tree/COPYING

Start with the clear ones and then make a list of the ones that are less clear and ask here again. Thanks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86837</commentid>
    <comment_count>8</comment_count>
    <who name="Matthew Zeng">matthew.zeng</who>
    <bug_when>2020-03-26 19:39:57 +0000</bug_when>
    <thetext>I&apos;ve submitted two patches to add SPDX license identifiers for now, please let me know if the format is correct.

- matchbox-config-gtk: https://lists.yoctoproject.org/g/yocto/topic/72494583
- matchbox-desktop-2: https://lists.yoctoproject.org/g/yocto/topic/72495096

Once confirmed and merged, I&apos;ll send patches for the rest of matchbox-* packages.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87003</commentid>
    <comment_count>9</comment_count>
    <who name="Matthew Zeng">matthew.zeng</who>
    <bug_when>2020-04-15 08:16:53 +0000</bug_when>
    <thetext>Can I get an update on the patches I sent? It isn&apos;t merged so I have to move this bug to 3.2.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87890</commentid>
    <comment_count>10</comment_count>
    <who name="Matthew Zeng">matthew.zeng</who>
    <bug_when>2020-08-06 08:43:01 +0000</bug_when>
    <thetext>I never received an update. But today I checked that those two patches are indeed merged in May, I&apos;ll submit rest of the patches to fix this issue.

The first one is matchbox-desktop: https://lists.yoctoproject.org/g/yocto/topic/matchbox_desktop_patch_add/76030636</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87891</commentid>
    <comment_count>11</comment_count>
    <who name="Matthew Zeng">matthew.zeng</who>
    <bug_when>2020-08-06 09:38:59 +0000</bug_when>
    <thetext>v2 of matchbox-desktop: https://lists.yoctoproject.org/g/yocto/topic/matchbox_desktop_patchv2/76032128</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87892</commentid>
    <comment_count>12</comment_count>
    <who name="Matthew Zeng">matthew.zeng</who>
    <bug_when>2020-08-06 13:00:23 +0000</bug_when>
    <thetext>matchbox_keyboard: https://lists.yoctoproject.org/g/yocto/topic/matchbox_keyboard_patch/76034462
matchbox_panel_2: https://lists.yoctoproject.org/g/yocto/topic/matchbox_panel_2_patch_add/76034810
matchbox_panel_manager: https://lists.yoctoproject.org/g/yocto/topic/matchbox_panel_manager_patch/76034929
matchbox_terminal: https://lists.yoctoproject.org/g/yocto/topic/matchbox_terminal_patch/76035003
matchbox_window_manager: https://lists.yoctoproject.org/g/yocto/topic/matchbox_window_manager_patch/76035883
matchbox_tests: https://lists.yoctoproject.org/g/yocto/topic/matchbox_tests_patch_add/76035884
matchbox_window_manager_2: https://lists.yoctoproject.org/g/yocto/topic/matchbox_window_manager_2_patch/76035885

Can anyone verify whether there are any additional matchbox libraries that need SPDX headers?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>87956</commentid>
    <comment_count>13</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2020-08-15 13:02:05 +0000</bug_when>
    <thetext>Matthew, I think you fixed all the MB repos. Please close the ER and if we find something that was missed, we&apos;ll deal with it. Thanks!</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>