13391 2019-06-11 12:52:29 +0000 acl ptest timeout due to perl update 2019-06-19 10:54:23 +0000 1 1 10 QA/Testing Package Testing (ptest) ptest unspecified x86 Multiple RESOLVED FIXED High normal 2.8 M2 1 richard.purdie alex.kanavin alex.kanavin randy.macleod sharmasudhir --- --- No (bug/feature does not impact docs) oldest_to_newest 84145 0 richard.purdie 2019-06-11 12:52:29 +0000 acl ptest timeout for both qemux86-64 and qemuarm64: https://autobuilder.yocto.io/pub/releases/yocto-2.8_M1.rc2/testresults/testresult-report.txt This didn't used to happen, was triggered around the time of the gcc upgrade from 8 -> 9. 84170 1 richard.purdie 2019-06-13 11:34:31 +0000 I tracked this down to being caused by the perl upgrade from 5.28 to 5.30. In 5.30, the $) = "2 2" assignment in ptest/test/run (a perl script) doesn't work and isn't able to change egid. Not sure why at this point but reverting to 5.28 does allow the tests to complete (and not hang). 84171 2 richard.purdie 2019-06-13 12:50:05 +0000 Test script to reproduce the problem: #!/usr/bin/env perl $) = "2 2"; print $!; Result from perl 5.28 setgroups(1, [2]) = 0 setresgid(-1, 2, -1) = 0 Result from perl 5.30 setgroups(1, [-1]) = -1 EINVAL (Invalid argument) setresgid(-1, 2, -1) = 0 84172 3 richard.purdie 2019-06-13 13:23:39 +0000 Looking like it may be caused by this change: https://perl5.git.perl.org/perl.git/commitdiff/5d4a52b5c68a11bfc97c2e24806993b84a61eade 84173 4 4526 richard.purdie 2019-06-13 13:32:36 +0000 Created attachment 4526 Sledghammer which fixes the problem 84174 5 richard.purdie 2019-06-13 13:33:18 +0000 Confirmed its that change upstream and that reverting to the previous function does fix the issue (sledgehammer approach). Now we need a correct fix. 84179 6 randy.macleod 2019-06-13 14:48:49 +0000 *** Bug 13395 has been marked as a duplicate of this bug. *** 84195 7 alex.kanavin 2019-06-13 16:35:31 +0000 This is unbelievably bad, if I am reading the code correctly. They have an argument to the string-to-number conversion function that a) in the old version was used to simply return the position where the lookup ended; b) in the new version is used to both provide a point where lookup should stop, and return the actual stopping point. When the string is a space separated list of numbers, the argument gets rewritten to point to the end of the first number, then provided as "point where to stop", so the second number is never read. Did I get this right? 84199 8 4527 richard.purdie 2019-06-13 22:04:38 +0000 Created attachment 4527 Simpler patch to fix the problem 84200 9 richard.purdie 2019-06-13 22:06:06 +0000 (In reply to comment #7) > This is unbelievably bad, if I am reading the code correctly. > > They have an argument to the string-to-number conversion function that > a) in the old version was used to simply return the position where the > lookup ended; > b) in the new version is used to both provide a point where lookup should > stop, and return the actual stopping point. > > When the string is a space separated list of numbers, the argument gets > rewritten to point to the end of the first number, then provided as "point > where to stop", so the second number is never read. > > Did I get this right? I think so. I have a patch which appears to fix it yet I'm still not quite sure I understand/believe it. As I understand it this is a genuine bug in perl but we have to submit it with perlbug. I wonder if we've ever tried that before... 84212 10 richard.purdie 2019-06-14 12:37:17 +0000 Submitted upstream: https://rt.perl.org/Public/Bug/Display.html?id=134195 84230 11 alex.kanavin 2019-06-18 10:57:22 +0000 Patch landed in master: http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=5d8c4e3f47acd1b181760274a39d6707abd976b8 Thanks for taking care of this! 84246 12 richard.purdie 2019-06-19 10:54:23 +0000 *** Bug 13395 has been marked as a duplicate of this bug. *** 4526 2019-06-13 13:32:36 +0000 2019-06-13 13:32:36 +0000 Sledghammer which fixes the problem test.patch text/plain 3812 richard.purdie SW5kZXg6IHBlcmwtNS4zMC4wL21nLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGVybC01LjMwLjAub3JpZy9t Zy5jCisrKyBwZXJsLTUuMzAuMC9tZy5jCkBAIC0yNzU1LDYgKzI3NTUsODMgQEAgU19zZXRfZG9s bGFyemVybyhwVEhYXyBTViAqc3YpCiAjZW5kaWYKIH0KIAorLyoKK2dyb2tfYXRvVVYKKworZ3Jv a19hdG9VViBwYXJzZXMgYSBDLXN0eWxlIHplcm8tYnl0ZSB0ZXJtaW5hdGVkIHN0cmluZywgbG9v a2luZyBmb3IKK2EgZGVjaW1hbCB1bnNpZ25lZCBpbnRlZ2VyLgorCitSZXR1cm5zIHRoZSB1bnNp Z25lZCBpbnRlZ2VyLCBpZiBhIHZhbGlkIHZhbHVlIGNhbiBiZSBwYXJzZWQKK2Zyb20gdGhlIGJl Z2lubmluZyBvZiB0aGUgc3RyaW5nLgorCitBY2NlcHRzIG9ubHkgdGhlIGRlY2ltYWwgZGlnaXRz ICcwJy4uJzknLgorCitBcyBvcHBvc2VkIHRvIGF0b2kgb3Igc3RydG9sLCBncm9rX2F0b1VWIGRv ZXMgTk9UIGFsbG93IG9wdGlvbmFsCitsZWFkaW5nIHdoaXRlc3BhY2UsIG9yIG5lZ2F0aXZlIGlu cHV0cy4gIElmIHN1Y2ggZmVhdHVyZXMgYXJlCityZXF1aXJlZCwgdGhlIGNhbGxpbmcgY29kZSBu ZWVkcyB0byBleHBsaWNpdGx5IGltcGxlbWVudCB0aG9zZS4KKworUmV0dXJucyB0cnVlIGlmIGEg dmFsaWQgdmFsdWUgY291bGQgYmUgcGFyc2VkLiBJbiB0aGF0IGNhc2UsIHZhbHB0cgoraXMgc2V0 IHRvIHRoZSBwYXJzZWQgdmFsdWUsIGFuZCBlbmRwdHIgKGlmIHByb3ZpZGVkKSBpcyBzZXQgdG8g cG9pbnQKK3RvIHRoZSBjaGFyYWN0ZXIgYWZ0ZXIgdGhlIGxhc3QgZGlnaXQuCisKK1JldHVybnMg ZmFsc2Ugb3RoZXJ3aXNlLiBUaGlzIGNhbiBoYXBwZW4gaWYgYSkgdGhlcmUgaXMgYSBsZWFkaW5n IHplcm8KK2ZvbGxvd2VkIGJ5IGFub3RoZXIgZGlnaXQ7IGIpIHRoZSBkaWdpdHMgd291bGQgb3Zl cmZsb3cgYSBVVjsgb3IgYykKK3RoZXJlIGFyZSB0cmFpbGluZyBub24tZGlnaXRzIEFORCBlbmRw dHIgaXMgbm90IHByb3ZpZGVkLgorCitCYWNrZ3JvdW5kOiBhdG9pIGhhcyBzZXZlcmUgcHJvYmxl bXMgd2l0aCBpbGxlZ2FsIGlucHV0cywgaXQgY2Fubm90IGJlCit1c2VkIGZvciBpbmNyZW1lbnRh bCBwYXJzaW5nLCBhbmQgdGhlcmVmb3JlIHNob3VsZCBiZSBhdm9pZGVkCithdG9pIGFuZCBzdHJ0 b2wgYXJlIGFsc28gYWZmZWN0ZWQgYnkgbG9jYWxlIHNldHRpbmdzLCB3aGljaCBjYW4gYWxzbyBi ZQorc2VlbiBhcyBhIGJ1ZyAoZ2xvYmFsIHN0YXRlIGNvbnRyb2xsZWQgYnkgdXNlciBlbnZpcm9u bWVudCkuCisKKyovCisKK3N0YXRpYyBjb25zdCBVViB1dl9tYXhfZGl2XzEwID0gVVZfTUFYIC8g MTA7CitzdGF0aWMgY29uc3QgVTggdXZfbWF4X21vZF8xMCA9IFVWX01BWCAlIDEwOworCitzdGF0 aWMgYm9vbAorZ3Jva19hdG9VVl9ycChjb25zdCBjaGFyICpwdiwgVVYgKnZhbHB0ciwgY29uc3Qg Y2hhcioqIGVuZHB0cikKK3sKKyAgICBjb25zdCBjaGFyKiBzID0gcHY7CisgICAgY29uc3QgY2hh cioqIGVwdHI7CisgICAgY29uc3QgY2hhciogZW5kMjsgLyogVXNlZCBpbiBjYXNlIGVuZHB0ciBp cyBOVUxMLiAqLworICAgIFVWIHZhbCA9IDA7IC8qIFRoZSBwYXJzZWQgdmFsdWUuICovCisKKyAg ICBQRVJMX0FSR1NfQVNTRVJUX0dST0tfQVRPVVY7CisKKyAgICBlcHRyID0gZW5kcHRyID8gZW5k cHRyIDogJmVuZDI7CisgICAgaWYgKGlzRElHSVQoKnMpKSB7CisgICAgICAgIC8qIFNpbmdsZS1k aWdpdCBpbnB1dHMgYXJlIHF1aXRlIGNvbW1vbi4gKi8KKyAgICAgICAgdmFsID0gKnMrKyAtICcw JzsKKyAgICAgICAgaWYgKGlzRElHSVQoKnMpKSB7CisgICAgICAgICAgICAvKiBGYWlsIG9uIGV4 dHJhIGxlYWRpbmcgemVyb3MuICovCisgICAgICAgICAgICBpZiAodmFsID09IDApCisgICAgICAg ICAgICAgICAgcmV0dXJuIEZBTFNFOworICAgICAgICAgICAgd2hpbGUgKGlzRElHSVQoKnMpKSB7 CisgICAgICAgICAgICAgICAgLyogVGhpcyBjb3VsZCBiZSB1bnJvbGxlZCBsaWtlIGluIGdyb2tf bnVtYmVyKCksIGJ1dAorICAgICAgICAgICAgICAgICAqIHRoZSBleHBlY3RlZCB1c2VzIG9mIHRo aXMgYXJlIG5vdCBzcGVlZC1uZWVkeSwgYW5kCisgICAgICAgICAgICAgICAgICogdW5saWtlbHkg dG8gbmVlZCBmdWxsIDY0LWJpdG5lc3MuICovCisgICAgICAgICAgICAgICAgY29uc3QgVTggZGln aXQgPSAqcysrIC0gJzAnOworICAgICAgICAgICAgICAgIGlmICh2YWwgPCB1dl9tYXhfZGl2XzEw IHx8CisgICAgICAgICAgICAgICAgICAgICh2YWwgPT0gdXZfbWF4X2Rpdl8xMCAmJiBkaWdpdCA8 PSB1dl9tYXhfbW9kXzEwKSkgeworICAgICAgICAgICAgICAgICAgICB2YWwgPSB2YWwgKiAxMCAr IGRpZ2l0OworICAgICAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAgICAgIHJl dHVybiBGQUxTRTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9CisgICAgICAgIH0K KyAgICB9CisgICAgaWYgKHMgPT0gcHYpCisgICAgICAgIHJldHVybiBGQUxTRTsKKyAgICBpZiAo ZW5kcHRyID09IE5VTEwgJiYgKnMpCisgICAgICAgIHJldHVybiBGQUxTRTsgLyogSWYgZW5kcHRy IGlzIE5VTEwsIG5vIHRyYWlsaW5nIG5vbi1kaWdpdHMgYWxsb3dlZC4gKi8KKyAgICAqZXB0ciA9 IHM7CisgICAgKnZhbHB0ciA9IHZhbDsKKyAgICByZXR1cm4gVFJVRTsKK30KKworCisKKwogaW50 CiBQZXJsX21hZ2ljX3NldChwVEhYXyBTViAqc3YsIE1BR0lDICptZykKIHsKQEAgLTMxNzgsNyAr MzI1NSw3IEBAIFBlcmxfbWFnaWNfc2V0KHBUSFhfIFNWICpzdiwgTUFHSUMgKm1nKQogCXsKIAkg ICAgY29uc3QgY2hhciAqcCA9IFN2UFZfY29uc3Qoc3YsIGxlbik7CiAgICAgICAgICAgICBHcm91 cHNfdCAqZ2FyeSA9IE5VTEw7Ci0gICAgICAgICAgICBjb25zdCBjaGFyKiBlbmRwdHIgPSBwICsg bGVuOworICAgICAgICAgICAgY29uc3QgY2hhciogZW5kcHRyOwogICAgICAgICAgICAgVVYgdXY7 CiAjaWZkZWYgX1NDX05HUk9VUFNfTUFYCiAgICAgICAgICAgIGludCBtYXhncnAgPSBzeXNjb25m KF9TQ19OR1JPVVBTX01BWCk7CkBAIC0zMTkxLDcgKzMyNjgsNyBAQCBQZXJsX21hZ2ljX3NldChw VEhYXyBTViAqc3YsIE1BR0lDICptZykKIAogICAgICAgICAgICAgd2hpbGUgKGlzU1BBQ0UoKnAp KQogICAgICAgICAgICAgICAgICsrcDsKLSAgICAgICAgICAgIGlmIChncm9rX2F0b1VWKHAsICZ1 diwgJmVuZHB0cikpCisgICAgICAgICAgICBpZiAoZ3Jva19hdG9VVl9ycChwLCAmdXYsICZlbmRw dHIpKQogICAgICAgICAgICAgICAgIG5ld19lZ2lkID0gKEdpZF90KXV2OwogICAgICAgICAgICAg ZWxzZSB7CiAgICAgICAgICAgICAgICAgbmV3X2VnaWQgPSBJTlZBTElEX0dJRDsKQEAgLTMyMDks NyArMzI4Niw3IEBAIFBlcmxfbWFnaWNfc2V0KHBUSFhfIFNWICpzdiwgTUFHSUMgKm1nKQogICAg ICAgICAgICAgICAgICAgICBOZXd4KGdhcnksIGkgKyAxLCBHcm91cHNfdCk7CiAgICAgICAgICAg ICAgICAgZWxzZQogICAgICAgICAgICAgICAgICAgICBSZW5ldyhnYXJ5LCBpICsgMSwgR3JvdXBz X3QpOwotICAgICAgICAgICAgICAgIGlmIChncm9rX2F0b1VWKHAsICZ1diwgJmVuZHB0cikpCisg ICAgICAgICAgICAgICAgaWYgKGdyb2tfYXRvVVZfcnAocCwgJnV2LCAmZW5kcHRyKSkKICAgICAg ICAgICAgICAgICAgICAgZ2FyeVtpXSA9IChHcm91cHNfdCl1djsKICAgICAgICAgICAgICAgICBl bHNlIHsKICAgICAgICAgICAgICAgICAgICAgZ2FyeVtpXSA9IElOVkFMSURfR0lEOwo= 4527 2019-06-13 22:04:38 +0000 2019-06-13 22:04:38 +0000 Simpler patch to fix the problem test.patch text/plain 801 richard.purdie SW5kZXg6IHBlcmwtNS4zMC4wL21nLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGVybC01LjMwLjAub3JpZy9t Zy5jCisrKyBwZXJsLTUuMzAuMC9tZy5jCkBAIC0zMTc5LDYgKzMyNTYsNyBAQCBQZXJsX21hZ2lj X3NldChwVEhYXyBTViAqc3YsIE1BR0lDICptZykKIAkgICAgY29uc3QgY2hhciAqcCA9IFN2UFZf Y29uc3Qoc3YsIGxlbik7CiAgICAgICAgICAgICBHcm91cHNfdCAqZ2FyeSA9IE5VTEw7CiAgICAg ICAgICAgICBjb25zdCBjaGFyKiBlbmRwdHIgPSBwICsgbGVuOworICAgICAgICAgICAgY29uc3Qg Y2hhciogcmVhbGVuZCA9IHAgKyBsZW47CiAgICAgICAgICAgICBVViB1djsKICNpZmRlZiBfU0Nf TkdST1VQU19NQVgKICAgICAgICAgICAgaW50IG1heGdycCA9IHN5c2NvbmYoX1NDX05HUk9VUFNf TUFYKTsKQEAgLTMyMDksNiArMzI4Nyw3IEBAIFBlcmxfbWFnaWNfc2V0KHBUSFhfIFNWICpzdiwg TUFHSUMgKm1nKQogICAgICAgICAgICAgICAgICAgICBOZXd4KGdhcnksIGkgKyAxLCBHcm91cHNf dCk7CiAgICAgICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgICAgICBSZW5ldyhnYXJ5 LCBpICsgMSwgR3JvdXBzX3QpOworICAgICAgICAgICAgICAgIGVuZHB0ciA9IHJlYWxlbmQ7CiAg ICAgICAgICAgICAgICAgaWYgKGdyb2tfYXRvVVYocCwgJnV2LCAmZW5kcHRyKSkKICAgICAgICAg ICAgICAgICAgICAgZ2FyeVtpXSA9IChHcm91cHNfdCl1djsKICAgICAgICAgICAgICAgICBlbHNl IHsK